You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Vamsee Yarlagadda <va...@cloudera.com> on 2017/03/03 22:22:38 UTC
Review Request 57308: SENTRY-1388: Make HiveConf and Hive client jars
available to Sentry deamon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57308/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar kalvagadda.
Repository: sentry
Description
-------
Hive client jars will automatically be put under the classpath of Sentry process by Maven. For hive-conf, one has to set a standard environmental variable for defining Hive client configs - HIVE_CONF_DIR. In order for sentry to pick this up, this patch will make sentry scripts be aware of this variable.
Diffs
-----
bin/sentry 93809eaa1beb617d6977966e4ffa1d1262e8d3d9
Diff: https://reviews.apache.org/r/57308/diff/1/
Testing
-------
Trivial but will test it out on real cluster before poushing in
Thanks,
Vamsee Yarlagadda
Re: Review Request 57308: SENTRY-1388: Make HiveConf and Hive client
jars available to Sentry deamon
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57308/#review167954
-----------------------------------------------------------
Ship it!
Ship It!
- Hao Hao
On March 3, 2017, 10:41 p.m., Vamsee Yarlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57308/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 10:41 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar kalvagadda.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Hive client jars will automatically be put under the classpath of Sentry process by Maven. For hive-conf, one has to set a standard environmental variable for defining Hive client configs - HIVE_CONF_DIR. In order for sentry to pick this up, this patch will make sentry scripts be aware of this variable.
>
>
> Diffs
> -----
>
> bin/sentry 93809eaa1beb617d6977966e4ffa1d1262e8d3d9
>
>
> Diff: https://reviews.apache.org/r/57308/diff/1/
>
>
> Testing
> -------
>
> Tested on the cluster before and after the patch and verified the client configs are being passed correctly in a way that HiveConf instantiation is automatically picking up.
>
> (Screenshot attached)
>
>
> File Attachments
> ----------------
>
> Configs being picked up
> https://reviews.apache.org/media/uploaded/files/2017/03/03/34145b57-cb71-4816-aa8d-3b669f90ec87__Screen_Shot_2017-03-04_at_4.09.56_AM.png
>
>
> Thanks,
>
> Vamsee Yarlagadda
>
>
Re: Review Request 57308: SENTRY-1388: Make HiveConf and Hive client
jars available to Sentry deamon
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
> On March 4, 2017, 12:55 a.m., Alexander Kolbasov wrote:
> > bin/sentry
> > Lines 78 (patched)
> > <https://reviews.apache.org/r/57308/diff/1/?file=1655752#file1655752line78>
> >
> > Do you need to check that HIVE_CONF_DIR is set?
> > Something like
> >
> > [[ -n $HIVE_CONF_DIR ]] && HADOOP_CLASSPATH+=":${HIVE_CONF_DIR}"
I thought about this, but it shouldn't hurt the definition of classpath even though if it is not set/empty. So I went with something easier to read (code wise).
- Vamsee
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57308/#review167913
-----------------------------------------------------------
On March 3, 2017, 10:41 p.m., Vamsee Yarlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57308/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 10:41 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar kalvagadda.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Hive client jars will automatically be put under the classpath of Sentry process by Maven. For hive-conf, one has to set a standard environmental variable for defining Hive client configs - HIVE_CONF_DIR. In order for sentry to pick this up, this patch will make sentry scripts be aware of this variable.
>
>
> Diffs
> -----
>
> bin/sentry 93809eaa1beb617d6977966e4ffa1d1262e8d3d9
>
>
> Diff: https://reviews.apache.org/r/57308/diff/1/
>
>
> Testing
> -------
>
> Tested on the cluster before and after the patch and verified the client configs are being passed correctly in a way that HiveConf instantiation is automatically picking up.
>
> (Screenshot attached)
>
>
> File Attachments
> ----------------
>
> Configs being picked up
> https://reviews.apache.org/media/uploaded/files/2017/03/03/34145b57-cb71-4816-aa8d-3b669f90ec87__Screen_Shot_2017-03-04_at_4.09.56_AM.png
>
>
> Thanks,
>
> Vamsee Yarlagadda
>
>
Re: Review Request 57308: SENTRY-1388: Make HiveConf and Hive client
jars available to Sentry deamon
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57308/#review167913
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
bin/sentry
Lines 78 (patched)
<https://reviews.apache.org/r/57308/#comment239881>
Do you need to check that HIVE_CONF_DIR is set?
Something like
[[ -n $HIVE_CONF_DIR ]] && HADOOP_CLASSPATH+=":${HIVE_CONF_DIR}"
- Alexander Kolbasov
On March 3, 2017, 10:41 p.m., Vamsee Yarlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57308/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 10:41 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar kalvagadda.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Hive client jars will automatically be put under the classpath of Sentry process by Maven. For hive-conf, one has to set a standard environmental variable for defining Hive client configs - HIVE_CONF_DIR. In order for sentry to pick this up, this patch will make sentry scripts be aware of this variable.
>
>
> Diffs
> -----
>
> bin/sentry 93809eaa1beb617d6977966e4ffa1d1262e8d3d9
>
>
> Diff: https://reviews.apache.org/r/57308/diff/1/
>
>
> Testing
> -------
>
> Tested on the cluster before and after the patch and verified the client configs are being passed correctly in a way that HiveConf instantiation is automatically picking up.
>
> (Screenshot attached)
>
>
> File Attachments
> ----------------
>
> Configs being picked up
> https://reviews.apache.org/media/uploaded/files/2017/03/03/34145b57-cb71-4816-aa8d-3b669f90ec87__Screen_Shot_2017-03-04_at_4.09.56_AM.png
>
>
> Thanks,
>
> Vamsee Yarlagadda
>
>
Re: Review Request 57308: SENTRY-1388: Make HiveConf and Hive client
jars available to Sentry deamon
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57308/
-----------------------------------------------------------
(Updated March 3, 2017, 10:41 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar kalvagadda.
Repository: sentry
Description
-------
Hive client jars will automatically be put under the classpath of Sentry process by Maven. For hive-conf, one has to set a standard environmental variable for defining Hive client configs - HIVE_CONF_DIR. In order for sentry to pick this up, this patch will make sentry scripts be aware of this variable.
Diffs
-----
bin/sentry 93809eaa1beb617d6977966e4ffa1d1262e8d3d9
Diff: https://reviews.apache.org/r/57308/diff/1/
Testing (updated)
-------
Tested on the cluster before and after the patch and verified the client configs are being passed correctly in a way that HiveConf instantiation is automatically picking up.
(Screenshot attached)
File Attachments (updated)
----------------
Configs being picked up
https://reviews.apache.org/media/uploaded/files/2017/03/03/34145b57-cb71-4816-aa8d-3b669f90ec87__Screen_Shot_2017-03-04_at_4.09.56_AM.png
Thanks,
Vamsee Yarlagadda