You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/30 17:08:20 UTC
[jira] [Commented] (BEAM-695) DisplayData for PipelineOptions fails
to correctly toString array types
[ https://issues.apache.org/jira/browse/BEAM-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15536490#comment-15536490 ]
ASF GitHub Bot commented on BEAM-695:
-------------------------------------
GitHub user swegner opened a pull request:
https://github.com/apache/incubator-beam/pull/1034
[BEAM-695] PipelineOptions display data needs to handle array types
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
PipelineOptions generates display data for arbitrary option types
using #toString(). For array types, this gives an message like
[Ljava.lang.String;@fc25934b]. Instead, we detect array types
and use Arrays.deepString to build a string based on array values.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swegner/incubator-beam displaydata-array-string
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1034.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1034
----
commit ca12648f5ce0b744c30cfa6bbcd486519ae1bf95
Author: Scott Wegner <sw...@google.com>
Date: 2016-09-30T17:05:00Z
PipelineOptions display data needs to handle array types
PipelineOptions generates display data for arbitrary option types
using #toString(). For array types, this gives an message like
[Ljava.lang.String;@fc25934b]. Instead, we detect array types
and use Arrays.deepString to build a string based on array values.
----
> DisplayData for PipelineOptions fails to correctly toString array types
> -----------------------------------------------------------------------
>
> Key: BEAM-695
> URL: https://issues.apache.org/jira/browse/BEAM-695
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Scott Wegner
> Priority: Minor
>
> For array types in Java, toString produces an uninformative message like
> [Ljava.lang.String;@fc258b1
> You need to check to see if its an array type and call Arrays.toString(array).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)