You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/06 01:41:37 UTC
[PR] test: add first coverage for consumer group settings DTO [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3925:
URL: https://github.com/apache/rocketmq-dashboard/pull/3925
### Motivation
The `UpdateConsumerGroupSettingsDTO` used by the group settings form had no unit coverage for its validation rules. This PR adds the first three cases.
### Changes
- Missing instance/group names are rejected.
- Missing or zero retry queue counts are rejected with their required/positive messages.
- A fully valid settings request passes validation.
### Verification
- `mvn -B test -Dtest=UpdateConsumerGroupSettingsDTOTest`: 3/3 passed, BUILD SUCCESS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: add first coverage for consumer group settings DTO [rocketmq-dashboard]
Posted by "yyqdbngt (via GitHub)" <gi...@apache.org>.
yyqdbngt commented on PR #3925:
URL: https://github.com/apache/rocketmq-dashboard/pull/3925#issuecomment-5691163060
Superseded by `#4123` (`fix(group): allow zero retry settings on update`, commit `c7193109`), so I am closing this.
The base branch already carries the substance of this PR — `UpdateConsumerGroupSettingsDTO` now uses `@PositiveOrZero(message = "retryQueueNums must be zero or positive")`, and `UpdateConsumerGroupSettingsDTOTest` on `rocketmq-studio` already contains `shouldAcceptZeroRetrySettingsTest` and `shouldRejectNegativeRetrySettingsTest` with the same rationale.
One assertion here is actively wrong against the merged behaviour: `retrySettingsShouldBeRequiredAndPositive` expects `retryQueueNums = 0` to produce `"retryQueueNums must be positive"`, but the base now accepts `0`. Rebased locally, that test fails (`Expecting actual: [] to contain exactly in any order: ["retryQueueNums must be positive"]`) while the rest of the file passes, i.e. this PR would have to drop the assertion it was arguing for. Nothing to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: add first coverage for consumer group settings DTO [rocketmq-dashboard]
Posted by "yyqdbngt (via GitHub)" <gi...@apache.org>.
yyqdbngt commented on PR #3925:
URL: https://github.com/apache/rocketmq-dashboard/pull/3925#issuecomment-5691163376
Closing as superseded by #4123 - see the comment above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: add first coverage for consumer group settings DTO [rocketmq-dashboard]
Posted by "yyqdbngt (via GitHub)" <gi...@apache.org>.
yyqdbngt closed pull request #3925: test: add first coverage for consumer group settings DTO
URL: https://github.com/apache/rocketmq-dashboard/pull/3925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org