You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "michael-o (via GitHub)" <gi...@apache.org> on 2024/09/21 16:29:18 UTC

[PR] [MJAVADOC-812] [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty… [maven-javadoc-plugin]

michael-o opened a new pull request, #320:
URL: https://github.com/apache/maven-javadoc-plugin/pull/320

   … JARs
   
   This closes #320
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
          for the change (usually before you start working on it).  Trivial changes like typos do not
          require a JIRA issue.  Your pull request should address just this issue, without
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will
          be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MJAVADOC-812] [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty… [maven-javadoc-plugin]

Posted by "pzygielo (via GitHub)" <gi...@apache.org>.
pzygielo commented on PR #320:
URL: https://github.com/apache/maven-javadoc-plugin/pull/320#issuecomment-2365247324

   > I am very surprised that no unit or integration test has failed here
   
   Still no test I see... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MJAVADOC-812] [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty… [maven-javadoc-plugin]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #320:
URL: https://github.com/apache/maven-javadoc-plugin/pull/320#issuecomment-2365262254

   > > I am very surprised that no unit or integration test has failed here
   > 
   > Still no test I see...
   
   True, waiting for the confirmation first. If you want to contribute a test that would me more than great.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MJAVADOC-812] [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty… [maven-javadoc-plugin]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #320:
URL: https://github.com/apache/maven-javadoc-plugin/pull/320#issuecomment-2370475121

   @pzygielo IT added.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MJAVADOC-812] [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty… [maven-javadoc-plugin]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o closed pull request #320: [MJAVADOC-812] [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty…
URL: https://github.com/apache/maven-javadoc-plugin/pull/320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MJAVADOC-812] [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty… [maven-javadoc-plugin]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o merged PR #320:
URL: https://github.com/apache/maven-javadoc-plugin/pull/320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MJAVADOC-812] [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty… [maven-javadoc-plugin]

Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #320:
URL: https://github.com/apache/maven-javadoc-plugin/pull/320#issuecomment-2957404084

   Resolve #1189


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MJAVADOC-812] [REGRESSION] maven-javadoc-plugin 3.10.0 creates empty… [maven-javadoc-plugin]

Posted by "krezovic (via GitHub)" <gi...@apache.org>.
krezovic commented on PR #320:
URL: https://github.com/apache/maven-javadoc-plugin/pull/320#issuecomment-2366817587

   I am the same person who reported the bug, but I write from personal account here since I don't have the credentials from the work account on my personal machine.
   
   When I checkout this branch and build the plugin, then build the reproducer I provided, it seems OK
   
   ![image](https://github.com/user-attachments/assets/c2ff7433-3524-4d5f-81cb-f9bc915a9a17)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org