You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/10/05 14:05:34 UTC

Review Request 38996: alerts should log into ambari-agent.log rather than to ambari-agent.out

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38996/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-13310
    https://issues.apache.org/jira/browse/AMBARI-13310


Repository: ambari


Description
-------


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py f8f220b 
  ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py e70dc22 
  ambari-agent/src/main/python/ambari_agent/main.py 25f7fa0 
  ambari-agent/src/test/python/ambari_agent/TestMain.py 995dcca 
  ambari-common/src/main/python/resource_management/core/environment.py 907521f 

Diff: https://reviews.apache.org/r/38996/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 38996: alerts should log into ambari-agent.log rather than to ambari-agent.out

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38996/#review101467
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Жов. 5, 2015, 12:07 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38996/
> -----------------------------------------------------------
> 
> (Updated Жов. 5, 2015, 12:07 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13310
>     https://issues.apache.org/jira/browse/AMBARI-13310
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The problem is that ambari-agent.out is not rolled and if ambari-agent is started for a long time, the out grows too huge. Also it's usefull to see alerts time in logs.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py f8f220b 
>   ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py e70dc22 
>   ambari-agent/src/main/python/ambari_agent/main.py 25f7fa0 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 995dcca 
>   ambari-common/src/main/python/resource_management/core/environment.py 907521f 
> 
> Diff: https://reviews.apache.org/r/38996/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 38996: alerts should log into ambari-agent.log rather than to ambari-agent.out

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38996/
-----------------------------------------------------------

(Updated Oct. 5, 2015, 12:07 p.m.)


Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-13310
    https://issues.apache.org/jira/browse/AMBARI-13310


Repository: ambari


Description (updated)
-------

The problem is that ambari-agent.out is not rolled and if ambari-agent is started for a long time, the out grows too huge. Also it's usefull to see alerts time in logs.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py f8f220b 
  ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py e70dc22 
  ambari-agent/src/main/python/ambari_agent/main.py 25f7fa0 
  ambari-agent/src/test/python/ambari_agent/TestMain.py 995dcca 
  ambari-common/src/main/python/resource_management/core/environment.py 907521f 

Diff: https://reviews.apache.org/r/38996/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk