You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/18 10:53:33 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #2428: HDDS-5436. Add acceptance test for Hadoop 3.3
adoroszlai opened a new pull request #2428:
URL: https://github.com/apache/ozone/pull/2428
## What changes were proposed in this pull request?
Add `ozone-mr` test run for Hadoop 3.3.1, and also upgrade `ozonesecure-mr` to the new version.
https://issues.apache.org/jira/browse/HDDS-5436
## How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/3096436774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on a change in pull request #2428: HDDS-5436. Add acceptance test for Hadoop 3.3
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on a change in pull request #2428:
URL: https://github.com/apache/ozone/pull/2428#discussion_r671847107
##########
File path: hadoop-ozone/dist/src/main/smoketest/ozonefs/hadoopo3fs.robot
##########
@@ -36,4 +36,4 @@ Test hadoop dfs
${result} = Execute hdfs dfs -ls ${dir}
Should contain ${result} ${PREFIX}-${random}
${result} = Execute hdfs dfs -cat ${dir}/${PREFIX}-${random}
- Should contain ${result} This product includes software developed by The Apache Software
\ No newline at end of file
+ Should contain ${result} This product includes software developed
Review comment:
Also, has the output changed ? if so, whats the difference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2428: HDDS-5436. Add acceptance test for Hadoop 3.3
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2428:
URL: https://github.com/apache/ozone/pull/2428#issuecomment-882164378
Thanks @mukul1987 for reviewing and merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on a change in pull request #2428: HDDS-5436. Add acceptance test for Hadoop 3.3
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on a change in pull request #2428:
URL: https://github.com/apache/ozone/pull/2428#discussion_r671847015
##########
File path: hadoop-ozone/dist/src/main/smoketest/ozonefs/hadoopo3fs.robot
##########
@@ -36,4 +36,4 @@ Test hadoop dfs
${result} = Execute hdfs dfs -ls ${dir}
Should contain ${result} ${PREFIX}-${random}
${result} = Execute hdfs dfs -cat ${dir}/${PREFIX}-${random}
- Should contain ${result} This product includes software developed by The Apache Software
\ No newline at end of file
+ Should contain ${result} This product includes software developed
Review comment:
This is change intentional ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2428: HDDS-5436. Add acceptance test for Hadoop 3.3
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2428:
URL: https://github.com/apache/ozone/pull/2428#discussion_r671921972
##########
File path: hadoop-ozone/dist/src/main/smoketest/ozonefs/hadoopo3fs.robot
##########
@@ -36,4 +36,4 @@ Test hadoop dfs
${result} = Execute hdfs dfs -ls ${dir}
Should contain ${result} ${PREFIX}-${random}
${result} = Execute hdfs dfs -cat ${dir}/${PREFIX}-${random}
- Should contain ${result} This product includes software developed by The Apache Software
\ No newline at end of file
+ Should contain ${result} This product includes software developed
Review comment:
Yes, Hadoop's NOTICE.txt [has changed](https://github.com/apache/hadoop/commit/567091aa9b3f001208470345c673059c0a138b69#diff-b810ebe4ffda4293c79d292059b45b59de7e649e86314ffd5a1ee4eb4b1e08c8). The relevant part:
```diff
-This product includes software developed by The Apache Software
-Foundation (http://www.apache.org/).
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
```
So I changed the test to only look for the common prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 merged pull request #2428: HDDS-5436. Add acceptance test for Hadoop 3.3
Posted by GitBox <gi...@apache.org>.
mukul1987 merged pull request #2428:
URL: https://github.com/apache/ozone/pull/2428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 commented on a change in pull request #2428: HDDS-5436. Add acceptance test for Hadoop 3.3
Posted by GitBox <gi...@apache.org>.
mukul1987 commented on a change in pull request #2428:
URL: https://github.com/apache/ozone/pull/2428#discussion_r671932250
##########
File path: hadoop-ozone/dist/src/main/smoketest/ozonefs/hadoopo3fs.robot
##########
@@ -36,4 +36,4 @@ Test hadoop dfs
${result} = Execute hdfs dfs -ls ${dir}
Should contain ${result} ${PREFIX}-${random}
${result} = Execute hdfs dfs -cat ${dir}/${PREFIX}-${random}
- Should contain ${result} This product includes software developed by The Apache Software
\ No newline at end of file
+ Should contain ${result} This product includes software developed
Review comment:
Ok thanks, makes sense to me. +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org