You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@arrow.apache.org by "Antoine Pitrou (Jira)" <ji...@apache.org> on 2021/12/13 18:05:00 UTC

[jira] [Commented] (ARROW-14133) [C++] Simplify registration of scalar arithmetic/string functions

    [ https://issues.apache.org/jira/browse/ARROW-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458588#comment-17458588 ] 

Antoine Pitrou commented on ARROW-14133:
----------------------------------------

[~edponce] Do you want to submit a PR here?

> [C++] Simplify registration of scalar arithmetic/string functions
> -----------------------------------------------------------------
>
>                 Key: ARROW-14133
>                 URL: https://issues.apache.org/jira/browse/ARROW-14133
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Eduardo Ponce
>            Priority: Trivial
>              Labels: kernel
>             Fix For: 7.0.0
>
>
> Most scalar arithmetic functions use variants of *MakeXXXFunction* to create a *ScalarFunction* which is then registered in another statement. Function registration can be moved inside of the *MakeXXXFunctions* and renamed as *AddXXXFunction* to simplify/reduce the code. This also applies to some scalar string *MakeXXX* functions.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)