You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/03/08 03:48:54 UTC
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #684: [#80][Part-3] feat: add REST API for decommisson
kaijchen commented on code in PR #684:
URL: https://github.com/apache/incubator-uniffle/pull/684#discussion_r1128946130
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java:
##########
@@ -179,6 +183,19 @@ private void initialization() throws Exception {
server = coordinatorFactory.getServer();
}
+ private void registerRESTAPI() throws Exception {
+ LOG.info("Register REST API");
+ jettyServer.addServlet(
+ new NodesServlet(this),
+ "/api/server/nodes");
+ jettyServer.addServlet(
+ new DecommissionServlet(this),
+ "/api/server/decommission");
+ jettyServer.addServlet(
+ new CancelDecommissionServlet(this),
+ "/api/server/cancelDecommission");
Review Comment:
Please fix the indentation here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org