You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/05 06:27:56 UTC
[GitHub] [apisix-ingress-controller] zhaojizhuang opened a new issue #618: Feature Suggest Support hot reload when configmap changed
zhaojizhuang opened a new issue #618:
URL: https://github.com/apache/apisix-ingress-controller/issues/618
### Issue description
Feature Suggest:
Support hot reload when configmap `ingress-apisix/apisix-ingress-controller-configmap`changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #618: Feature Suggest support hot reload when configmap changed
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #618:
URL: https://github.com/apache/apisix-ingress-controller/issues/618#issuecomment-893342093
> > Can you describe the business scenario?
>
> Such as : change `log level`, `enable profile`.Just hope it will take effect immediately like ingress nginx
ingress-nginx watches on files like nginx template, geoip files, but it doesn't watch on its own (the control plane) configuration file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #618: Feature Suggest support hot reload when configmap changed
Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #618:
URL: https://github.com/apache/apisix-ingress-controller/issues/618#issuecomment-893204057
Good proposal, but there are fewer use cases for this feature.
The apisix-ingress-controller is the control plane, which can be restarted at any time without affecting business traffic. Moreover, the modification of configmap is a very low-frequency operation, and doesn’t really need hot reload.
Can you describe the business scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] zhaojizhuang commented on issue #618: Feature Suggest support hot reload when configmap changed
Posted by GitBox <gi...@apache.org>.
zhaojizhuang commented on issue #618:
URL: https://github.com/apache/apisix-ingress-controller/issues/618#issuecomment-893441542
@tokers ingress-nginx's control plane configuration (such as `profiling` )is define in command args. So update deploy will update the Pod。What I mean is that it is best to support hot reload if the configurations is defined in configmap，otherwise，why not defined in container command args？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] zhaojizhuang commented on issue #618: Feature Suggest support hot reload when configmap changed
Posted by GitBox <gi...@apache.org>.
zhaojizhuang commented on issue #618:
URL: https://github.com/apache/apisix-ingress-controller/issues/618#issuecomment-893209657
> Can you describe the business scenario?
Such as : change `log level`, `enable profile`.Just hope it will take effect immediately like ingress nginx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #618: Feature Suggest support hot reload when configmap changed
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #618:
URL: https://github.com/apache/apisix-ingress-controller/issues/618#issuecomment-893342093
> > Can you describe the business scenario?
>
> Such as : change `log level`, `enable profile`.Just hope it will take effect immediately like ingress nginx
ingress-nginx watches on files like nginx template, geoip files, but it doesn't watch on its own (the control plane) configuration file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #618: Feature Suggest support hot reload when configmap changed
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #618:
URL: https://github.com/apache/apisix-ingress-controller/issues/618#issuecomment-893962761
> @tokers ingress-nginx's control plane configuration (such as `profiling` )is define in command args. So the updation of deploy will update the Pod。What I mean is that it is best to support hot reload if the configurations is defined in configmap，otherwise，why not defined in container command args？
Settings in configmap (actually is the configuration file for apisix-ingress-controller) are the same as command line args.
Anyway, PR is welcome to support this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] zhaojizhuang commented on issue #618: Feature Suggest support hot reload when configmap changed
Posted by GitBox <gi...@apache.org>.
zhaojizhuang commented on issue #618:
URL: https://github.com/apache/apisix-ingress-controller/issues/618#issuecomment-893209657
> Can you describe the business scenario?
Such as : change `log level`, `enable profile`.Just hope it will take effect immediately like ingress nginx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #618: Feature Suggest support hot reload when configmap changed
Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #618:
URL: https://github.com/apache/apisix-ingress-controller/issues/618#issuecomment-893204057
Good proposal, but there are fewer use cases for this feature.
The apisix-ingress-controller is the control plane, which can be restarted at any time without affecting business traffic. Moreover, the modification of configmap is a very low-frequency operation, and doesn’t really need hot reload.
Can you describe the business scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] zhaojizhuang commented on issue #618: Feature Suggest support hot reload when configmap changed
Posted by GitBox <gi...@apache.org>.
zhaojizhuang commented on issue #618:
URL: https://github.com/apache/apisix-ingress-controller/issues/618#issuecomment-893424610
@tokers configmap `ingress-nginx/ingress-nginx-controller`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] zhaojizhuang edited a comment on issue #618: Feature Suggest support hot reload when configmap changed
Posted by GitBox <gi...@apache.org>.
zhaojizhuang edited a comment on issue #618:
URL: https://github.com/apache/apisix-ingress-controller/issues/618#issuecomment-893441542
@tokers ingress-nginx's control plane configuration (such as `profiling` )is define in command args. So the updation of deploy will update the Pod。What I mean is that it is best to support hot reload if the configurations is defined in configmap，otherwise，why not defined in container command args？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] zhaojizhuang removed a comment on issue #618: Feature Suggest support hot reload when configmap changed
Posted by GitBox <gi...@apache.org>.
zhaojizhuang removed a comment on issue #618:
URL: https://github.com/apache/apisix-ingress-controller/issues/618#issuecomment-893424610
@tokers configmap `ingress-nginx/ingress-nginx-controller`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org