You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/04/09 10:04:18 UTC

[GitHub] [servicecomb-java-chassis] heyile opened a new pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

heyile opened a new pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#discussion_r406145572
 
 

 ##########
 File path: dependencies/bom/pom.xml
 ##########
 @@ -365,6 +365,12 @@
         <artifactId>transport-rest-vertx</artifactId>
         <version>${project.version}</version>
       </dependency>
+      <!-- ServiceComb third-extensions -->
+      <dependency>
 
 Review comment:
   1. sort all modules in folder name, do not put in end
   2. modify distributions.xml
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#discussion_r406153361
 
 

 ##########
 File path: third-part-extensions/cas-env-variables/src/main/java/org/apache/servicecomb/cas/CasEnvConfig.java
 ##########
 @@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.cas;
 
 Review comment:
   org.apache.servicecomb.huaweicloud.cas

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#discussion_r406146040
 
 

 ##########
 File path: dependencies/bom/pom.xml
 ##########
 @@ -365,6 +365,12 @@
         <artifactId>transport-rest-vertx</artifactId>
         <version>${project.version}</version>
       </dependency>
+      <!-- ServiceComb third-extensions -->
+      <dependency>
+        <groupId>org.apache.servicecomb</groupId>
+        <artifactId>cas-env-variables</artifactId>
 
 Review comment:
   suggestions:
   
   third-party-extension/huaweicloud,  do not use cas. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile closed pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
heyile closed pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile commented on issue #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
heyile commented on issue #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#issuecomment-611445934
 
 
   support register cas  env variables to the service center
   
   ```pom
       < !-- just need add dependency -->
       <dependency>
         <groupId>org.apache.servicecomb</groupId>
         <artifactId>cas-env-variables</artifactId>
       </dependency>
   ```
   
   the cas variable is showed as bellow:
   
   ```
   CAS_APPLICATION_ID
   
   CAS_COMPONENT_NAME
   
   CAS_INSTANCE_VERSION
   
   CAS_INSTANCE_ID
   
   CAS_ENVIRONMENT_ID
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#issuecomment-611462093
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29985602/badge)](https://coveralls.io/builds/29985602)
   
   Coverage increased (+0.02%) to 85.038% when pulling **f89f743274fe37829decc94fef3ef63f77ead081 on heyile:heyile-scb-1862** into **e5efa3586e4b3ffe6fec1bfd0a89febc285ae4e6 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile opened a new pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
heyile opened a new pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#issuecomment-611462093
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29985585/badge)](https://coveralls.io/builds/29985585)
   
   Coverage increased (+0.02%) to 85.041% when pulling **f89f743274fe37829decc94fef3ef63f77ead081 on heyile:heyile-scb-1862** into **e5efa3586e4b3ffe6fec1bfd0a89febc285ae4e6 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#discussion_r406146709
 
 

 ##########
 File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/adapter/DefaultEnvAdapter.java
 ##########
 @@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.serviceregistry.adapter;
+
+public class DefaultEnvAdapter implements EnvAdapter {
+  @Override
+  public String getEnvName() {
+    return "default-env-default-adapter";
 
 Review comment:
   default-env-adapter

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#issuecomment-611462093
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29964006/badge)](https://coveralls.io/builds/29964006)
   
   Coverage increased (+0.01%) to 85.044% when pulling **5485ad5132e5d2c8d4aa617065e03982e454139d on heyile:heyile-scb-1862** into **7bea69a16bb92a1a2493587ef68ec7f9c1d41dcc on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
heyile commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#discussion_r406263607
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -126,6 +126,7 @@
     <module>inspector</module>
     <module>solutions</module>
     <module>clients</module>
+    <module>third-part-extensions</module>
 
 Review comment:
       <module>huawei-cloud</module>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
heyile commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#discussion_r406263347
 
 

 ##########
 File path: dependencies/bom/pom.xml
 ##########
 @@ -365,6 +365,12 @@
         <artifactId>transport-rest-vertx</artifactId>
         <version>${project.version}</version>
       </dependency>
+      <!-- ServiceComb third-extensions -->
+      <dependency>
+        <groupId>org.apache.servicecomb</groupId>
+        <artifactId>cas-env-variables</artifactId>
 
 Review comment:
   done, use huawei-cloud/servicestage

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile edited a comment on issue #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
heyile edited a comment on issue #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#issuecomment-611445934
 
 
   support register cas  env variables to the service center
   
   ```pom
       < !-- just add dependency -->
       <dependency>
         <groupId>org.apache.servicecomb</groupId>
         <artifactId>servicestage</artifactId>
       </dependency>
   ```
   
   the cas variable is showed as bellow:
   
   ```
   CAS_APPLICATION_ID
   
   CAS_COMPONENT_NAME
   
   CAS_INSTANCE_VERSION
   
   CAS_INSTANCE_ID
   
   CAS_ENVIRONMENT_ID
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
heyile commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#discussion_r406555028
 
 

 ##########
 File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/adapter/DefaultEnvAdapter.java
 ##########
 @@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.serviceregistry.adapter;
+
+public class DefaultEnvAdapter implements EnvAdapter {
+  @Override
+  public String getEnvName() {
+    return "default-env-default-adapter";
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#discussion_r406145572
 
 

 ##########
 File path: dependencies/bom/pom.xml
 ##########
 @@ -365,6 +365,12 @@
         <artifactId>transport-rest-vertx</artifactId>
         <version>${project.version}</version>
       </dependency>
+      <!-- ServiceComb third-extensions -->
+      <dependency>
 
 Review comment:
   1. sort all modules in folder name, do not put in end
   2. modify distributions/pom.xml
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#discussion_r406146400
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -126,6 +126,7 @@
     <module>inspector</module>
     <module>solutions</module>
     <module>clients</module>
+    <module>third-part-extensions</module>
 
 Review comment:
   third-party-extensions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on issue #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#issuecomment-611462093
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29985600/badge)](https://coveralls.io/builds/29985600)
   
   Coverage increased (+0.02%) to 85.044% when pulling **f89f743274fe37829decc94fef3ef63f77ead081 on heyile:heyile-scb-1862** into **e5efa3586e4b3ffe6fec1bfd0a89febc285ae4e6 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#discussion_r406153731
 
 

 ##########
 File path: third-part-extensions/cas-env-variables/src/main/java/org/apache/servicecomb/cas/CasEnvConfig.java
 ##########
 @@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.cas;
+
+import static org.apache.commons.lang3.StringUtils.EMPTY;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.stream.Collectors;
+
+import org.apache.commons.lang3.StringUtils;
+
+import com.netflix.config.DynamicPropertyFactory;
+
+public class CasEnvConfig {
+  private static final String CAS_BASE = "servicecomb.cas.";
 
 Review comment:
   servicecomb.huaweicloud.cas.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] heyile commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables

Posted by GitBox <gi...@apache.org>.
heyile commented on a change in pull request #1705: [SCB-1862] ServiceComb add extensions to support cas env variables
URL: https://github.com/apache/servicecomb-java-chassis/pull/1705#discussion_r406262533
 
 

 ##########
 File path: dependencies/bom/pom.xml
 ##########
 @@ -365,6 +365,12 @@
         <artifactId>transport-rest-vertx</artifactId>
         <version>${project.version}</version>
       </dependency>
+      <!-- ServiceComb third-extensions -->
+      <dependency>
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services