[jira] Commented: (XERCESC-1162) base class warning in SAXException.hpp copy constructor

[xe...@xml.apache.org]

The following comment has been added to this issue:

     Author: Marissa Borrego
    Created: Tue, 27 Jul 2004 12:42 PM
       Body:
FYI, I made a similiar change to XMLPScanToken.hpp, on line 180:
 
inline XMLPScanToken::XMLPScanToken(const XMLPScanToken& toCopy) : 
    XMemory(),
    fScannerId(toCopy.fScannerId),
    fSequenceId(toCopy.fSequenceId)
{
}
 
Below is the warning, using gcc 3.4.0 on Solaris:

g++ -W -Wall -Wno-format-y2k -mcpu=v8 -O2  -Wp,-MD,.deps/tmServer.d -Werror -g  -I./../../xerces-c/module_export/SunOS/include  -c -o

./../../xerces-c/module_export/SunOS/include/xercesc/framework/XMLPScanToken.hpp: In copy constructor `xercesc_2_5::XMLPScanToken::XMLPScanToken(const xercesc_2_5::XMLPScanToken&)':
./../../xerces-c/module_export/SunOS/include/xercesc/framework/XMLPScanToken.hpp:183: warning: base class `class xercesc_2_5::XMemory' should be explicitly initialized in the copy constructor


---------------------------------------------------------------------
View this comment:
  http://issues.apache.org/jira/browse/XERCESC-1162?page=comments#action_36901

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/XERCESC-1162

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: XERCESC-1162
    Summary: base class warning in SAXException.hpp copy constructor
       Type: Bug

     Status: Open

    Project: Xerces-C++
 Components: 
             SAX/SAX2
   Versions:
             2.3.0

   Assignee: Xerces-C Developers Mailing List
   Reporter: Vrajesh Patel

    Created: Tue, 24 Feb 2004 6:35 PM
    Updated: Tue, 27 Jul 2004 12:42 PM
Environment: Operating System: Linux
Platform: PC

Description:
I have been getting multiple copies of this warning:

include/xercesc/sax/SAXException.hpp: In copy constructor 
`xercesc_2_5::SAXException::SAXException(const xercesc_2_5::SAXException&)':
include/xercesc/sax/SAXException.hpp:195: warning: base class `class 
xercesc_2_5::XMemory' should be explicitly initialized in the copy constructor

I have to fix the code in SAXException.hpp by changing this:

    SAXException(const SAXException& toCopy) :

        fMsg(XMLString::replicate(toCopy.fMsg, toCopy.fMemoryManager))
        , fMemoryManager(toCopy.fMemoryManager)
    {
    }

into this:

    SAXException(const SAXException& toCopy) : XMemory(), 

        fMsg(XMLString::replicate(toCopy.fMsg, toCopy.fMemoryManager))
        , fMemoryManager(toCopy.fMemoryManager)
    {
    }

once XMemory() is declared as a base class, all warnings are gone.  I've seen 
this in 2.5.0 as well.  Below are the compiler flags that I have set which 
should help you recreate this bug:

-g3 -I.  -I./include   -isystem ./libs/crystalize/Linux/include     -I.  -
I./include   -isystem ./libs/crystalize/Linux/include -D__linux__ -D__x86__ -
DOMNI -DOMNI_VERSION="4" -I./idl -D_REENTRANT -I./libs/Database  -
I./libs/Database/libs/xerces/Linux/include -isystem ./libs/sybase/sybase-
12.5.1/Linux/include     -I./libs/xerces/Linux/include -Wall -W -pedantic -Wno-
long-long -Wpointer-arith -Wcast-qual -Wwrite-strings -Wconversion -Wstrict-
prototypes -Wmissing-prototypes -Woverloaded-virtual -Wchar-subscripts -
Wparentheses -Wpointer-arith -Winline -Wnon-virtual-dtor -Wreorder -fno-gnu-
keywords -Wctor-dtor-privacy -Wno-format-y2k -Wdeprecated -Wformat -Wmultichar -
Wno-float-equal -Wdisabled-optimization -Wswitch -Wpointer-arith -pipe -Wno-
cast-qual -Wno-unused-parameter -Wno-overloaded-virtual -fsigned-char -fmessage-
length=0 -DSIZE_MAX=4294967295U -DCORBA_ENUMS  -D_FILE_OFFSET_BITS=64 -
D__linux__ -D__x86__ -DOMNI -DOMNI_VERSION="4" -I./idl -D_REENTRANT -
I./libs/utilities/include -I./libs/AST_Common -I./libs/AST_Common/AST/enums -
I./libs/Database -I./libs/Database/libs/boost/Linux -
I./libs/Database/libs/omni/Linux/include -I./libs/Database/libs/sybase/sybase-
12.5.1/Linux/include -I./libs/Database/libs/xerces/Linux/include -
isystem ./libs/sybase/sybase-12.5.1/Linux/include -
I./libs/xerces/Linux/include -Wall -W -pedantic -Wno-long-long -Wpointer-arith -
Wcast-qual -Wwrite-strings -Wconversion -Wstrict-prototypes -Wmissing-
prototypes -Woverloaded-virtual -Wchar-subscripts -Wparentheses -Wpointer-
arith -Winline -Wnon-virtual-dtor -Wreorder -fno-gnu-keywords -Wctor-dtor-
privacy -Wno-format-y2k -Wdeprecated -Wformat -Wmultichar -Wno-float-equal -
Wdisabled-optimization -Wswitch -Wpointer-arith -pipe -Wno-cast-qual -Wno-
unused-parameter -Wno-overloaded-virtual -fsigned-char -fmessage-length=0 -
DSIZE_MAX=4294967295U -DCORBA_ENUMS  -D_FILE_OFFSET_BITS=64

Let me know if you need more information.  Thank you.

-Vrajesh


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org