You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/07/19 15:03:15 UTC
[commons-net] branch master updated (5dd8f927 -> 4213170b)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
from 5dd8f927 Bulletproof bills
new ae1dad6c Add @Override
new 4123523f Remove private method
new 4213170b Typos
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/main/java/org/apache/commons/net/DatagramSocketClient.java | 1 +
src/test/java/org/apache/commons/net/tftp/TFTPServer.java | 8 +++++---
2 files changed, 6 insertions(+), 3 deletions(-)
[commons-net] 01/03: Add @Override
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit ae1dad6ca58648670ddc37e33adc398b2d270557
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Jul 19 10:55:18 2023 -0400
Add @Override
---
src/main/java/org/apache/commons/net/DatagramSocketClient.java | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/main/java/org/apache/commons/net/DatagramSocketClient.java b/src/main/java/org/apache/commons/net/DatagramSocketClient.java
index cc90e145..5df2cb1c 100644
--- a/src/main/java/org/apache/commons/net/DatagramSocketClient.java
+++ b/src/main/java/org/apache/commons/net/DatagramSocketClient.java
@@ -83,6 +83,7 @@ public abstract class DatagramSocketClient implements AutoCloseable {
* Closes the DatagramSocket used for the connection. You should call this method after you've finished using the class instance and also before you call
* {@link #open open() } again. _isOpen_ is set to false and _socket_ is set to null.
*/
+ @Override
public void close() {
if (_socket_ != null) {
_socket_.close();
[commons-net] 02/03: Remove private method
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit 4123523f3e69e610d32633076a96e23005ce6ab8
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Jul 19 11:00:22 2023 -0400
Remove private method
---
src/test/java/org/apache/commons/net/tftp/TFTPServer.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/test/java/org/apache/commons/net/tftp/TFTPServer.java b/src/test/java/org/apache/commons/net/tftp/TFTPServer.java
index f5303730..d7847920 100644
--- a/src/test/java/org/apache/commons/net/tftp/TFTPServer.java
+++ b/src/test/java/org/apache/commons/net/tftp/TFTPServer.java
@@ -579,7 +579,9 @@ public class TFTPServer implements Runnable, AutoCloseable {
}
/**
- * Closes the tftp server (and any currently running transfers) and release all opened network resources.
+ * Closes the TFTP server (and any currently running transfers) and release all opened network resources.
+ *
+ * @since 3.10.0
*/
@Override
public void close() {
[commons-net] 03/03: Typos
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit 4213170b2916cc4471cc47822e6afba328f48519
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Jul 19 11:02:56 2023 -0400
Typos
---
src/test/java/org/apache/commons/net/tftp/TFTPServer.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/test/java/org/apache/commons/net/tftp/TFTPServer.java b/src/test/java/org/apache/commons/net/tftp/TFTPServer.java
index d7847920..6aefe01f 100644
--- a/src/test/java/org/apache/commons/net/tftp/TFTPServer.java
+++ b/src/test/java/org/apache/commons/net/tftp/TFTPServer.java
@@ -38,7 +38,7 @@ import org.apache.commons.net.io.FromNetASCIIOutputStream;
import org.apache.commons.net.io.ToNetASCIIInputStream;
/**
- * A fully multi-threaded tftp server. Can handle multiple clients at the same time. Implements RFC 1350 and wrapping block numbers for large file support.
+ * A fully multi-threaded TFTP server. Can handle multiple clients at the same time. Implements RFC 1350 and wrapping block numbers for large file support.
*
* To launch, just create an instance of the class. An IOException will be thrown if the server fails to start for reasons such as port in use, port denied,
* etc.
@@ -250,7 +250,7 @@ public class TFTPServer implements Runnable, AutoCloseable {
}
/*
- * handle a tftp write request.
+ * handle a TFTP write request.
*/
private void handleWrite(final TFTPWriteRequestPacket twrp) throws IOException, TFTPPacketException {
OutputStream bos = null;