You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/01/16 02:16:18 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
lkishalmi opened a new pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875
The Options Panel:
The default colors:
Norway Today:
FlatLaf Dark:
Well these are the colors I could came up with, I guess they could be improved by someone more artistic than me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #1875: [NETBEANS-3700] No
more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367205572
##########
File path: ide/defaults/src/org/netbeans/modules/defaults/BlueTheme-editor.xml
##########
@@ -62,4 +62,9 @@
<fontcolor name="LastOperation" bgColor="6f9f5a"/>
<fontcolor name="StepOutOperation" bgColor="2D6035"/>
+ <fontcolor name="nbcoverage-covered" bgColor="0F4F40"/>
+ <fontcolor name="nbcoverage-uncovered" bgColor="4F0F40"/>
+ <fontcolor name="nbcoverage-inferred" bgColor="1F4F40"/>
+ <fontcolor name="nbcoverage-partial" bgColor="909040"/>
Review comment:
Why "nbcoverage"? Perhaps just "coverage"? (Everything in NetBeans is NetBeans...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367212250
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml
##########
@@ -49,4 +49,8 @@
<fontcolor name="text-limit-line-color" foreColor="ff555555"/>
<fontcolor name="trailing-whitespace"/>
<fontcolor name="west-sidebars-color"/>
+ <fontcolor name="coverage-covered" bgColor="005000"/>
+ <fontcolor name="coverage-uncovered" bgColor="404040"/>
+ <fontcolor name="coverage-inferred" bgColor="1c501c"/>
Review comment:
OK, they seem to be really close in the existing defaults as well. Maybe they're supposed to look the same...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367207379
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml
##########
@@ -49,4 +49,8 @@
<fontcolor name="text-limit-line-color" foreColor="ff555555"/>
<fontcolor name="trailing-whitespace"/>
<fontcolor name="west-sidebars-color"/>
+ <fontcolor name="coverage-covered" bgColor="005000"/>
+ <fontcolor name="coverage-uncovered" bgColor="404040"/>
+ <fontcolor name="coverage-inferred" bgColor="1c501c"/>
Review comment:
What does "inferred" mean? This green color is almost identical to that of nbcoverage-covered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1875: [NETBEANS-3700] No
more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#issuecomment-574962376
Can't figure out how to change my review to "Approve" (github might get confused by force pushes), but feel free to merge...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367207053
##########
File path: ide/defaults/src/org/netbeans/modules/defaults/BlueTheme-editor.xml
##########
@@ -62,4 +62,9 @@
<fontcolor name="LastOperation" bgColor="6f9f5a"/>
<fontcolor name="StepOutOperation" bgColor="2D6035"/>
+ <fontcolor name="nbcoverage-covered" bgColor="0F4F40"/>
+ <fontcolor name="nbcoverage-uncovered" bgColor="4F0F40"/>
+ <fontcolor name="nbcoverage-inferred" bgColor="1F4F40"/>
+ <fontcolor name="nbcoverage-partial" bgColor="909040"/>
Review comment:
Let it be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367212250
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml
##########
@@ -49,4 +49,8 @@
<fontcolor name="text-limit-line-color" foreColor="ff555555"/>
<fontcolor name="trailing-whitespace"/>
<fontcolor name="west-sidebars-color"/>
+ <fontcolor name="coverage-covered" bgColor="005000"/>
+ <fontcolor name="coverage-uncovered" bgColor="404040"/>
+ <fontcolor name="coverage-inferred" bgColor="1c501c"/>
Review comment:
OK, they seem to be really close in the existing defaults as well. Maybe they're supposed to look the same... (nevermind this comment, I was looking at the BlueTheme)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on issue #1875: [NETBEANS-3700] No
more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#issuecomment-574957856
You are right the original defaults are reddish. I kept them for the original theme. The not to be that red is just my own opinion on the topic. For me red means bad. For me if something is not covered it is not bad, just not covered. Though I completely understand the other viewpoint as you turned on the code coverage for a reason...
That's it. If you propose to stick with some reds, then please suggest some colors for the blue and darklaf theme, I'm going to include those.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367210829
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml
##########
@@ -49,4 +49,8 @@
<fontcolor name="text-limit-line-color" foreColor="ff555555"/>
<fontcolor name="trailing-whitespace"/>
<fontcolor name="west-sidebars-color"/>
+ <fontcolor name="coverage-covered" bgColor="005000"/>
+ <fontcolor name="coverage-uncovered" bgColor="404040"/>
Review comment:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367207918
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml
##########
@@ -49,4 +49,8 @@
<fontcolor name="text-limit-line-color" foreColor="ff555555"/>
<fontcolor name="trailing-whitespace"/>
<fontcolor name="west-sidebars-color"/>
+ <fontcolor name="coverage-covered" bgColor="005000"/>
+ <fontcolor name="coverage-uncovered" bgColor="404040"/>
Review comment:
This one is a neutral grey, but it should be some variant of red. Perhaps try 813438 instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367213204
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml
##########
@@ -49,4 +49,8 @@
<fontcolor name="text-limit-line-color" foreColor="ff555555"/>
<fontcolor name="trailing-whitespace"/>
<fontcolor name="west-sidebars-color"/>
+ <fontcolor name="coverage-covered" bgColor="005000"/>
+ <fontcolor name="coverage-uncovered" bgColor="404040"/>
+ <fontcolor name="coverage-inferred" bgColor="1c501c"/>
Review comment:
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1875: [NETBEANS-3700] No
more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#issuecomment-574954562
Actually, one possible objection to the colors... shouldn't the "uncovered" color be red-ish, like in the light theme? Right now it's neutral grey, which does not communicate the same concept.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367207379
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml
##########
@@ -49,4 +49,8 @@
<fontcolor name="text-limit-line-color" foreColor="ff555555"/>
<fontcolor name="trailing-whitespace"/>
<fontcolor name="west-sidebars-color"/>
+ <fontcolor name="coverage-covered" bgColor="005000"/>
+ <fontcolor name="coverage-uncovered" bgColor="404040"/>
+ <fontcolor name="coverage-inferred" bgColor="1c501c"/>
Review comment:
What does "inferred" mean? This green color is almost identical to that of nbcoverage-covered. It should be some distinct color.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1875: [NETBEANS-3700] No
more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#issuecomment-574962625
(Oh, I assumed the BlueTheme was the existing one, so I didn't review the colors for that one.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367209353
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml
##########
@@ -49,4 +49,8 @@
<fontcolor name="text-limit-line-color" foreColor="ff555555"/>
<fontcolor name="trailing-whitespace"/>
<fontcolor name="west-sidebars-color"/>
+ <fontcolor name="coverage-covered" bgColor="005000"/>
+ <fontcolor name="coverage-uncovered" bgColor="404040"/>
+ <fontcolor name="coverage-inferred" bgColor="1c501c"/>
Review comment:
Well, that's a good question. Tried to look it up on jacoco, found nothing. Maybe did not try hard enough. I have not seen any sample where it is came up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367211513
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml
##########
@@ -49,4 +49,8 @@
<fontcolor name="text-limit-line-color" foreColor="ff555555"/>
<fontcolor name="trailing-whitespace"/>
<fontcolor name="west-sidebars-color"/>
+ <fontcolor name="coverage-covered" bgColor="005000"/>
+ <fontcolor name="coverage-uncovered" bgColor="404040"/>
Review comment:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367213008
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml
##########
@@ -49,4 +49,8 @@
<fontcolor name="text-limit-line-color" foreColor="ff555555"/>
<fontcolor name="trailing-whitespace"/>
<fontcolor name="west-sidebars-color"/>
+ <fontcolor name="coverage-covered" bgColor="005000"/>
+ <fontcolor name="coverage-uncovered" bgColor="404040"/>
+ <fontcolor name="coverage-inferred" bgColor="1c501c"/>
Review comment:
Honestly I do not know. I'd leave it for the "community test-pad" If someone find an incurred and the coloring disturbed, let's change it until then, it is Ok. Unless I find an incurred line first...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367210889
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml
##########
@@ -49,4 +49,8 @@
<fontcolor name="text-limit-line-color" foreColor="ff555555"/>
<fontcolor name="trailing-whitespace"/>
<fontcolor name="west-sidebars-color"/>
+ <fontcolor name="coverage-covered" bgColor="005000"/>
+ <fontcolor name="coverage-uncovered" bgColor="404040"/>
Review comment:
Not bad after all. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1875: [NETBEANS-3700] No
more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#issuecomment-574955137
Hold on, let me test the colors in photoshop...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on a change in pull request #1875:
[NETBEANS-3700] No more harcoding for Code Coverage Highlights.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
URL: https://github.com/apache/netbeans/pull/1875#discussion_r367210829
##########
File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml
##########
@@ -49,4 +49,8 @@
<fontcolor name="text-limit-line-color" foreColor="ff555555"/>
<fontcolor name="trailing-whitespace"/>
<fontcolor name="west-sidebars-color"/>
+ <fontcolor name="coverage-covered" bgColor="005000"/>
+ <fontcolor name="coverage-uncovered" bgColor="404040"/>
Review comment:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists