You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Hiroaki Yutani (JIRA)" <ji...@apache.org> on 2018/12/26 02:16:00 UTC
[jira] [Comment Edited] (ARROW-4113) [R] Version number patch broke
build
[ https://issues.apache.org/jira/browse/ARROW-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728608#comment-16728608 ]
Hiroaki Yutani edited comment on ARROW-4113 at 12/26/18 2:15 AM:
-----------------------------------------------------------------
{quote}Is "0.12.0-0" smaller than "0.12.0"?
{quote}
No (I didn't know this until now...).
{code:java}
package_version("0.12.0-0") == package_version("0.12.0")
#> [1] TRUE{code}
One common practice is to add .9000 to the tail of the current released version to represent "development version." So, in this case, the version would be 0.11.0.9000.
c.f. [http://r-pkgs.had.co.nz/description.html#version]
I guess you want to include "0.12.0" in the version string to indicate it's the development version of "0.12.0." But, as far as I know, R has no nice way to do that. Some possible choices are here:
# use "0.11.0.9000" for development, and "0.12.0" for release
# use "0.12.0" both for development and release (c.f. Apache Spark's SparkR uses this strategy: [https://github.com/apache/spark/commit/9bf397c0e45cb161f3f12f09bd2bf14ff96dc823#diff-06e745873945c43e0e5cf512efa992e9R3])
# use "0.12.0-0" for development, and "0.12.0-1" for release (c.f [rstan|https://cran.r-project.org/src/contrib/Archive/rstan/]'s patch version is 1-origin)
was (Author: yutannihilation):
{quote}Is "0.12.0-0" smaller than "0.12.0"?
{quote}
No (I didn't know this until now...).
{code}
package_version("0.12.0-0") == package_version("0.12.0")
#> [1] TRUE{code}
One common practice is to add .9000 to the tail of the current released version to represent "development version." So, in this case, the version would be 0.11.0.9000.
c.f. [http://r-pkgs.had.co.nz/description.html#version]
I guess you want to include "0.12.0" in the version string to indicate it's the development version of "0.12.0." But, as far as I know, R has no nice way to do that. Some possible choices are here:
# use "0.11.0.9000" for development, and "0.12.0" for release
# use "0.12.0" both for development and release
# use "0.12.0-0" for development, and "0.12.0-1" for release (c.f [rstan|https://cran.r-project.org/src/contrib/Archive/rstan/]'s patch version is 1-origin)
> [R] Version number patch broke build
> ------------------------------------
>
> Key: ARROW-4113
> URL: https://issues.apache.org/jira/browse/ARROW-4113
> Project: Apache Arrow
> Issue Type: Bug
> Components: R
> Reporter: Wes McKinney
> Priority: Major
> Fix For: 0.12.0
>
>
> The patch https://github.com/apache/arrow/commit/385c4384eb0dcc384b443f24765c64e9d6d88d28 broke the R build (which is in allowed_failures right now)
> {code}
> Building with: R CMD build
> 0.22s$ R CMD build .
> * checking for file ‘./DESCRIPTION’ ... OK
> * preparing ‘arrow’:
> * checking DESCRIPTION meta-information ... ERROR
> Malformed package version.
> See section 'The DESCRIPTION file' in the 'Writing R Extensions'
> manual.
> The command "R CMD build ." failed and exited with 1 during .
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)