[GitHub] [hive] shezhiming commented on pull request #2433: HIVE-25292 : to_unix_timestamp & unix_timestamp should support ENGLIS…

[GitBox <gi...@apache.org>]

shezhiming commented on pull request #2433:
URL: https://github.com/apache/hive/pull/2433#issuecomment-992432397


   @kgyrtkirk 
   
   My initial thoughts were the same as you, but in this way you need to create two DateTimeFormatters, and it seems that you can only use try{} catch{} to control the code logic (or is there a better way ?), which is not very elegant.
   
   Another reason is that I found in Apache Spark that spark to_unix_timestamp udf uses US Local to format the time by default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org