[GitHub] [drill] vdiravka commented on a change in pull request #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata

[GitBox <gi...@apache.org>]

vdiravka commented on a change in pull request #1723: DRILL-7063: Seperate metadata cache file into summary, file metadata
URL: https://github.com/apache/drill/pull/1723#discussion_r270729791
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/RefreshMetadataHandler.java
 ##########
 @@ -161,7 +161,7 @@ public PhysicalPlan getPlan(SqlNode sqlNode) throws ForemanSetupException {
    */
   private SqlNodeList getColumnList(final SqlRefreshMetadata sqlrefreshMetadata) {
     SqlNodeList columnList = sqlrefreshMetadata.getFieldList();
-    if (columnList == null || !SqlNodeList.isEmptyList(columnList)) {
 
 Review comment:
   `SqlNodeList.isEmptyList(node)` checks `node instanceof SqlNodeList`, therefore no need to check `columnList == null` explicitly. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services