You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/08/18 18:18:28 UTC
[GitHub] [pinot] klsince opened a new pull request, #9242: refine query cancel resp msg
klsince opened a new pull request, #9242:
URL: https://github.com/apache/pinot/pull/9242
This PR mainly refines the query cancel resp msg, by defining some explicit query cancel error code and msg, instead of bubbling up the Executor's CancellationException.
Also moves the query tracking mechanism for query cancellation from QueryScheduler to InstanceRequestHandler to be less likely to be overwritten by subclasses, and be more consistent with the logic in BaseBrokerRequestHandler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #9242: refine query cancel resp msg
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #9242:
URL: https://github.com/apache/pinot/pull/9242#issuecomment-1220088805
# [Codecov](https://codecov.io/gh/apache/pinot/pull/9242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9242](https://codecov.io/gh/apache/pinot/pull/9242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e24edf6) into [master](https://codecov.io/gh/apache/pinot/commit/3a655d2d0e86cf208a1d84e4d7c776fa093dbb2a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a655d2) will **decrease** coverage by `1.25%`.
> The diff coverage is `54.25%`.
```diff
@@ Coverage Diff @@
## master #9242 +/- ##
============================================
- Coverage 70.01% 68.75% -1.26%
- Complexity 4762 5002 +240
============================================
Files 1857 1859 +2
Lines 99136 99221 +85
Branches 15076 15094 +18
============================================
- Hits 69406 68222 -1184
- Misses 24833 26103 +1270
+ Partials 4897 4896 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `26.25% <29.78%> (-0.13%)` | :arrow_down: |
| integration2 | `?` | |
| unittests1 | `67.12% <53.16%> (+0.04%)` | :arrow_up: |
| unittests2 | `15.39% <0.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/9242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...not/core/operator/combine/BaseCombineOperator.java](https://codecov.io/gh/apache/pinot/pull/9242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9jb21iaW5lL0Jhc2VDb21iaW5lT3BlcmF0b3IuamF2YQ==) | `84.61% <0.00%> (-3.39%)` | :arrow_down: |
| [...va/org/apache/pinot/core/plan/CombinePlanNode.java](https://codecov.io/gh/apache/pinot/pull/9242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL0NvbWJpbmVQbGFuTm9kZS5qYXZh) | `80.64% <0.00%> (-7.50%)` | :arrow_down: |
| [...che/pinot/core/query/scheduler/QueryScheduler.java](https://codecov.io/gh/apache/pinot/pull/9242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zY2hlZHVsZXIvUXVlcnlTY2hlZHVsZXIuamF2YQ==) | `84.56% <ø> (+2.69%)` | :arrow_up: |
| [...ache/pinot/server/api/resources/QueryResource.java](https://codecov.io/gh/apache/pinot/pull/9242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvYXBpL3Jlc291cmNlcy9RdWVyeVJlc291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/pinot/spi/exception/QueryCancelledException.java](https://codecov.io/gh/apache/pinot/pull/9242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZXhjZXB0aW9uL1F1ZXJ5Q2FuY2VsbGVkRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/pinot/spi/utils/CommonConstants.java](https://codecov.io/gh/apache/pinot/pull/9242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `27.69% <ø> (ø)` | |
| [...core/query/executor/ServerQueryExecutorV1Impl.java](https://codecov.io/gh/apache/pinot/pull/9242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9leGVjdXRvci9TZXJ2ZXJRdWVyeUV4ZWN1dG9yVjFJbXBsLmphdmE=) | `79.94% <42.85%> (-3.04%)` | :arrow_down: |
| [...rg/apache/pinot/server/starter/ServerInstance.java](https://codecov.io/gh/apache/pinot/pull/9242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9TZXJ2ZXJJbnN0YW5jZS5qYXZh) | `73.38% <53.84%> (-13.09%)` | :arrow_down: |
| [...e/pinot/core/transport/InstanceRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/9242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvSW5zdGFuY2VSZXF1ZXN0SGFuZGxlci5qYXZh) | `66.14% <64.15%> (+6.38%)` | :arrow_up: |
| [.../apache/pinot/common/exception/QueryException.java](https://codecov.io/gh/apache/pinot/pull/9242/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL1F1ZXJ5RXhjZXB0aW9uLmphdmE=) | `94.31% <100.00%> (+0.13%)` | :arrow_up: |
| ... and [166 more](https://codecov.io/gh/apache/pinot/pull/9242/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince commented on a diff in pull request #9242: refine query cancel resp msg
Posted by GitBox <gi...@apache.org>.
klsince commented on code in PR #9242:
URL: https://github.com/apache/pinot/pull/9242#discussion_r950618560
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java:
##########
@@ -118,6 +119,9 @@ public void runJob() {
IntermediateResultsBlock mergedBlock;
try {
mergedBlock = mergeResults();
+ } catch (InterruptedException ie) {
+ Thread.currentThread().interrupt();
Review Comment:
can do, if we're sure the interrupt status is not needed by following logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9242: refine query cancel resp msg
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on code in PR #9242:
URL: https://github.com/apache/pinot/pull/9242#discussion_r950611815
##########
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java:
##########
@@ -53,6 +53,7 @@ public static void setMaxLinesOfStackTrace(int maxLinesOfStackTracePerFrame) {
public static final int ACCESS_DENIED_ERROR_CODE = 180;
public static final int TABLE_DOES_NOT_EXIST_ERROR_CODE = 190;
public static final int QUERY_EXECUTION_ERROR_CODE = 200;
+ public static final int QUERY_CANCELLATION_ERROR_CODE = 210;
Review Comment:
Let's put `205` because here as `210` is already taken
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java:
##########
@@ -118,6 +119,9 @@ public void runJob() {
IntermediateResultsBlock mergedBlock;
try {
mergedBlock = mergeResults();
+ } catch (InterruptedException ie) {
+ Thread.currentThread().interrupt();
Review Comment:
We don't want to interrupt the thread again since the interrupt is already handled. Same for other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince commented on a diff in pull request #9242: refine query cancel resp msg
Posted by GitBox <gi...@apache.org>.
klsince commented on code in PR #9242:
URL: https://github.com/apache/pinot/pull/9242#discussion_r951965006
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java:
##########
@@ -154,10 +200,23 @@ public void onSuccess(@Nullable byte[] responseBytes) {
@Override
public void onFailure(Throwable t) {
+ if (_enableQueryCancellation) {
+ String queryId = queryRequest.getQueryId();
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Remove track of running query: {} on failure", queryId);
+ }
+ _queryFuturesById.remove(queryId);
+ }
// Send exception response.
- LOGGER.error("Exception while processing instance request", t);
+ Exception ex = new Exception(t);
+ if (t instanceof CancellationException) {
+ LOGGER.info("Query: {} got cancelled", queryRequest.getQueryId());
+ ex = (Exception) t;
+ } else {
+ LOGGER.error("Exception while processing instance request", t);
+ }
Review Comment:
yeah, should have been so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9242: refine query cancel resp msg
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on code in PR #9242:
URL: https://github.com/apache/pinot/pull/9242#discussion_r951885658
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java:
##########
@@ -118,6 +119,8 @@ public void runJob() {
IntermediateResultsBlock mergedBlock;
try {
mergedBlock = mergeResults();
+ } catch (InterruptedException ie) {
+ throw new QueryCancelledException("Cancelled while merging results blocks", ie);
Review Comment:
(minor) Consider not including the `InterruptedException` for cleaner response
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/SelectionOrderByCombineOperator.java:
##########
@@ -76,8 +77,10 @@ protected IntermediateResultsBlock getNextBlock() {
assert orderByExpressions != null;
if (orderByExpressions.get(0).getExpression().getType() == ExpressionContext.Type.IDENTIFIER) {
try {
- return new MinMaxValueBasedSelectionOrderByCombineOperator(_operators, _queryContext,
- _executorService).getNextBlock();
+ return new MinMaxValueBasedSelectionOrderByCombineOperator(_operators, _queryContext, _executorService)
+ .getNextBlock();
+ } catch (QueryCancelledException e) {
+ throw new QueryCancelledException("Cancelled while running MinMaxValueBasedSelectionOrderByCombineOperator", e);
Review Comment:
(minor) We can simply throw it out because the stack trace should have the original class info
```suggestion
throw e;
```
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##########
@@ -154,6 +155,8 @@ public List<Operator> callJob() {
Throwable cause = e.getCause();
if (cause instanceof BadQueryRequestException) {
throw (BadQueryRequestException) cause;
+ } else if (e instanceof InterruptedException) {
+ throw new QueryCancelledException("Cancelled while running CombinePlanNode", e);
Review Comment:
(minor) Consider not including the `InterruptedException`
##########
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##########
@@ -102,11 +94,6 @@ public QueryScheduler(PinotConfiguration config, QueryExecutor queryExecutor, Re
_numDroppedLogRateLimiter = RateLimiter.create(1.0d);
_numDroppedLogCounter = new AtomicInteger(0);
LOGGER.info("Query log max rate: {}", _queryLogRateLimiter.getRate());
-
- _enableQueryCancellation = Boolean.parseBoolean(config.getProperty(ENABLE_QUERY_CANCELLATION_KEY));
Review Comment:
(minor) Remove this constant
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java:
##########
@@ -172,22 +231,62 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
new Exception(message, cause));
}
+ /**
+ * Cancel a query as identified by the queryId. This method is non-blocking and the query may still run for a while
+ * after calling this method. This method can be called multiple times.
+ *
+ * @param queryId a unique Id to find the query
+ * @return true if a running query exists for the given queryId.
+ */
+ public boolean cancelQuery(String queryId) {
+ Preconditions.checkArgument(_enableQueryCancellation, "Query cancellation is not enabled on server");
Review Comment:
(minor) This should be `checkState`, same for other checks
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java:
##########
@@ -154,10 +200,23 @@ public void onSuccess(@Nullable byte[] responseBytes) {
@Override
public void onFailure(Throwable t) {
+ if (_enableQueryCancellation) {
+ String queryId = queryRequest.getQueryId();
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Remove track of running query: {} on failure", queryId);
+ }
+ _queryFuturesById.remove(queryId);
+ }
// Send exception response.
- LOGGER.error("Exception while processing instance request", t);
+ Exception ex = new Exception(t);
+ if (t instanceof CancellationException) {
+ LOGGER.info("Query: {} got cancelled", queryRequest.getQueryId());
+ ex = (Exception) t;
+ } else {
+ LOGGER.error("Exception while processing instance request", t);
+ }
Review Comment:
Not introduced in this PR, but suggest avoid wrapping exceptions
```suggestion
Exception e;
if (t instanceof Exception) {
e = (Exception) t;
if (e instanceof CancellationException) {
LOGGER.info("Query: {} got cancelled", queryRequest.getQueryId());
} else {
LOGGER.error("Exception while processing instance request", e);
}
} else {
LOGGER.error("Error while processing instance request", t);
e = new Exception(t);
}
```
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java:
##########
@@ -54,19 +65,24 @@
* The {@code InstanceRequestHandler} is the Netty inbound handler on Pinot Server side to handle the serialized
* instance requests sent from Pinot Broker.
*/
+@ChannelHandler.Sharable
public class InstanceRequestHandler extends SimpleChannelInboundHandler<ByteBuf> {
private static final Logger LOGGER = LoggerFactory.getLogger(InstanceRequestHandler.class);
// TODO: make it configurable
private static final int SLOW_QUERY_LATENCY_THRESHOLD_MS = 100;
+ private final String _instanceName;
private final TDeserializer _deserializer;
private final QueryScheduler _queryScheduler;
private final ServerMetrics _serverMetrics;
private final AccessControl _accessControl;
+ private final boolean _enableQueryCancellation;
+ private final Map<String, Future<byte[]>> _queryFuturesById = new ConcurrentHashMap<>();
Review Comment:
When query cancellation is not enabled, let's set it to `null` to avoid the unused garbage.
(Optional) We may also use whether it is `null` to identify whether query cancellation is enabled, this should have slightly better performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince commented on a diff in pull request #9242: refine query cancel resp msg
Posted by GitBox <gi...@apache.org>.
klsince commented on code in PR #9242:
URL: https://github.com/apache/pinot/pull/9242#discussion_r951964480
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java:
##########
@@ -54,19 +65,24 @@
* The {@code InstanceRequestHandler} is the Netty inbound handler on Pinot Server side to handle the serialized
* instance requests sent from Pinot Broker.
*/
+@ChannelHandler.Sharable
public class InstanceRequestHandler extends SimpleChannelInboundHandler<ByteBuf> {
private static final Logger LOGGER = LoggerFactory.getLogger(InstanceRequestHandler.class);
// TODO: make it configurable
private static final int SLOW_QUERY_LATENCY_THRESHOLD_MS = 100;
+ private final String _instanceName;
private final TDeserializer _deserializer;
private final QueryScheduler _queryScheduler;
private final ServerMetrics _serverMetrics;
private final AccessControl _accessControl;
+ private final boolean _enableQueryCancellation;
+ private final Map<String, Future<byte[]>> _queryFuturesById = new ConcurrentHashMap<>();
Review Comment:
sgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince commented on a diff in pull request #9242: refine query cancel resp msg
Posted by GitBox <gi...@apache.org>.
klsince commented on code in PR #9242:
URL: https://github.com/apache/pinot/pull/9242#discussion_r951961519
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java:
##########
@@ -118,6 +119,8 @@ public void runJob() {
IntermediateResultsBlock mergedBlock;
try {
mergedBlock = mergeResults();
+ } catch (InterruptedException ie) {
+ throw new QueryCancelledException("Cancelled while merging results blocks", ie);
Review Comment:
The `e.getMessage()` is called to compose an info log so the stack trace won't be printed out. The cancel resp msg is composed separately w/o the stack trace at all. I was adding a DEBUG log level to print the full stack trace as needed but missed in the PR. Will add that DEBUG log back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince commented on a diff in pull request #9242: refine query cancel resp msg
Posted by GitBox <gi...@apache.org>.
klsince commented on code in PR #9242:
URL: https://github.com/apache/pinot/pull/9242#discussion_r950618452
##########
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java:
##########
@@ -53,6 +53,7 @@ public static void setMaxLinesOfStackTrace(int maxLinesOfStackTracePerFrame) {
public static final int ACCESS_DENIED_ERROR_CODE = 180;
public static final int TABLE_DOES_NOT_EXIST_ERROR_CODE = 190;
public static final int QUERY_EXECUTION_ERROR_CODE = 200;
+ public static final int QUERY_CANCELLATION_ERROR_CODE = 210;
Review Comment:
oh, good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #9242: refine query cancel resp msg
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged PR #9242:
URL: https://github.com/apache/pinot/pull/9242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org