You are viewing a plain text version of this content. The canonical link for it is here.

Posted to hdfs-issues@hadoop.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2013/10/08 18:10:44 UTC

[jira] [Updated] (HDFS-5323) Remove some deadcode in BlockManager

     [ https://issues.apache.org/jira/browse/HDFS-5323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Patrick McCabe updated HDFS-5323:
---------------------------------------

    Attachment: HDFS-5323.001.patch

> Remove some deadcode in BlockManager
> ------------------------------------
>
>                 Key: HDFS-5323
>                 URL: https://issues.apache.org/jira/browse/HDFS-5323
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.3.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-5323.001.patch
>
>
> {{BlockManager#DEFAULT_MAP_LOAD_FACTOR}} is deadcode.  It no longer does *anything* since blocks are now stored in a GSet whose size is fixed.
> {{BlocksMap#blocks}} does not need to be volatile.  Whenever it is accessed, it is accessed under the {{FSNamesystem}} lock.  Furthermore, access to this data structure is not thread-safe.



--
This message was sent by Atlassian JIRA
(v6.1#6144)