You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/12/08 08:43:51 UTC

[GitHub] [incubator-devlake] mindlesscloud commented on a diff in pull request #3886: feat: add time filter for github & github graphql; fix some bugs when running

mindlesscloud commented on code in PR #3886:
URL: https://github.com/apache/incubator-devlake/pull/3886#discussion_r1043069188


##########
plugins/helper/worker_scheduler.go:
##########
@@ -74,7 +74,7 @@ func NewWorkerScheduler(
 // SubmitBlocking enqueues a async task to ants, the task will be executed in future when timing is right.
 // It doesn't return error because it wouldn't be any when with a Blocking semantic, returned error does nothing but
 // causing confusion, more often, people thought it is returned by the task.
-// Since it is async task, the callframes would not be available for production mode, you can export Environment
+// CreatedDateAfter it is async task, the callframes would not be available for production mode, you can export Environment

Review Comment:
   This `since` should not be replaced



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org