You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2022/12/22 02:10:19 UTC

[GitHub] [kylin] hit-lacus commented on a diff in pull request #2048: Add mac troubleshooting content of how_to_write_doc

hit-lacus commented on code in PR #2048:
URL: https://github.com/apache/kylin/pull/2048#discussion_r1055017247


##########
website/docs/development/how_to_write_doc.md:
##########
@@ -163,19 +169,19 @@ npm run start
 ```
 
 :::info Check your doc
-- [ ] Whether the **look and feel** meet expectation?
-- [ ] Whether the **link/pictures** work fine?
+- [ ] Whether the **look and feel** meet expectations?
+- [ ] Whether the **links/pictures** work fine?
 - [ ] Whether the important info is properly **highlighted**? [How to highlight?](#highlight_paragraph)
 - [ ] Whether the **title levels** follow the [heading guide](#heading_level)?
 :::
 
 #### Step 5: Create a pull request
 
-When everything looks fine, create a pull request to the [kylin doc5.0 branch](https://github.com/apache/kylin/tree/doc5.0).
+When everything looks fine, create a pull request to the [Kylin doc5.0 branch](https://github.com/apache/kylin/tree/doc5.0).
 
 :::note What, Pull Request?
 For those who are new to pull requests, here it is explained.
-- How to geek -- [What are git pull requests](https://www.howtogeek.com/devops/what-are-git-pull-requests-and-how-do-you-use-them/)
+- How to geek -- [What is git pull requests](https://www.howtogeek.com/devops/what-are-git-pull-requests-and-how-do-you-use-them/)

Review Comment:
   maybe you should remove `s` from `requests`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org