You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2016/02/15 20:47:04 UTC
[1/2] logging-log4j2 git commit: Use LoaderUtil instead of
Class.forName().
Repository: logging-log4j2
Updated Branches:
refs/heads/master 4bfd57686 -> e1134a148
Use LoaderUtil instead of Class.forName().
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/009ad22c
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/009ad22c
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/009ad22c
Branch: refs/heads/master
Commit: 009ad22c34ba22f163247d2f41de68aae8c08fc1
Parents: 4bfd576
Author: Matt Sicker <bo...@gmail.com>
Authored: Mon Feb 15 13:42:06 2016 -0600
Committer: Matt Sicker <bo...@gmail.com>
Committed: Mon Feb 15 13:42:06 2016 -0600
----------------------------------------------------------------------
.../logging/log4j/core/config/ReliabilityStrategyFactory.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/009ad22c/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java
index 9d795dd..773f9f0 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java
@@ -18,6 +18,7 @@
package org.apache.logging.log4j.core.config;
import org.apache.logging.log4j.status.StatusLogger;
+import org.apache.logging.log4j.util.LoaderUtil;
import org.apache.logging.log4j.util.PropertiesUtil;
/**
@@ -58,7 +59,7 @@ public final class ReliabilityStrategyFactory {
}
try {
@SuppressWarnings("unchecked")
- Class<? extends ReliabilityStrategy> cls = (Class<? extends ReliabilityStrategy>) Class.forName(strategy);
+ Class<? extends ReliabilityStrategy> cls = (Class<? extends ReliabilityStrategy>) LoaderUtil.loadClass(strategy);
return cls.getConstructor(LoggerConfig.class).newInstance(loggerConfig);
} catch (Exception dynamicFailed) {
StatusLogger.getLogger().warn(
Re: [2/2] logging-log4j2 git commit: Use Class.asSubclass() to remove @SuppressWarnings.
Posted by Remko Popma <re...@gmail.com>.
Nice, thanks!
Sent from my iPhone
> On 2016/02/16, at 4:47, mattsicker@apache.org wrote:
>
> Use Class.asSubclass() to remove @SuppressWarnings.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e1134a14
> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e1134a14
> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e1134a14
>
> Branch: refs/heads/master
> Commit: e1134a148231681da566963fdfac35a528b88cd6
> Parents: 009ad22
> Author: Matt Sicker <bo...@gmail.com>
> Authored: Mon Feb 15 13:46:57 2016 -0600
> Committer: Matt Sicker <bo...@gmail.com>
> Committed: Mon Feb 15 13:46:57 2016 -0600
>
> ----------------------------------------------------------------------
> .../logging/log4j/core/config/ReliabilityStrategyFactory.java | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e1134a14/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java
> ----------------------------------------------------------------------
> diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java
> index 773f9f0..637341b 100644
> --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java
> +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java
> @@ -58,8 +58,8 @@ public final class ReliabilityStrategyFactory {
> return new LockingReliabilityStrategy(loggerConfig);
> }
> try {
> - @SuppressWarnings("unchecked")
> - Class<? extends ReliabilityStrategy> cls = (Class<? extends ReliabilityStrategy>) LoaderUtil.loadClass(strategy);
> + final Class<? extends ReliabilityStrategy> cls = LoaderUtil.loadClass(strategy).asSubclass(
> + ReliabilityStrategy.class);
> return cls.getConstructor(LoggerConfig.class).newInstance(loggerConfig);
> } catch (Exception dynamicFailed) {
> StatusLogger.getLogger().warn(
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
[2/2] logging-log4j2 git commit: Use Class.asSubclass() to remove
@SuppressWarnings.
Posted by ma...@apache.org.
Use Class.asSubclass() to remove @SuppressWarnings.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/e1134a14
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/e1134a14
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/e1134a14
Branch: refs/heads/master
Commit: e1134a148231681da566963fdfac35a528b88cd6
Parents: 009ad22
Author: Matt Sicker <bo...@gmail.com>
Authored: Mon Feb 15 13:46:57 2016 -0600
Committer: Matt Sicker <bo...@gmail.com>
Committed: Mon Feb 15 13:46:57 2016 -0600
----------------------------------------------------------------------
.../logging/log4j/core/config/ReliabilityStrategyFactory.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/e1134a14/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java
index 773f9f0..637341b 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/ReliabilityStrategyFactory.java
@@ -58,8 +58,8 @@ public final class ReliabilityStrategyFactory {
return new LockingReliabilityStrategy(loggerConfig);
}
try {
- @SuppressWarnings("unchecked")
- Class<? extends ReliabilityStrategy> cls = (Class<? extends ReliabilityStrategy>) LoaderUtil.loadClass(strategy);
+ final Class<? extends ReliabilityStrategy> cls = LoaderUtil.loadClass(strategy).asSubclass(
+ ReliabilityStrategy.class);
return cls.getConstructor(LoggerConfig.class).newInstance(loggerConfig);
} catch (Exception dynamicFailed) {
StatusLogger.getLogger().warn(