You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/14 14:22:06 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4316: Support DDL for Oracle visitor
terrymanu opened a new pull request #4316: Support DDL for Oracle visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4316
Fixes #4271.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4316:
Support DDL for Oracle visitor
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4316: Support DDL for Oracle visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4316
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4316: Support DDL for Oracle visitor
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4316: Support DDL for Oracle visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4316#issuecomment-586323013
## Pull Request Test Coverage Report for [Build 1740](https://coveralls.io/builds/28736949)
* **1** of **134** **(0.75%)** changed or added relevant lines in **3** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage decreased (**-0.4%**) to **60.876%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/visitor/ParseTreeVisitorFactory.java](https://coveralls.io/builds/28736949/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fvisitor%2FParseTreeVisitorFactory.java#L50) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDDLVisitor.java](https://coveralls.io/builds/28736949/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FOracleDDLVisitor.java#L72) | 0 | 132 | 0.0%
<!-- | **Total:** | **1** | **134** | **0.75%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDDLVisitor.java](https://coveralls.io/builds/28736949/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FOracleDDLVisitor.java#L68) | 1 | 0% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/28736949) |
| :-- | --: |
| Change from base [Build 859](https://coveralls.io/builds/28734710): | -0.4% |
| Covered Lines: | 11055 |
| Relevant Lines: | 18160 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4316:
Support DDL for Oracle visitor
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4316: Support DDL for Oracle visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4316#issuecomment-586318273
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4316?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@fbee477`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0.74%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4316?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4316 +/- ##
========================================
Coverage ? 57.2%
Complexity ? 352
========================================
Files ? 1027
Lines ? 18160
Branches ? 3284
========================================
Hits ? 10388
Misses ? 7117
Partials ? 655
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4316?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...here/sql/parser/visitor/impl/OracleDDLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4316/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW9yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL2ltcGwvT3JhY2xlRERMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...l/parser/core/visitor/ParseTreeVisitorFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4316/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3Zpc2l0b3IvUGFyc2VUcmVlVmlzaXRvckZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...phere/sql/parser/core/extractor/util/RuleName.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4316/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci91dGlsL1J1bGVOYW1lLmphdmE=) | `100% <100%> (ø)` | `0 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4316?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4316?src=pr&el=footer). Last update [fbee477...3872a7a](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4316?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4316:
Support DDL for Oracle visitor
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4316: Support DDL for Oracle visitor
URL: https://github.com/apache/incubator-shardingsphere/pull/4316#issuecomment-586323013
## Pull Request Test Coverage Report for [Build 9557](https://coveralls.io/builds/28736654)
* **1** of **134** **(0.75%)** changed or added relevant lines in **3** files are covered.
* **5** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.5%**) to **60.865%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/visitor/ParseTreeVisitorFactory.java](https://coveralls.io/builds/28736654/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fvisitor%2FParseTreeVisitorFactory.java#L50) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDDLVisitor.java](https://coveralls.io/builds/28736654/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FOracleDDLVisitor.java#L72) | 0 | 132 | 0.0%
<!-- | **Total:** | **1** | **134** | **0.75%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloInstance.java](https://coveralls.io/builds/28736654/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FApolloInstance.java#L118) | 1 | 61.11% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/OracleDDLVisitor.java](https://coveralls.io/builds/28736654/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FOracleDDLVisitor.java#L68) | 1 | 0% |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28736654/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
<!-- | **Total:** | **5** | | -->
| Totals | [](https://coveralls.io/builds/28736654) |
| :-- | --: |
| Change from base [Build 859](https://coveralls.io/builds/28734710): | -0.5% |
| Covered Lines: | 11053 |
| Relevant Lines: | 18160 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services