You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ap...@apache.org on 2023/06/19 14:07:56 UTC

[arrow] branch main updated: MINOR: [C++] Make clang-tidy stop complaining about C arrays (#36102)

This is an automated email from the ASF dual-hosted git repository.

apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new d55cfaa7e6 MINOR: [C++] Make clang-tidy stop complaining about C arrays (#36102)
d55cfaa7e6 is described below

commit d55cfaa7e659773d36fd1b7a36d8fbf7d7878b42
Author: Felipe Oliveira Carvalho <fe...@gmail.com>
AuthorDate: Mon Jun 19 11:07:47 2023 -0300

    MINOR: [C++] Make clang-tidy stop complaining about C arrays (#36102)
    
    ### Rationale for this change
    
    `std::array` is rarely a good fit for the kind of low-level array and buffer manipulation that Arrow does, so having `clang-tidy` complaining about C-style arrays confuses more than it helps.
    
    ### What changes are included in this PR?
    
    Change in `.clang-tidy`.
    
    ### Are these changes tested?
    
    I checked on my editor. Warnings not shown anymore.
    
    Authored-by: Felipe Oliveira Carvalho <fe...@gmail.com>
    Signed-off-by: Antoine Pitrou <an...@python.org>
---
 .clang-tidy | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.clang-tidy b/.clang-tidy
index 10800f4250..ebb75c859e 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -21,6 +21,7 @@ Checks: |
   -clang-analyzer-alpha*,
   google-*,
   modernize-*,
+  -modernize-avoid-c-arrays,
   -modernize-use-trailing-return-type,
   -modernize-use-nodiscard,
 # produce HeaderFilterRegex from cpp/build-support/lint_exclusions.txt with: