You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2014/07/24 14:30:30 UTC
[GitHub] incubator-brooklyn pull request: Updates jasmine-maven-plugin to v...
GitHub user sjcorbett opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/93
Updates jasmine-maven-plugin to version 1.3.1.5
We can finally run js tests in the browser by running `mvn jasmine:bdd` and visiting `localhost:8324`.
Will unblock #74 when merged.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/incubator-brooklyn jasmine-maven-plugin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/93.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #93
----
commit a8ec5da71a6fad60bc205028992072fde11e0a1d
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2014-07-24T10:42:01Z
Update jasmine-maven-plugin to 1.3.1.5
Run tests in the browser with `mvn jasmine:bdd'.
commit 8815f80194482b2514a9b8f9965b5e4523839576
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2014-07-24T12:18:53Z
jsgui: Speed two tests up by decreasing wait periods
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updates jasmine-maven-plugin to v...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/93#issuecomment-50046814
@richardcloudsoft Rebased and retested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updates jasmine-maven-plugin to v...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/93
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updates jasmine-maven-plugin to v...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/93#issuecomment-50022228
good to merge, tests are passing for me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updates jasmine-maven-plugin to v...
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/93#issuecomment-50046504
@sjcorbett can you rebase this please (there's now a merge conflict against master)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Updates jasmine-maven-plugin to v...
Posted by richardcloudsoft <gi...@git.apache.org>.
Github user richardcloudsoft commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/93#issuecomment-50047046
That was quick!! :smile: Committing now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---