You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/04/08 13:30:46 UTC
[GitHub] [accumulo] milleruntime opened a new issue, #2618: Rename property
milleruntime opened a new issue, #2618:
URL: https://github.com/apache/accumulo/issues/2618
The property name `general.server.simpletimer.threadpool.size` is old and doesn't really make sense anymore with the refactoring of ThreadPools class. I am wondering if we should rename it. Maybe something like `general.server.threadpool.size`. The `SimpleTimer` class has been dropped.
https://github.com/apache/accumulo/blob/12fde7ec38c485acefa162ec0dfb6a73919fd576/core/src/main/java/org/apache/accumulo/core/conf/Property.java#L246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii closed issue #2618: Rename property
Posted by GitBox <gi...@apache.org>.
ctubbsii closed issue #2618: Rename property
URL: https://github.com/apache/accumulo/issues/2618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] kitswas commented on issue #2618: Rename property
Posted by GitBox <gi...@apache.org>.
kitswas commented on issue #2618:
URL: https://github.com/apache/accumulo/issues/2618#issuecomment-1127740339
Is the name `"General"` alright?
In method [`createExecutorService`](https://github.com/apache/accumulo/blob/dd81d608bff88835676e756ffcb2a2f6b69c9be8/core/src/main/java/org/apache/accumulo/core/util/threads/ThreadPools.java#L262).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #2618: Rename property
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #2618:
URL: https://github.com/apache/accumulo/issues/2618#issuecomment-1127556638
> Just for clarification.
>
> Is the comment
> for the Experimental property `GENERAL_VOLUME_CHOOSER`?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] kitswas commented on issue #2618: Rename property
Posted by GitBox <gi...@apache.org>.
kitswas commented on issue #2618:
URL: https://github.com/apache/accumulo/issues/2618#issuecomment-1127297233
Just for clarification.
Is the comment
https://github.com/apache/accumulo/blob/12fde7ec38c485acefa162ec0dfb6a73919fd576/core/src/main/java/org/apache/accumulo/core/conf/Property.java#L249
for the Experimental property `GENERAL_VOLUME_CHOOSER`?
https://github.com/apache/accumulo/blob/12fde7ec38c485acefa162ec0dfb6a73919fd576/core/src/main/java/org/apache/accumulo/core/conf/Property.java#L252
The code suggests so, but the comment is a tad confusing([simply too relevant](https://github.com/apache/accumulo/issues/2618#issuecomment-1104368037)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Akshit6828 commented on issue #2618: Rename property
Posted by GitBox <gi...@apache.org>.
Akshit6828 commented on issue #2618:
URL: https://github.com/apache/accumulo/issues/2618#issuecomment-1104276239
Hi @milleruntime. As per my understanding, do we need to replace `GENERAL_SIMPLETIMER_THREADPOOL_SIZE("general.server.simpletimer.threadpool.size", "1", ` by `GENERAL_SIMPLETIMER_THREADPOOL_SIZE("general.server.threadpool.size", "1", `. as the SimpleTimer class has been dropped?
If yes, can i go with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] kitswas commented on issue #2618: Rename property
Posted by GitBox <gi...@apache.org>.
kitswas commented on issue #2618:
URL: https://github.com/apache/accumulo/issues/2618#issuecomment-1127562270
> It may be better (necessary?) to deprecate the current name with the replacement, but allow either to be used.
This is something I believe I can do. May I make an attempt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on issue #2618: Rename property
Posted by GitBox <gi...@apache.org>.
EdColeman commented on issue #2618:
URL: https://github.com/apache/accumulo/issues/2618#issuecomment-1104368037
This might be more than just a simple rename. There are considerations of current usages, how and where the name / value is used and the expected behavior of existing code that uses the current values.
For the original issue as stated, one possibility would be to would be to rename both the property enum name (GENERAL_SIMPLETIMER_THREADPOOL_SIZE) and the string value used as a key (general.server.simpletimer.threadpool.size) to something that reflects the current usage.
However, there are additional considerations:
It may be better (necessary?) to deprecate the current name with the replacement, but allow either to be used.
The change would need to replace the enum name in the code base and then any scripts that use the string value should also be modified. This should also be documented in the release notes so that users know the change occurred.
For current installations that may use the current name, it would be necessary to rename the property name (key) that is stored in ZooKeeper during the upgrade processing so that the "saved" value would be transformed and remain valid any code that has this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org