You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2019/05/03 17:35:24 UTC
[kafka] branch trunk updated: MINOR: Upgrade dependencies for Kafka
2.3 (#6665)
This is an automated email from the ASF dual-hosted git repository.
ijuma pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new a372824 MINOR: Upgrade dependencies for Kafka 2.3 (#6665)
a372824 is described below
commit a37282415e4e7f682b43abe78517ed18a8dea962
Author: Ismael Juma <is...@juma.me.uk>
AuthorDate: Fri May 3 10:35:07 2019 -0700
MINOR: Upgrade dependencies for Kafka 2.3 (#6665)
Many patch and minor updates.
Scalatest and Jetty deprecated classes that we
use. I removed usages for the former and filed KAFKA-8316 for the latter (I
suppressed the relevant deprecation warnings until the JIRA is fixed). As
part of the scalatest fixes, I also removed `TestUtils.fail` since it duplicates
`Assertions.fail`.
I also fixed a few compiler warnings that have crept in since my last sweep.
Updates of note:
- Jetty: 9.4.14 -> 9.4.18
* https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.15.v20190215
* https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.16.v20190411
* https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.17.v20190418
* https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.17.v20190418
* https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.18.v20190429
- zstd: 1.3.8-1 -> 1.4.0-1
* https://github.com/facebook/zstd/releases/tag/v1.4.0
* zstd's fastest strategy, 6-8% faster in most scenarios
- zookeeper: 3.4.13 -> 3.4.14
* https://zookeeper.apache.org/doc/r3.4.14/releasenotes.html
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
Reviewers: Manikumar Reddy <ma...@gmail.com>
---
.../kafka/connect/runtime/rest/RestServer.java | 5 +++--
.../kafka/connect/runtime/rest/util/SSLUtils.java | 2 ++
.../kafka/controller/ReplicaStateMachine.scala | 1 -
.../coordinator/group/GroupMetadataManager.scala | 4 ++--
core/src/main/scala/kafka/server/KafkaApis.scala | 2 +-
core/src/main/scala/kafka/tools/MirrorMaker.scala | 2 +-
.../kafka/api/AdminClientIntegrationTest.scala | 3 +--
.../AdminClientWithPoliciesIntegrationTest.scala | 1 +
.../kafka/api/AuthorizerIntegrationTest.scala | 1 +
.../kafka/api/BaseProducerSendTest.scala | 1 +
.../integration/kafka/api/ConsumerBounceTest.scala | 3 +--
.../kafka/api/EndToEndAuthorizationTest.scala | 1 +
.../scala/integration/kafka/api/MetricsTest.scala | 1 +
.../kafka/api/PlaintextConsumerTest.scala | 1 +
.../api/PlaintextEndToEndAuthorizationTest.scala | 1 +
.../kafka/api/ProducerFailureHandlingTest.scala | 1 +
.../kafka/api/SaslEndToEndAuthorizationTest.scala | 1 +
.../integration/kafka/api/TransactionsTest.scala | 1 +
.../kafka/network/DynamicConnectionQuotaTest.scala | 3 +--
.../server/DynamicBrokerReconfigurationTest.scala | 1 +
.../scala/kafka/tools/CustomDeserializerTest.scala | 7 +++---
.../scala/unit/kafka/admin/AclCommandTest.scala | 1 +
.../test/scala/unit/kafka/admin/AdminTest.scala | 1 +
.../scala/unit/kafka/admin/ConfigCommandTest.scala | 1 +
.../kafka/admin/DelegationTokenCommandTest.scala | 1 +
.../scala/unit/kafka/admin/DeleteTopicTest.scala | 1 +
.../admin/ReassignPartitionsCommandArgsTest.scala | 3 +--
.../admin/ReassignPartitionsCommandTest.scala | 1 +
.../kafka/admin/ResetConsumerGroupOffsetTest.scala | 2 +-
.../scala/unit/kafka/admin/TopicCommandTest.scala | 1 +
.../admin/TopicCommandWithAdminClientTest.scala | 1 +
.../test/scala/unit/kafka/api/ApiUtilsTest.scala | 3 +--
.../kafka/controller/ControllerFailoverTest.scala | 1 +
.../controller/ControllerIntegrationTest.scala | 1 +
.../PartitionLeaderElectionAlgorithmsTest.scala | 3 +--
.../controller/PartitionStateMachineTest.scala | 3 +--
.../kafka/controller/ReplicaStateMachineTest.scala | 3 +--
.../coordinator/group/GroupCoordinatorTest.scala | 4 ++--
.../group/GroupMetadataManagerTest.scala | 4 ++--
.../coordinator/group/GroupMetadataTest.scala | 3 +--
.../coordinator/group/MemberMetadataTest.scala | 3 +--
.../transaction/TransactionLogTest.scala | 4 ++--
.../transaction/TransactionStateManagerTest.scala | 2 +-
.../MetricsDuringTopicCreationDeletionTest.scala | 1 +
.../integration/UncleanLeaderElectionTest.scala | 1 +
.../unit/kafka/log/BrokerCompressionTest.scala | 3 +--
.../unit/kafka/log/LogCleanerManagerTest.scala | 4 ++--
.../test/scala/unit/kafka/log/LogCleanerTest.scala | 4 ++--
.../scala/unit/kafka/log/OffsetIndexTest.scala | 4 ++--
.../test/scala/unit/kafka/log/OffsetMapTest.scala | 3 +--
.../unit/kafka/log/ProducerStateManagerTest.scala | 4 ++--
.../unit/kafka/security/auth/OperationTest.scala | 3 +--
.../kafka/security/auth/PermissionTypeTest.scala | 4 ++--
.../kafka/security/auth/ResourceTypeTest.scala | 4 ++--
.../DelegationTokenRequestsOnPlainTextTest.scala | 1 +
.../kafka/server/DelegationTokenRequestsTest.scala | 1 +
...nTokenRequestsWithDisableTokenFeatureTest.scala | 1 +
.../kafka/server/DynamicBrokerConfigTest.scala | 4 ++--
.../scala/unit/kafka/server/KafkaServerTest.scala | 1 +
.../unit/kafka/server/LogDirFailureTest.scala | 1 +
.../unit/kafka/server/ProduceRequestTest.scala | 1 +
.../kafka/server/ServerGenerateBrokerIdTest.scala | 1 +
.../unit/kafka/server/ServerMetricsTest.scala | 4 ++--
.../LeaderEpochCheckpointFileTest.scala | 5 ++---
.../checkpoints/OffsetCheckpointFileTest.scala | 3 +--
.../unit/kafka/tools/DumpLogSegmentsTest.scala | 3 ++-
.../scala/unit/kafka/utils/CoreUtilsTest.scala | 3 +--
.../test/scala/unit/kafka/utils/TestUtils.scala | 6 +----
.../scala/unit/kafka/utils/TopicFilterTest.scala | 3 +--
.../scala/unit/kafka/zk/AdminZkClientTest.scala | 1 +
.../scala/unit/kafka/zk/KafkaZkClientTest.scala | 1 +
.../scala/unit/kafka/zk/ZooKeeperTestHarness.scala | 3 +--
.../unit/kafka/zookeeper/ZooKeeperClientTest.scala | 1 +
gradle/dependencies.gradle | 26 +++++++++++-----------
.../apache/kafka/streams/scala/TopologyTest.scala | 3 +--
.../apache/kafka/streams/scala/WordCountTest.scala | 3 +--
...StreamToTableJoinScalaIntegrationTestBase.scala | 3 +--
.../apache/kafka/trogdor/rest/JsonRestServer.java | 5 +++--
78 files changed, 111 insertions(+), 98 deletions(-)
diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java
index 1840b24..30c2f90 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java
@@ -34,7 +34,6 @@ import org.eclipse.jetty.server.Connector;
import org.eclipse.jetty.server.Handler;
import org.eclipse.jetty.server.Server;
import org.eclipse.jetty.server.ServerConnector;
-import org.eclipse.jetty.server.Slf4jRequestLog;
import org.eclipse.jetty.server.handler.DefaultHandler;
import org.eclipse.jetty.server.handler.HandlerCollection;
import org.eclipse.jetty.server.handler.RequestLogHandler;
@@ -160,6 +159,7 @@ public class RestServer {
return connector;
}
+ @SuppressWarnings("deprecation")
public void start(HerderProvider herderProvider, Plugins plugins) {
log.info("Starting REST server");
@@ -195,7 +195,8 @@ public class RestServer {
}
RequestLogHandler requestLogHandler = new RequestLogHandler();
- Slf4jRequestLog requestLog = new Slf4jRequestLog();
+ // Use fully qualified name to avoid deprecation warning
+ org.eclipse.jetty.server.Slf4jRequestLog requestLog = new org.eclipse.jetty.server.Slf4jRequestLog();
requestLog.setLoggerName(RestServer.class.getCanonicalName());
requestLog.setLogLatency(true);
requestLogHandler.setRequestLog(requestLog);
diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/util/SSLUtils.java b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/util/SSLUtils.java
index a50a0b0..f8ca2f5 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/util/SSLUtils.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/util/SSLUtils.java
@@ -44,6 +44,7 @@ public class SSLUtils {
/**
* Configures SSL/TLS for HTTPS Jetty Server / Client
*/
+ @SuppressWarnings("deprecation")
public static SslContextFactory createSslContextFactory(WorkerConfig config, boolean client) {
Map<String, Object> sslConfigValues = config.valuesWithPrefixAllOrNothing("listeners.https.");
@@ -140,6 +141,7 @@ public class SSLUtils {
/**
* Configures Authentication related settings in SslContextFactory
*/
+ @SuppressWarnings("deprecation")
protected static void configureSslContextFactoryAuthentication(SslContextFactory ssl, Map<String, Object> sslConfigValues) {
String sslClientAuth = (String) getOrDefault(sslConfigValues, BrokerSecurityConfigs.SSL_CLIENT_AUTH_CONFIG, "none");
switch (sslClientAuth) {
diff --git a/core/src/main/scala/kafka/controller/ReplicaStateMachine.scala b/core/src/main/scala/kafka/controller/ReplicaStateMachine.scala
index f7ec470..ae2f629 100644
--- a/core/src/main/scala/kafka/controller/ReplicaStateMachine.scala
+++ b/core/src/main/scala/kafka/controller/ReplicaStateMachine.scala
@@ -238,7 +238,6 @@ class ZkReplicaStateMachine(config: KafkaConfig,
val currentState = controllerContext.replicaState(replica)
logSuccessfulTransition(replicaId, replica.topicPartition, currentState, ReplicaDeletionStarted)
controllerContext.putReplicaState(replica, ReplicaDeletionStarted)
- val topicDeletionInProgress = controllerContext.isTopicDeletionInProgress(replica.topicPartition.topic)
controllerBrokerRequestBatch.addStopReplicaRequestForBrokers(Seq(replicaId), replica.topicPartition, deletePartition = true)
}
case ReplicaDeletionIneligible =>
diff --git a/core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala b/core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
index fc7f4e8..40643a4 100644
--- a/core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
+++ b/core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
@@ -26,7 +26,7 @@ import java.util.concurrent.atomic.AtomicBoolean
import java.util.concurrent.locks.ReentrantLock
import com.yammer.metrics.core.Gauge
-import kafka.api.{ApiVersion, KAFKA_0_10_1_IV0, KAFKA_2_1_IV0, KAFKA_2_1_IV1, KAFKA_2_2_IV0, KAFKA_2_3_IV0}
+import kafka.api.{ApiVersion, KAFKA_0_10_1_IV0, KAFKA_2_1_IV0, KAFKA_2_1_IV1, KAFKA_2_3_IV0}
import kafka.common.{MessageFormatter, OffsetAndMetadata}
import kafka.metrics.KafkaMetricsGroup
import kafka.server.ReplicaManager
@@ -40,7 +40,7 @@ import org.apache.kafka.common.protocol.Errors
import org.apache.kafka.common.protocol.types.Type._
import org.apache.kafka.common.protocol.types._
import org.apache.kafka.common.record._
-import org.apache.kafka.common.requests.{JoinGroupRequest, OffsetCommitRequest, OffsetFetchResponse}
+import org.apache.kafka.common.requests.{OffsetCommitRequest, OffsetFetchResponse}
import org.apache.kafka.common.requests.ProduceResponse.PartitionResponse
import org.apache.kafka.common.utils.{Time, Utils}
diff --git a/core/src/main/scala/kafka/server/KafkaApis.scala b/core/src/main/scala/kafka/server/KafkaApis.scala
index b0482c8..4e4c225 100644
--- a/core/src/main/scala/kafka/server/KafkaApis.scala
+++ b/core/src/main/scala/kafka/server/KafkaApis.scala
@@ -383,7 +383,7 @@ class KafkaApis(val requestChannel: RequestChannel,
new OffsetAndMetadata(
offset = partitionData.committedOffset(),
- leaderEpoch = Optional.ofNullable(new Integer(partitionData.committedLeaderEpoch())),
+ leaderEpoch = Optional.ofNullable[Integer](partitionData.committedLeaderEpoch),
metadata = metadata,
commitTimestamp = partitionData.commitTimestamp() match {
case OffsetCommitRequest.DEFAULT_TIMESTAMP => currentTimestamp
diff --git a/core/src/main/scala/kafka/tools/MirrorMaker.scala b/core/src/main/scala/kafka/tools/MirrorMaker.scala
index fda1812..b6cd60b 100755
--- a/core/src/main/scala/kafka/tools/MirrorMaker.scala
+++ b/core/src/main/scala/kafka/tools/MirrorMaker.scala
@@ -20,7 +20,7 @@ package kafka.tools
import java.time.Duration
import java.util
import java.util.concurrent.atomic.{AtomicBoolean, AtomicInteger}
-import java.util.concurrent.{CountDownLatch, TimeUnit}
+import java.util.concurrent.CountDownLatch
import java.util.regex.Pattern
import java.util.{Collections, Properties}
diff --git a/core/src/test/scala/integration/kafka/api/AdminClientIntegrationTest.scala b/core/src/test/scala/integration/kafka/api/AdminClientIntegrationTest.scala
index 9e35f40..46cd318 100644
--- a/core/src/test/scala/integration/kafka/api/AdminClientIntegrationTest.scala
+++ b/core/src/test/scala/integration/kafka/api/AdminClientIntegrationTest.scala
@@ -44,6 +44,7 @@ import org.apache.kafka.common.requests.{DeleteRecordsRequest, MetadataResponse}
import org.apache.kafka.common.resource.{PatternType, ResourcePattern, ResourceType}
import org.junit.rules.Timeout
import org.junit.Assert._
+import org.scalatest.Assertions.intercept
import scala.util.Random
import scala.collection.JavaConverters._
@@ -1588,8 +1589,6 @@ class AdminClientIntegrationTest extends IntegrationTestHarness with Logging {
object AdminClientIntegrationTest {
- import org.scalatest.Assertions._
-
def checkValidAlterConfigs(client: AdminClient, topicResource1: ConfigResource, topicResource2: ConfigResource): Unit = {
// Alter topics
var topicConfigEntries1 = Seq(
diff --git a/core/src/test/scala/integration/kafka/api/AdminClientWithPoliciesIntegrationTest.scala b/core/src/test/scala/integration/kafka/api/AdminClientWithPoliciesIntegrationTest.scala
index 1bea039..69d5c10 100644
--- a/core/src/test/scala/integration/kafka/api/AdminClientWithPoliciesIntegrationTest.scala
+++ b/core/src/test/scala/integration/kafka/api/AdminClientWithPoliciesIntegrationTest.scala
@@ -29,6 +29,7 @@ import org.apache.kafka.server.policy.AlterConfigPolicy
import org.junit.Assert.{assertEquals, assertNull, assertTrue}
import org.junit.{After, Before, Rule, Test}
import org.junit.rules.Timeout
+import org.scalatest.Assertions.intercept
import scala.collection.JavaConverters._
diff --git a/core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala b/core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala
index 1e7c8a8..e7a094f 100644
--- a/core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala
+++ b/core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala
@@ -48,6 +48,7 @@ import org.apache.kafka.common.{KafkaException, Node, TopicPartition, requests}
import org.apache.kafka.test.{TestUtils => JTestUtils}
import org.junit.Assert._
import org.junit.{After, Assert, Before, Test}
+import org.scalatest.Assertions.intercept
import scala.collection.JavaConverters._
import scala.collection.mutable
diff --git a/core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala b/core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala
index 8bb18c9..2f57f8d 100644
--- a/core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala
+++ b/core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala
@@ -34,6 +34,7 @@ import org.apache.kafka.common.security.auth.SecurityProtocol
import org.apache.kafka.common.{KafkaException, TopicPartition}
import org.junit.Assert._
import org.junit.{After, Before, Test}
+import org.scalatest.Assertions.fail
import scala.collection.JavaConverters._
import scala.collection.mutable.Buffer
diff --git a/core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala b/core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala
index de0a38f..385eb8f 100644
--- a/core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala
+++ b/core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala
@@ -17,7 +17,6 @@ import java.time
import java.util.concurrent._
import java.util.{Collection, Collections, Properties}
-import util.control.Breaks._
import kafka.server.KafkaConfig
import kafka.utils.{CoreUtils, Logging, ShutdownableThread, TestUtils}
import org.apache.kafka.clients.consumer._
@@ -505,7 +504,7 @@ class ConsumerBounceTest extends AbstractConsumerTest with Logging {
}
}
- private def createTopicPartitions(topic: String, numPartitions: Int = 1, replicationFactor: Int = 1,
+ private def createTopicPartitions(topic: String, numPartitions: Int, replicationFactor: Int,
topicConfig: Properties = new Properties): Set[TopicPartition] = {
createTopic(topic, numPartitions = numPartitions, replicationFactor = replicationFactor, topicConfig = topicConfig)
Range(0, numPartitions).map(part => new TopicPartition(topic, part)).toSet
diff --git a/core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala b/core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala
index 49977d0..9be1f1c 100644
--- a/core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala
+++ b/core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala
@@ -36,6 +36,7 @@ import org.apache.kafka.common.resource.PatternType
import org.apache.kafka.common.resource.PatternType.{LITERAL, PREFIXED}
import org.junit.Assert._
import org.junit.{After, Before, Test}
+import org.scalatest.Assertions.fail
import scala.collection.JavaConverters._
diff --git a/core/src/test/scala/integration/kafka/api/MetricsTest.scala b/core/src/test/scala/integration/kafka/api/MetricsTest.scala
index da466b8..f0ff496 100644
--- a/core/src/test/scala/integration/kafka/api/MetricsTest.scala
+++ b/core/src/test/scala/integration/kafka/api/MetricsTest.scala
@@ -28,6 +28,7 @@ import org.apache.kafka.common.network.ListenerName
import org.apache.kafka.common.security.auth.SecurityProtocol
import org.junit.{After, Before, Test}
import org.junit.Assert._
+import org.scalatest.Assertions.fail
import scala.collection.JavaConverters._
diff --git a/core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala b/core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala
index e3251a5..33c14eb 100644
--- a/core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala
+++ b/core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala
@@ -31,6 +31,7 @@ import org.apache.kafka.common.utils.Utils
import org.apache.kafka.test.{MockConsumerInterceptor, MockProducerInterceptor}
import org.junit.Assert._
import org.junit.Test
+import org.scalatest.Assertions.intercept
import scala.collection.JavaConverters._
import scala.collection.mutable.Buffer
diff --git a/core/src/test/scala/integration/kafka/api/PlaintextEndToEndAuthorizationTest.scala b/core/src/test/scala/integration/kafka/api/PlaintextEndToEndAuthorizationTest.scala
index fc1853b..5189e82 100644
--- a/core/src/test/scala/integration/kafka/api/PlaintextEndToEndAuthorizationTest.scala
+++ b/core/src/test/scala/integration/kafka/api/PlaintextEndToEndAuthorizationTest.scala
@@ -22,6 +22,7 @@ import org.apache.kafka.common.security.auth._
import org.junit.{Before, Test}
import org.junit.Assert._
import org.apache.kafka.common.errors.TopicAuthorizationException
+import org.scalatest.Assertions.intercept
// This test case uses a separate listener for client and inter-broker communication, from
// which we derive corresponding principals
diff --git a/core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala b/core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala
index 17d68d1..8d69b5f 100644
--- a/core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala
+++ b/core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala
@@ -30,6 +30,7 @@ import org.apache.kafka.common.internals.Topic
import org.apache.kafka.common.record.{DefaultRecord, DefaultRecordBatch}
import org.junit.Assert._
import org.junit.{After, Before, Test}
+import org.scalatest.Assertions.intercept
class ProducerFailureHandlingTest extends KafkaServerTestHarness {
private val producerBufferSize = 30000
diff --git a/core/src/test/scala/integration/kafka/api/SaslEndToEndAuthorizationTest.scala b/core/src/test/scala/integration/kafka/api/SaslEndToEndAuthorizationTest.scala
index c8521f6..aa6cb60 100644
--- a/core/src/test/scala/integration/kafka/api/SaslEndToEndAuthorizationTest.scala
+++ b/core/src/test/scala/integration/kafka/api/SaslEndToEndAuthorizationTest.scala
@@ -21,6 +21,7 @@ import org.apache.kafka.common.security.auth.SecurityProtocol
import org.apache.kafka.common.errors.{GroupAuthorizationException, TopicAuthorizationException}
import org.junit.{Before, Test}
import org.junit.Assert.{assertEquals, assertTrue}
+import org.scalatest.Assertions.fail
import scala.collection.immutable.List
import scala.collection.JavaConverters._
diff --git a/core/src/test/scala/integration/kafka/api/TransactionsTest.scala b/core/src/test/scala/integration/kafka/api/TransactionsTest.scala
index e3bfdc0..375adaa 100644
--- a/core/src/test/scala/integration/kafka/api/TransactionsTest.scala
+++ b/core/src/test/scala/integration/kafka/api/TransactionsTest.scala
@@ -32,6 +32,7 @@ import org.apache.kafka.common.{KafkaException, TopicPartition}
import org.apache.kafka.common.errors.{ProducerFencedException, TimeoutException}
import org.junit.{After, Before, Test}
import org.junit.Assert._
+import org.scalatest.Assertions.fail
import scala.collection.JavaConverters._
import scala.collection.mutable.Buffer
diff --git a/core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala b/core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala
index 8686575..4914a46 100644
--- a/core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala
+++ b/core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala
@@ -34,6 +34,7 @@ import org.apache.kafka.common.requests.{ProduceRequest, ProduceResponse}
import org.apache.kafka.common.security.auth.SecurityProtocol
import org.junit.Assert._
import org.junit.{After, Before, Test}
+import org.scalatest.Assertions.intercept
import scala.collection.JavaConverters._
@@ -70,7 +71,6 @@ class DynamicConnectionQuotaTest extends BaseRequestTest {
@Test
def testDynamicConnectionQuota() {
- val initialConnectionCount = connectionCount
val maxConnectionsPerIP = 5
def connectAndVerify() {
@@ -98,7 +98,6 @@ class DynamicConnectionQuotaTest extends BaseRequestTest {
@Test
def testDynamicListenerConnectionQuota(): Unit = {
- val socketServer = servers.head.socketServer
val initialConnectionCount = connectionCount
def connectAndVerify() {
diff --git a/core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala b/core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
index 760644e..ed6638c 100644
--- a/core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
+++ b/core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala
@@ -59,6 +59,7 @@ import org.apache.kafka.common.serialization.{StringDeserializer, StringSerializ
import org.apache.kafka.test.TestSslUtils
import org.junit.Assert._
import org.junit.{After, Before, Ignore, Test}
+import org.scalatest.Assertions.intercept
import scala.collection._
import scala.collection.mutable.ArrayBuffer
diff --git a/core/src/test/scala/kafka/tools/CustomDeserializerTest.scala b/core/src/test/scala/kafka/tools/CustomDeserializerTest.scala
index 7fb3cf3..d6b0100 100644
--- a/core/src/test/scala/kafka/tools/CustomDeserializerTest.scala
+++ b/core/src/test/scala/kafka/tools/CustomDeserializerTest.scala
@@ -24,7 +24,7 @@ import org.apache.kafka.common.serialization.Deserializer
import org.hamcrest.CoreMatchers
import org.hamcrest.MatcherAssert._
import org.junit.Test
-import org.scalatest.mockito.MockitoSugar
+import org.mockito.Mockito._
class CustomDeserializer extends Deserializer[String] {
@@ -34,14 +34,15 @@ class CustomDeserializer extends Deserializer[String] {
}
}
-class CustomDeserializerTest extends MockitoSugar {
+class CustomDeserializerTest {
@Test
def checkDeserializerTopicIsNotNull(): Unit = {
val formatter = new DefaultMessageFormatter()
formatter.keyDeserializer = Some(new CustomDeserializer)
- formatter.writeTo(new ConsumerRecord("topic_test", 1, 1l, "key".getBytes, "value".getBytes), mock[PrintStream])
+ formatter.writeTo(new ConsumerRecord("topic_test", 1, 1l, "key".getBytes, "value".getBytes),
+ mock(classOf[PrintStream]))
formatter.close()
}
diff --git a/core/src/test/scala/unit/kafka/admin/AclCommandTest.scala b/core/src/test/scala/unit/kafka/admin/AclCommandTest.scala
index 7d7b8e4..dc260e8 100644
--- a/core/src/test/scala/unit/kafka/admin/AclCommandTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/AclCommandTest.scala
@@ -30,6 +30,7 @@ import org.apache.kafka.common.resource.PatternType.{LITERAL, PREFIXED}
import org.apache.kafka.common.security.auth.{KafkaPrincipal, SecurityProtocol}
import org.apache.kafka.common.utils.SecurityUtils
import org.junit.{After, Before, Test}
+import org.scalatest.Assertions.intercept
class AclCommandTest extends ZooKeeperTestHarness with Logging {
diff --git a/core/src/test/scala/unit/kafka/admin/AdminTest.scala b/core/src/test/scala/unit/kafka/admin/AdminTest.scala
index a64f6e7..fa4206b 100755
--- a/core/src/test/scala/unit/kafka/admin/AdminTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/AdminTest.scala
@@ -30,6 +30,7 @@ import kafka.server.{ConfigType, KafkaConfig, KafkaServer}
import scala.collection.{Map, immutable}
import org.apache.kafka.common.security.JaasUtils
+import org.scalatest.Assertions.intercept
import scala.collection.JavaConverters._
diff --git a/core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala b/core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
index ee4a6ef..bd26a61 100644
--- a/core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala
@@ -37,6 +37,7 @@ import org.apache.kafka.common.utils.Sanitizer
import org.easymock.EasyMock
import org.junit.Assert._
import org.junit.Test
+import org.scalatest.Assertions.intercept
import scala.collection.{Seq, mutable}
import scala.collection.JavaConverters._
diff --git a/core/src/test/scala/unit/kafka/admin/DelegationTokenCommandTest.scala b/core/src/test/scala/unit/kafka/admin/DelegationTokenCommandTest.scala
index 0c9f4d3..98df2f1 100644
--- a/core/src/test/scala/unit/kafka/admin/DelegationTokenCommandTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/DelegationTokenCommandTest.scala
@@ -26,6 +26,7 @@ import org.apache.kafka.clients.admin.AdminClientConfig
import org.apache.kafka.common.security.auth.SecurityProtocol
import org.junit.Assert._
import org.junit.{After, Before, Test}
+import org.scalatest.Assertions.intercept
import scala.collection.JavaConverters._
import scala.collection.mutable.ListBuffer
diff --git a/core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala b/core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala
index 7a5b3e5..6e40cad 100644
--- a/core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala
@@ -29,6 +29,7 @@ import kafka.common.TopicAlreadyMarkedForDeletionException
import kafka.controller.{OfflineReplica, PartitionAndReplica, ReplicaDeletionSuccessful}
import org.apache.kafka.common.TopicPartition
import org.apache.kafka.common.errors.UnknownTopicOrPartitionException
+import org.scalatest.Assertions.fail
class DeleteTopicTest extends ZooKeeperTestHarness {
diff --git a/core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandArgsTest.scala b/core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandArgsTest.scala
index 58768c6..b42fce6 100644
--- a/core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandArgsTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandArgsTest.scala
@@ -19,9 +19,8 @@ package kafka.admin
import kafka.utils.Exit
import org.junit.Assert._
import org.junit.{After, Before, Test}
-import org.scalatest.junit.JUnitSuite
-class ReassignPartitionsCommandArgsTest extends JUnitSuite {
+class ReassignPartitionsCommandArgsTest {
@Before
def setUp() {
diff --git a/core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandTest.scala b/core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandTest.scala
index 128919f..6e5fcef 100644
--- a/core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandTest.scala
@@ -31,6 +31,7 @@ import org.easymock.EasyMock._
import org.easymock.{Capture, CaptureType, EasyMock}
import org.junit.{After, Before, Test}
import org.junit.Assert.{assertEquals, assertFalse, assertNull, assertTrue}
+import org.scalatest.Assertions.fail
import scala.collection.JavaConverters._
import org.apache.kafka.common.TopicPartition
diff --git a/core/src/test/scala/unit/kafka/admin/ResetConsumerGroupOffsetTest.scala b/core/src/test/scala/unit/kafka/admin/ResetConsumerGroupOffsetTest.scala
index cf5e36f..baf1d05 100644
--- a/core/src/test/scala/unit/kafka/admin/ResetConsumerGroupOffsetTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/ResetConsumerGroupOffsetTest.scala
@@ -459,7 +459,7 @@ class ResetConsumerGroupOffsetTest extends ConsumerGroupCommandTest {
TestUtils.produceMessages(servers, records, acks = 1)
}
- private def produceConsumeAndShutdown(topic: String, group: String = group, totalMessages: Int, numConsumers: Int = 1) {
+ private def produceConsumeAndShutdown(topic: String, group: String, totalMessages: Int, numConsumers: Int = 1) {
produceMessages(topic, totalMessages)
val executor = addConsumerGroupExecutor(numConsumers = numConsumers, topic = topic, group = group)
awaitConsumerProgress(topic, group, totalMessages)
diff --git a/core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala b/core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala
index 76ed423..407c2f3 100644
--- a/core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala
@@ -27,6 +27,7 @@ import org.apache.kafka.common.internals.Topic
import org.junit.Assert._
import org.junit.rules.TestName
import org.junit.{After, Before, Rule, Test}
+import org.scalatest.Assertions.intercept
import scala.util.Random
diff --git a/core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala b/core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
index bc0eadf..caa7a3b 100644
--- a/core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
@@ -34,6 +34,7 @@ import org.apache.kafka.common.security.auth.SecurityProtocol
import org.junit.Assert.{assertEquals, assertFalse, assertTrue}
import org.junit.{After, Before, Rule, Test}
import org.junit.rules.TestName
+import org.scalatest.Assertions.{fail, intercept}
import scala.collection.JavaConverters._
import scala.concurrent.ExecutionException
diff --git a/core/src/test/scala/unit/kafka/api/ApiUtilsTest.scala b/core/src/test/scala/unit/kafka/api/ApiUtilsTest.scala
index 9fe4cbf..46adedf 100644
--- a/core/src/test/scala/unit/kafka/api/ApiUtilsTest.scala
+++ b/core/src/test/scala/unit/kafka/api/ApiUtilsTest.scala
@@ -18,7 +18,6 @@
package kafka.api
import org.junit._
-import org.scalatest.junit.JUnitSuite
import org.junit.Assert._
import scala.util.Random
@@ -31,7 +30,7 @@ object ApiUtilsTest {
val rnd: Random = new Random()
}
-class ApiUtilsTest extends JUnitSuite {
+class ApiUtilsTest {
@Test
def testShortStringNonASCII() {
diff --git a/core/src/test/scala/unit/kafka/controller/ControllerFailoverTest.scala b/core/src/test/scala/unit/kafka/controller/ControllerFailoverTest.scala
index 283858c..44bbca3 100644
--- a/core/src/test/scala/unit/kafka/controller/ControllerFailoverTest.scala
+++ b/core/src/test/scala/unit/kafka/controller/ControllerFailoverTest.scala
@@ -28,6 +28,7 @@ import org.apache.kafka.common.metrics.Metrics
import org.apache.log4j.Logger
import org.junit.{After, Test}
import org.junit.Assert._
+import org.scalatest.Assertions.fail
class ControllerFailoverTest extends KafkaServerTestHarness with Logging {
val log = Logger.getLogger(classOf[ControllerFailoverTest])
diff --git a/core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala b/core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala
index f167876..ebb9b4a 100644
--- a/core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala
+++ b/core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala
@@ -33,6 +33,7 @@ import org.apache.kafka.common.errors.{ControllerMovedException, StaleBrokerEpoc
import org.apache.log4j.Level
import kafka.utils.LogCaptureAppender
import org.apache.kafka.common.metrics.KafkaMetric
+import org.scalatest.Assertions.fail
import scala.collection.JavaConverters._
import scala.collection.mutable
diff --git a/core/src/test/scala/unit/kafka/controller/PartitionLeaderElectionAlgorithmsTest.scala b/core/src/test/scala/unit/kafka/controller/PartitionLeaderElectionAlgorithmsTest.scala
index 113a39d..3fd4192 100644
--- a/core/src/test/scala/unit/kafka/controller/PartitionLeaderElectionAlgorithmsTest.scala
+++ b/core/src/test/scala/unit/kafka/controller/PartitionLeaderElectionAlgorithmsTest.scala
@@ -18,9 +18,8 @@ package kafka.controller
import org.junit.Assert._
import org.junit.{Before, Test}
-import org.scalatest.junit.JUnitSuite
-class PartitionLeaderElectionAlgorithmsTest extends JUnitSuite {
+class PartitionLeaderElectionAlgorithmsTest {
private var controllerContext: ControllerContext = null
@Before
diff --git a/core/src/test/scala/unit/kafka/controller/PartitionStateMachineTest.scala b/core/src/test/scala/unit/kafka/controller/PartitionStateMachineTest.scala
index ba90231..1d83470 100644
--- a/core/src/test/scala/unit/kafka/controller/PartitionStateMachineTest.scala
+++ b/core/src/test/scala/unit/kafka/controller/PartitionStateMachineTest.scala
@@ -30,9 +30,8 @@ import org.easymock.EasyMock
import org.junit.Assert._
import org.junit.{Before, Test}
import org.mockito.Mockito
-import org.scalatest.junit.JUnitSuite
-class PartitionStateMachineTest extends JUnitSuite {
+class PartitionStateMachineTest {
private var controllerContext: ControllerContext = null
private var mockZkClient: KafkaZkClient = null
private var mockControllerBrokerRequestBatch: ControllerBrokerRequestBatch = null
diff --git a/core/src/test/scala/unit/kafka/controller/ReplicaStateMachineTest.scala b/core/src/test/scala/unit/kafka/controller/ReplicaStateMachineTest.scala
index cfadfbe..2a67e74 100644
--- a/core/src/test/scala/unit/kafka/controller/ReplicaStateMachineTest.scala
+++ b/core/src/test/scala/unit/kafka/controller/ReplicaStateMachineTest.scala
@@ -28,9 +28,8 @@ import org.apache.zookeeper.data.Stat
import org.easymock.EasyMock
import org.junit.Assert._
import org.junit.{Before, Test}
-import org.scalatest.junit.JUnitSuite
-class ReplicaStateMachineTest extends JUnitSuite {
+class ReplicaStateMachineTest {
private var controllerContext: ControllerContext = null
private var mockZkClient: KafkaZkClient = null
private var mockControllerBrokerRequestBatch: ControllerBrokerRequestBatch = null
diff --git a/core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala b/core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala
index 478f027..54c7eb3 100644
--- a/core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala
+++ b/core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala
@@ -37,14 +37,14 @@ import kafka.zk.KafkaZkClient
import org.apache.kafka.common.internals.Topic
import org.junit.Assert._
import org.junit.{After, Assert, Before, Test}
-import org.scalatest.junit.JUnitSuite
+import org.scalatest.Assertions.intercept
import scala.collection.mutable
import scala.collection.mutable.ArrayBuffer
import scala.concurrent.duration.Duration
import scala.concurrent.{Await, Future, Promise, TimeoutException}
-class GroupCoordinatorTest extends JUnitSuite {
+class GroupCoordinatorTest {
type JoinGroupCallback = JoinGroupResult => Unit
type SyncGroupCallbackParams = (Array[Byte], Errors)
type SyncGroupCallback = (Array[Byte], Errors) => Unit
diff --git a/core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala b/core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala
index 6c83da3..dab2d72 100644
--- a/core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala
+++ b/core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala
@@ -22,7 +22,6 @@ import kafka.cluster.Partition
import kafka.common.OffsetAndMetadata
import kafka.log.{Log, LogAppendInfo}
import kafka.server.{FetchDataInfo, KafkaConfig, LogOffsetMetadata, ReplicaManager}
-import kafka.utils.TestUtils.fail
import kafka.utils.{KafkaScheduler, MockTime, TestUtils}
import org.apache.kafka.clients.consumer.internals.ConsumerProtocol
import org.apache.kafka.clients.consumer.internals.PartitionAssignor.Subscription
@@ -34,6 +33,7 @@ import org.apache.kafka.common.requests.ProduceResponse.PartitionResponse
import org.easymock.{Capture, EasyMock, IAnswer}
import org.junit.Assert.{assertEquals, assertFalse, assertNull, assertTrue}
import org.junit.{Before, Test}
+import org.scalatest.Assertions.fail
import java.nio.ByteBuffer
import java.util.Collections
import java.util.Optional
@@ -710,7 +710,7 @@ class GroupMetadataManagerTest {
groupMetadataManager.loadGroupsAndOffsets(groupMetadataTopicPartition, _ => ())
- val group = groupMetadataManager.getGroup(groupId).getOrElse(TestUtils.fail("Group was not loaded into the cache"))
+ val group = groupMetadataManager.getGroup(groupId).getOrElse(fail("Group was not loaded into the cache"))
assertEquals(groupId, group.groupId)
assertEquals(Empty, group.currentState)
assertEquals(committedOffsets.size, group.allOffsets.size)
diff --git a/core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala b/core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala
index 11af899..a3a9008 100644
--- a/core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala
+++ b/core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala
@@ -22,12 +22,11 @@ import org.apache.kafka.common.TopicPartition
import org.apache.kafka.common.utils.Time
import org.junit.Assert._
import org.junit.{Before, Test}
-import org.scalatest.junit.JUnitSuite
/**
* Test group state transitions and other GroupMetadata functionality
*/
-class GroupMetadataTest extends JUnitSuite {
+class GroupMetadataTest {
private val protocolType = "consumer"
private val groupId = "groupId"
private val groupInstanceId = Some("groupInstanceId")
diff --git a/core/src/test/scala/unit/kafka/coordinator/group/MemberMetadataTest.scala b/core/src/test/scala/unit/kafka/coordinator/group/MemberMetadataTest.scala
index 986d015..6c818d0 100644
--- a/core/src/test/scala/unit/kafka/coordinator/group/MemberMetadataTest.scala
+++ b/core/src/test/scala/unit/kafka/coordinator/group/MemberMetadataTest.scala
@@ -20,9 +20,8 @@ import java.util.Arrays
import org.junit.Assert._
import org.junit.Test
-import org.scalatest.junit.JUnitSuite
-class MemberMetadataTest extends JUnitSuite {
+class MemberMetadataTest {
val groupId = "groupId"
val groupInstanceId = Some("groupInstanceId")
val clientId = "clientId"
diff --git a/core/src/test/scala/unit/kafka/coordinator/transaction/TransactionLogTest.scala b/core/src/test/scala/unit/kafka/coordinator/transaction/TransactionLogTest.scala
index c0edec7..21e9270 100644
--- a/core/src/test/scala/unit/kafka/coordinator/transaction/TransactionLogTest.scala
+++ b/core/src/test/scala/unit/kafka/coordinator/transaction/TransactionLogTest.scala
@@ -22,11 +22,11 @@ import org.apache.kafka.common.record.{CompressionType, SimpleRecord, MemoryReco
import org.junit.Assert.assertEquals
import org.junit.Test
-import org.scalatest.junit.JUnitSuite
+import org.scalatest.Assertions.intercept
import scala.collection.JavaConverters._
-class TransactionLogTest extends JUnitSuite {
+class TransactionLogTest {
val producerEpoch: Short = 0
val transactionTimeoutMs: Int = 1000
diff --git a/core/src/test/scala/unit/kafka/coordinator/transaction/TransactionStateManagerTest.scala b/core/src/test/scala/unit/kafka/coordinator/transaction/TransactionStateManagerTest.scala
index 34a37be..bee333d 100644
--- a/core/src/test/scala/unit/kafka/coordinator/transaction/TransactionStateManagerTest.scala
+++ b/core/src/test/scala/unit/kafka/coordinator/transaction/TransactionStateManagerTest.scala
@@ -22,7 +22,7 @@ import java.util.concurrent.locks.ReentrantLock
import kafka.log.Log
import kafka.server.{FetchDataInfo, LogOffsetMetadata, ReplicaManager}
import kafka.utils.{MockScheduler, Pool}
-import kafka.utils.TestUtils.fail
+import org.scalatest.Assertions.fail
import kafka.zk.KafkaZkClient
import org.apache.kafka.common.TopicPartition
import org.apache.kafka.common.internals.Topic.TRANSACTION_STATE_TOPIC_NAME
diff --git a/core/src/test/scala/unit/kafka/integration/MetricsDuringTopicCreationDeletionTest.scala b/core/src/test/scala/unit/kafka/integration/MetricsDuringTopicCreationDeletionTest.scala
index c1d310f..20ac71c 100644
--- a/core/src/test/scala/unit/kafka/integration/MetricsDuringTopicCreationDeletionTest.scala
+++ b/core/src/test/scala/unit/kafka/integration/MetricsDuringTopicCreationDeletionTest.scala
@@ -21,6 +21,7 @@ import java.util.Properties
import kafka.server.KafkaConfig
import kafka.utils.{Logging, TestUtils}
import scala.collection.JavaConverters.mapAsScalaMapConverter
+import org.scalatest.Assertions.fail
import org.junit.{Before, Test}
import com.yammer.metrics.Metrics
diff --git a/core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala b/core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala
index a13b570..a6d856d 100755
--- a/core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala
+++ b/core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala
@@ -37,6 +37,7 @@ import org.apache.kafka.common.security.auth.SecurityProtocol
import org.apache.kafka.common.serialization.StringDeserializer
import org.apache.kafka.clients.admin.{AdminClient, AdminClientConfig}
import org.junit.Assert._
+import org.scalatest.Assertions.intercept
class UncleanLeaderElectionTest extends ZooKeeperTestHarness {
val brokerId1 = 0
diff --git a/core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala b/core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala
index 8372387..557cef3 100755
--- a/core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala
+++ b/core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala
@@ -19,7 +19,6 @@ package kafka.log
import kafka.utils._
import kafka.message._
-import org.scalatest.junit.JUnitSuite
import org.junit._
import org.junit.Assert._
import org.junit.runner.RunWith
@@ -34,7 +33,7 @@ import kafka.server.{BrokerTopicStats, LogDirFailureChannel}
import scala.collection.JavaConverters._
@RunWith(value = classOf[Parameterized])
-class BrokerCompressionTest(messageCompression: String, brokerCompression: String) extends JUnitSuite {
+class BrokerCompressionTest(messageCompression: String, brokerCompression: String) {
val tmpDir = TestUtils.tempDir()
val logDir = TestUtils.randomPartitionLogDir(tmpDir)
diff --git a/core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala b/core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala
index 8ca26a8..7c83cde 100644
--- a/core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala
+++ b/core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala
@@ -27,14 +27,14 @@ import org.apache.kafka.common.record._
import org.apache.kafka.common.utils.Utils
import org.junit.Assert._
import org.junit.{After, Test}
-import org.scalatest.junit.JUnitSuite
+import org.scalatest.Assertions.intercept
import scala.collection.mutable
/**
* Unit tests for the log cleaning logic
*/
-class LogCleanerManagerTest extends JUnitSuite with Logging {
+class LogCleanerManagerTest extends Logging {
val tmpDir = TestUtils.tempDir()
val logDir = TestUtils.randomPartitionLogDir(tmpDir)
diff --git a/core/src/test/scala/unit/kafka/log/LogCleanerTest.scala b/core/src/test/scala/unit/kafka/log/LogCleanerTest.scala
index 51477b6..321800a 100755
--- a/core/src/test/scala/unit/kafka/log/LogCleanerTest.scala
+++ b/core/src/test/scala/unit/kafka/log/LogCleanerTest.scala
@@ -32,7 +32,7 @@ import org.apache.kafka.common.record._
import org.apache.kafka.common.utils.Utils
import org.junit.Assert._
import org.junit.{After, Test}
-import org.scalatest.junit.JUnitSuite
+import org.scalatest.Assertions.{assertThrows, fail, intercept}
import scala.collection.JavaConverters._
import scala.collection._
@@ -40,7 +40,7 @@ import scala.collection._
/**
* Unit tests for the log cleaning logic
*/
-class LogCleanerTest extends JUnitSuite {
+class LogCleanerTest {
val tmpdir = TestUtils.tempDir()
val dir = TestUtils.randomPartitionLogDir(tmpdir)
diff --git a/core/src/test/scala/unit/kafka/log/OffsetIndexTest.scala b/core/src/test/scala/unit/kafka/log/OffsetIndexTest.scala
index 4e2ab2f..d8d0484 100644
--- a/core/src/test/scala/unit/kafka/log/OffsetIndexTest.scala
+++ b/core/src/test/scala/unit/kafka/log/OffsetIndexTest.scala
@@ -24,14 +24,14 @@ import org.junit.Assert._
import java.util.{Arrays, Collections}
import org.junit._
-import org.scalatest.junit.JUnitSuite
+import org.scalatest.Assertions.intercept
import scala.collection._
import scala.util.Random
import kafka.utils.TestUtils
import org.apache.kafka.common.errors.InvalidOffsetException
-class OffsetIndexTest extends JUnitSuite {
+class OffsetIndexTest {
var idx: OffsetIndex = null
val maxEntries = 30
diff --git a/core/src/test/scala/unit/kafka/log/OffsetMapTest.scala b/core/src/test/scala/unit/kafka/log/OffsetMapTest.scala
index 4057562..e01bc7c 100644
--- a/core/src/test/scala/unit/kafka/log/OffsetMapTest.scala
+++ b/core/src/test/scala/unit/kafka/log/OffsetMapTest.scala
@@ -21,10 +21,9 @@ import java.nio._
import kafka.utils.Exit
import org.junit._
-import org.scalatest.junit.JUnitSuite
import org.junit.Assert._
-class OffsetMapTest extends JUnitSuite {
+class OffsetMapTest {
@Test
def testBasicValidation() {
diff --git a/core/src/test/scala/unit/kafka/log/ProducerStateManagerTest.scala b/core/src/test/scala/unit/kafka/log/ProducerStateManagerTest.scala
index fe08a57..6f4979b 100644
--- a/core/src/test/scala/unit/kafka/log/ProducerStateManagerTest.scala
+++ b/core/src/test/scala/unit/kafka/log/ProducerStateManagerTest.scala
@@ -33,9 +33,9 @@ import org.apache.kafka.common.utils.{MockTime, Utils}
import org.easymock.EasyMock
import org.junit.Assert._
import org.junit.{After, Before, Test}
-import org.scalatest.junit.JUnitSuite
+import org.scalatest.Assertions.{assertThrows, fail}
-class ProducerStateManagerTest extends JUnitSuite {
+class ProducerStateManagerTest {
var logDir: File = null
var stateManager: ProducerStateManager = null
val partition = new TopicPartition("test", 0)
diff --git a/core/src/test/scala/unit/kafka/security/auth/OperationTest.scala b/core/src/test/scala/unit/kafka/security/auth/OperationTest.scala
index 242c768..6773096 100644
--- a/core/src/test/scala/unit/kafka/security/auth/OperationTest.scala
+++ b/core/src/test/scala/unit/kafka/security/auth/OperationTest.scala
@@ -20,9 +20,8 @@ package kafka.security.auth
import org.apache.kafka.common.acl.AclOperation
import org.junit.Assert.assertEquals
import org.junit.Test
-import org.scalatest.junit.JUnitSuite
-class OperationTest extends JUnitSuite {
+class OperationTest {
/**
* Test round trip conversions between org.apache.kafka.common.acl.AclOperation and
* kafka.security.auth.Operation.
diff --git a/core/src/test/scala/unit/kafka/security/auth/PermissionTypeTest.scala b/core/src/test/scala/unit/kafka/security/auth/PermissionTypeTest.scala
index 0ee66e6..8b2c5bc 100644
--- a/core/src/test/scala/unit/kafka/security/auth/PermissionTypeTest.scala
+++ b/core/src/test/scala/unit/kafka/security/auth/PermissionTypeTest.scala
@@ -20,9 +20,9 @@ import kafka.common.KafkaException
import org.apache.kafka.common.acl.AclPermissionType
import org.junit.Assert.assertEquals
import org.junit.Test
-import org.scalatest.junit.JUnitSuite
+import org.scalatest.Assertions.fail
-class PermissionTypeTest extends JUnitSuite {
+class PermissionTypeTest {
@Test
def testFromString(): Unit = {
diff --git a/core/src/test/scala/unit/kafka/security/auth/ResourceTypeTest.scala b/core/src/test/scala/unit/kafka/security/auth/ResourceTypeTest.scala
index 0d99378..bfefbba 100644
--- a/core/src/test/scala/unit/kafka/security/auth/ResourceTypeTest.scala
+++ b/core/src/test/scala/unit/kafka/security/auth/ResourceTypeTest.scala
@@ -19,10 +19,10 @@ package kafka.security.auth
import kafka.common.KafkaException
import org.junit.Assert.assertEquals
import org.junit.Test
-import org.scalatest.junit.JUnitSuite
+import org.scalatest.Assertions.fail
import org.apache.kafka.common.resource.{ResourceType => JResourceType}
-class ResourceTypeTest extends JUnitSuite {
+class ResourceTypeTest {
@Test
def testFromString(): Unit = {
diff --git a/core/src/test/scala/unit/kafka/server/DelegationTokenRequestsOnPlainTextTest.scala b/core/src/test/scala/unit/kafka/server/DelegationTokenRequestsOnPlainTextTest.scala
index 0a7e194..9c50b15 100644
--- a/core/src/test/scala/unit/kafka/server/DelegationTokenRequestsOnPlainTextTest.scala
+++ b/core/src/test/scala/unit/kafka/server/DelegationTokenRequestsOnPlainTextTest.scala
@@ -22,6 +22,7 @@ import kafka.utils.TestUtils
import org.apache.kafka.clients.admin.{AdminClient, AdminClientConfig}
import org.apache.kafka.common.errors.UnsupportedByAuthenticationException
import org.junit.{After, Before, Test}
+import org.scalatest.Assertions.intercept
import scala.collection.JavaConverters._
import scala.concurrent.ExecutionException
diff --git a/core/src/test/scala/unit/kafka/server/DelegationTokenRequestsTest.scala b/core/src/test/scala/unit/kafka/server/DelegationTokenRequestsTest.scala
index ae65016..aec3cb6 100644
--- a/core/src/test/scala/unit/kafka/server/DelegationTokenRequestsTest.scala
+++ b/core/src/test/scala/unit/kafka/server/DelegationTokenRequestsTest.scala
@@ -26,6 +26,7 @@ import org.apache.kafka.common.security.auth.SecurityProtocol
import org.apache.kafka.common.utils.SecurityUtils
import org.junit.Assert._
import org.junit.{After, Before, Test}
+import org.scalatest.Assertions.intercept
import scala.collection.JavaConverters._
import scala.concurrent.ExecutionException
diff --git a/core/src/test/scala/unit/kafka/server/DelegationTokenRequestsWithDisableTokenFeatureTest.scala b/core/src/test/scala/unit/kafka/server/DelegationTokenRequestsWithDisableTokenFeatureTest.scala
index 7de624f..04fd536 100644
--- a/core/src/test/scala/unit/kafka/server/DelegationTokenRequestsWithDisableTokenFeatureTest.scala
+++ b/core/src/test/scala/unit/kafka/server/DelegationTokenRequestsWithDisableTokenFeatureTest.scala
@@ -24,6 +24,7 @@ import org.apache.kafka.clients.admin.{AdminClient, AdminClientConfig}
import org.apache.kafka.common.errors.DelegationTokenDisabledException
import org.apache.kafka.common.security.auth.SecurityProtocol
import org.junit.{After, Before, Test}
+import org.scalatest.Assertions.intercept
import scala.collection.JavaConverters._
import scala.concurrent.ExecutionException
diff --git a/core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala b/core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala
index 5d20da6..278f0ce 100755
--- a/core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala
+++ b/core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala
@@ -28,12 +28,12 @@ import org.apache.kafka.common.config.{ConfigException, SslConfigs}
import org.easymock.EasyMock
import org.junit.Assert._
import org.junit.Test
-import org.scalatest.junit.JUnitSuite
+import org.scalatest.Assertions.intercept
import scala.collection.JavaConverters._
import scala.collection.Set
-class DynamicBrokerConfigTest extends JUnitSuite {
+class DynamicBrokerConfigTest {
@Test
def testConfigUpdate(): Unit = {
diff --git a/core/src/test/scala/unit/kafka/server/KafkaServerTest.scala b/core/src/test/scala/unit/kafka/server/KafkaServerTest.scala
index d78821a..fc6d043 100755
--- a/core/src/test/scala/unit/kafka/server/KafkaServerTest.scala
+++ b/core/src/test/scala/unit/kafka/server/KafkaServerTest.scala
@@ -20,6 +20,7 @@ package kafka.server
import kafka.utils.TestUtils
import kafka.zk.ZooKeeperTestHarness
import org.junit.Test
+import org.scalatest.Assertions.intercept
class KafkaServerTest extends ZooKeeperTestHarness {
diff --git a/core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala b/core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala
index f8c56cb..0fd289c 100644
--- a/core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala
+++ b/core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala
@@ -31,6 +31,7 @@ import org.apache.kafka.common.utils.Utils
import org.apache.kafka.common.errors.{KafkaStorageException, NotLeaderForPartitionException}
import org.junit.{Before, Test}
import org.junit.Assert.{assertEquals, assertFalse, assertTrue}
+import org.scalatest.Assertions.fail
import scala.collection.JavaConverters._
diff --git a/core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala b/core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala
index 906de71..21644fa 100644
--- a/core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala
+++ b/core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala
@@ -28,6 +28,7 @@ import org.apache.kafka.common.record._
import org.apache.kafka.common.requests.{ProduceRequest, ProduceResponse}
import org.junit.Assert._
import org.junit.Test
+import org.scalatest.Assertions.fail
import scala.collection.JavaConverters._
diff --git a/core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala b/core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala
index 2fa6600..afa0d51 100755
--- a/core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala
+++ b/core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala
@@ -23,6 +23,7 @@ import kafka.utils.TestUtils
import org.junit.{After, Before, Test}
import org.junit.Assert._
import java.io.File
+import org.scalatest.Assertions.intercept
import org.apache.zookeeper.KeeperException.NodeExistsException
diff --git a/core/src/test/scala/unit/kafka/server/ServerMetricsTest.scala b/core/src/test/scala/unit/kafka/server/ServerMetricsTest.scala
index dc96680..1883edd 100755
--- a/core/src/test/scala/unit/kafka/server/ServerMetricsTest.scala
+++ b/core/src/test/scala/unit/kafka/server/ServerMetricsTest.scala
@@ -21,9 +21,9 @@ import kafka.utils.TestUtils
import org.apache.kafka.common.metrics.Sensor
import org.junit.Assert._
import org.junit.Test
-import org.scalatest.junit.JUnitSuite
+import org.scalatest.Assertions.intercept
-class ServerMetricsTest extends JUnitSuite {
+class ServerMetricsTest {
@Test
def testMetricsConfig(): Unit = {
diff --git a/core/src/test/scala/unit/kafka/server/checkpoints/LeaderEpochCheckpointFileTest.scala b/core/src/test/scala/unit/kafka/server/checkpoints/LeaderEpochCheckpointFileTest.scala
index 0c47f15..b3f90bc 100644
--- a/core/src/test/scala/unit/kafka/server/checkpoints/LeaderEpochCheckpointFileTest.scala
+++ b/core/src/test/scala/unit/kafka/server/checkpoints/LeaderEpochCheckpointFileTest.scala
@@ -22,9 +22,8 @@ import kafka.server.epoch.EpochEntry
import kafka.utils.Logging
import org.junit.Assert._
import org.junit.Test
-import org.scalatest.junit.JUnitSuite
-class LeaderEpochCheckpointFileTest extends JUnitSuite with Logging{
+class LeaderEpochCheckpointFileTest extends Logging {
@Test
def shouldPersistAndOverwriteAndReloadFile(): Unit ={
@@ -68,4 +67,4 @@ class LeaderEpochCheckpointFileTest extends JUnitSuite with Logging{
//The data should still be there
assertEquals(epochs, checkpoint2.read())
}
-}
\ No newline at end of file
+}
diff --git a/core/src/test/scala/unit/kafka/server/checkpoints/OffsetCheckpointFileTest.scala b/core/src/test/scala/unit/kafka/server/checkpoints/OffsetCheckpointFileTest.scala
index f4998f6..2d20674 100644
--- a/core/src/test/scala/unit/kafka/server/checkpoints/OffsetCheckpointFileTest.scala
+++ b/core/src/test/scala/unit/kafka/server/checkpoints/OffsetCheckpointFileTest.scala
@@ -22,11 +22,10 @@ import org.apache.kafka.common.TopicPartition
import org.apache.kafka.common.errors.KafkaStorageException
import org.junit.Assert._
import org.junit.Test
-import org.scalatest.junit.JUnitSuite
import scala.collection.Map
-class OffsetCheckpointFileTest extends JUnitSuite with Logging {
+class OffsetCheckpointFileTest extends Logging {
@Test
def shouldPersistAndOverwriteAndReloadFile(): Unit = {
diff --git a/core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala b/core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala
index da830a8..61a0804 100644
--- a/core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala
+++ b/core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala
@@ -29,6 +29,7 @@ import org.apache.kafka.common.record.{CompressionType, MemoryRecords, SimpleRec
import org.apache.kafka.common.utils.Utils
import org.junit.Assert._
import org.junit.{After, Before, Test}
+import org.scalatest.Assertions.fail
import scala.collection.mutable.ArrayBuffer
@@ -96,7 +97,7 @@ class DumpLogSegmentsTest {
i += 1
}
}
- TestUtils.fail(s"No match for index $index")
+ fail(s"No match for index $index")
}
val output = runDumpLogSegments(args)
diff --git a/core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala b/core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala
index 93578c6..c1263e0 100755
--- a/core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala
+++ b/core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala
@@ -24,7 +24,6 @@ import java.util.concurrent.locks.ReentrantLock
import java.nio.ByteBuffer
import java.util.regex.Pattern
-import org.scalatest.junit.JUnitSuite
import org.junit.Assert._
import kafka.utils.CoreUtils.inLock
import org.apache.kafka.common.KafkaException
@@ -37,7 +36,7 @@ import scala.collection.mutable
import scala.concurrent.duration.Duration
import scala.concurrent.{Await, ExecutionContext, Future}
-class CoreUtilsTest extends JUnitSuite with Logging {
+class CoreUtilsTest extends Logging {
val clusterIdPattern = Pattern.compile("[a-zA-Z0-9_\\-]+")
diff --git a/core/src/test/scala/unit/kafka/utils/TestUtils.scala b/core/src/test/scala/unit/kafka/utils/TestUtils.scala
index f1a5cca..59ee426 100755
--- a/core/src/test/scala/unit/kafka/utils/TestUtils.scala
+++ b/core/src/test/scala/unit/kafka/utils/TestUtils.scala
@@ -58,6 +58,7 @@ import org.apache.zookeeper.KeeperException.SessionExpiredException
import org.apache.zookeeper.ZooDefs._
import org.apache.zookeeper.data.ACL
import org.junit.Assert._
+import org.scalatest.Assertions.fail
import scala.collection.JavaConverters._
import scala.collection.{Map, mutable}
@@ -377,11 +378,6 @@ object TestUtils extends Logging {
}
/**
- * Fail a test case explicitly. Return Nothing so that we are not constrained by the return type.
- */
- def fail(msg: String): Nothing = throw new AssertionError(msg)
-
- /**
* Wrap a single record log buffer.
*/
def singletonRecords(value: Array[Byte],
diff --git a/core/src/test/scala/unit/kafka/utils/TopicFilterTest.scala b/core/src/test/scala/unit/kafka/utils/TopicFilterTest.scala
index 19cd1b6..d95a7fc 100644
--- a/core/src/test/scala/unit/kafka/utils/TopicFilterTest.scala
+++ b/core/src/test/scala/unit/kafka/utils/TopicFilterTest.scala
@@ -20,9 +20,8 @@ package kafka.utils
import org.apache.kafka.common.internals.Topic
import org.junit.Assert._
import org.junit.Test
-import org.scalatest.junit.JUnitSuite
-class TopicFilterTest extends JUnitSuite {
+class TopicFilterTest {
@Test
def testWhitelists() {
diff --git a/core/src/test/scala/unit/kafka/zk/AdminZkClientTest.scala b/core/src/test/scala/unit/kafka/zk/AdminZkClientTest.scala
index fa8635f..9557d15 100644
--- a/core/src/test/scala/unit/kafka/zk/AdminZkClientTest.scala
+++ b/core/src/test/scala/unit/kafka/zk/AdminZkClientTest.scala
@@ -35,6 +35,7 @@ import org.apache.kafka.test.{TestUtils => JTestUtils}
import org.easymock.EasyMock
import org.junit.Assert._
import org.junit.{After, Test}
+import org.scalatest.Assertions.intercept
import scala.collection.JavaConverters._
import scala.collection.{Map, immutable}
diff --git a/core/src/test/scala/unit/kafka/zk/KafkaZkClientTest.scala b/core/src/test/scala/unit/kafka/zk/KafkaZkClientTest.scala
index 12790f5..66a8114 100644
--- a/core/src/test/scala/unit/kafka/zk/KafkaZkClientTest.scala
+++ b/core/src/test/scala/unit/kafka/zk/KafkaZkClientTest.scala
@@ -34,6 +34,7 @@ import org.apache.kafka.common.utils.{SecurityUtils, Time}
import org.apache.zookeeper.KeeperException.{Code, NoNodeException, NodeExistsException}
import org.junit.Assert._
import org.junit.{After, Before, Test}
+import org.scalatest.Assertions.intercept
import scala.collection.JavaConverters._
import scala.collection.mutable.ArrayBuffer
diff --git a/core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala b/core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala
index 5a62464..60822eb 100755
--- a/core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala
+++ b/core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala
@@ -22,7 +22,6 @@ import javax.security.auth.login.Configuration
import kafka.utils.{CoreUtils, Logging, TestUtils}
import org.junit.{After, AfterClass, Before, BeforeClass}
import org.junit.Assert._
-import org.scalatest.junit.JUnitSuite
import org.apache.kafka.common.security.JaasUtils
import org.apache.kafka.test.IntegrationTest
import org.junit.experimental.categories.Category
@@ -37,7 +36,7 @@ import org.apache.kafka.common.utils.Time
import org.apache.zookeeper.{WatchedEvent, Watcher, ZooKeeper}
@Category(Array(classOf[IntegrationTest]))
-abstract class ZooKeeperTestHarness extends JUnitSuite with Logging {
+abstract class ZooKeeperTestHarness extends Logging {
val zkConnectionTimeout = 10000
val zkSessionTimeout = 15000 // Allows us to avoid ZK session expiration due to GC up to 2/3 * 15000ms = 10 secs
diff --git a/core/src/test/scala/unit/kafka/zookeeper/ZooKeeperClientTest.scala b/core/src/test/scala/unit/kafka/zookeeper/ZooKeeperClientTest.scala
index a4b63e0..d500373 100644
--- a/core/src/test/scala/unit/kafka/zookeeper/ZooKeeperClientTest.scala
+++ b/core/src/test/scala/unit/kafka/zookeeper/ZooKeeperClientTest.scala
@@ -32,6 +32,7 @@ import org.apache.zookeeper.ZooKeeper.States
import org.apache.zookeeper.{CreateMode, WatchedEvent, ZooDefs}
import org.junit.Assert.{assertArrayEquals, assertEquals, assertFalse, assertTrue}
import org.junit.{After, Before, Test}
+import org.scalatest.Assertions.{fail, intercept}
import scala.collection.JavaConverters._
diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index 28e35f2..77298d6 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -51,17 +51,17 @@ versions += [
apacheda: "1.0.2",
apacheds: "2.0.0-M24",
argparse4j: "0.7.0",
- bcpkix: "1.60",
+ bcpkix: "1.61",
checkstyle: "8.20",
gradle: "5.4.1",
gradleVersionsPlugin: "0.21.0",
grgit: "3.1.1",
- httpclient: "4.5.7",
+ httpclient: "4.5.8",
easymock: "4.0.2",
jackson: "2.9.8",
jacoco: "0.8.3",
- jetty: "9.4.14.v20181114",
- jersey: "2.27",
+ jetty: "9.4.18.v20190429",
+ jersey: "2.28",
jmh: "1.21",
hamcrest: "2.1",
log4j: "1.2.17",
@@ -79,27 +79,27 @@ versions += [
kafka_11: "1.1.1",
kafka_20: "2.0.1",
kafka_21: "2.1.0",
- lz4: "1.5.0",
- mavenArtifact: "3.6.0",
+ lz4: "1.5.1",
+ mavenArtifact: "3.6.1",
metrics: "2.2.0",
- mockito: "2.23.4",
+ mockito: "2.27.0",
owaspDepCheckPlugin: "4.0.2",
- powermock: "2.0.0",
+ powermock: "2.0.2",
reflections: "0.9.11",
rocksDB: "5.15.10",
scalafmt: "1.5.1",
- scalatest: "3.0.5",
+ scalatest: "3.0.7",
scoverage: "1.3.1",
scoveragePlugin: "2.5.0",
shadowPlugin: "4.0.4",
- slf4j: "1.7.25",
- snappy: "1.1.7.2",
+ slf4j: "1.7.26",
+ snappy: "1.1.7.3",
spotbugs: "3.1.12",
spotbugsPlugin: "1.6.9",
spotlessPlugin: "3.23.0",
zkclient: "0.11",
- zookeeper: "3.4.13",
- zstd: "1.3.8-1"
+ zookeeper: "3.4.14",
+ zstd: "1.4.0-1"
]
libs += [
diff --git a/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/TopologyTest.scala b/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/TopologyTest.scala
index 3917552..a1c516b 100644
--- a/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/TopologyTest.scala
+++ b/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/TopologyTest.scala
@@ -50,14 +50,13 @@ import org.apache.kafka.streams.scala.kstream._
import org.apache.kafka.streams.{StreamsBuilder => StreamsBuilderJ, _}
import org.junit.Assert._
import org.junit._
-import org.scalatest.junit.JUnitSuite
import _root_.scala.collection.JavaConverters._
/**
* Test suite that verifies that the topology built by the Java and Scala APIs match.
*/
-class TopologyTest extends JUnitSuite {
+class TopologyTest {
private val inputTopic = "input-topic"
private val userClicksTopic = "user-clicks-topic"
diff --git a/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/WordCountTest.scala b/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/WordCountTest.scala
index bbc84f6..8980efd 100644
--- a/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/WordCountTest.scala
+++ b/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/WordCountTest.scala
@@ -22,7 +22,6 @@ package org.apache.kafka.streams.scala
import java.util.Properties
import java.util.regex.Pattern
-import org.scalatest.junit.JUnitSuite
import org.junit.Assert._
import org.junit._
import org.junit.rules.TemporaryFolder
@@ -48,7 +47,7 @@ import org.junit.experimental.categories.Category
* Hence the native Java API based version is more verbose.
*/
@Category(Array(classOf[IntegrationTest]))
-class WordCountTest extends JUnitSuite with WordCountTestData {
+class WordCountTest extends WordCountTestData {
private val privateCluster: EmbeddedKafkaCluster = new EmbeddedKafkaCluster(1)
diff --git a/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/utils/StreamToTableJoinScalaIntegrationTestBase.scala b/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/utils/StreamToTableJoinScalaIntegrationTestBase.scala
index baba5ea..c1464ad 100644
--- a/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/utils/StreamToTableJoinScalaIntegrationTestBase.scala
+++ b/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/utils/StreamToTableJoinScalaIntegrationTestBase.scala
@@ -28,14 +28,13 @@ import org.apache.kafka.test.{IntegrationTest, TestUtils}
import org.junit._
import org.junit.experimental.categories.Category
import org.junit.rules.TemporaryFolder
-import org.scalatest.junit.JUnitSuite
/**
* Test suite base that prepares Kafka cluster for stream-table joins in Kafka Streams
* <p>
*/
@Category(Array(classOf[IntegrationTest]))
-class StreamToTableJoinScalaIntegrationTestBase extends JUnitSuite with StreamToTableJoinTestData {
+class StreamToTableJoinScalaIntegrationTestBase extends StreamToTableJoinTestData {
private val privateCluster: EmbeddedKafkaCluster = new EmbeddedKafkaCluster(1)
diff --git a/tools/src/main/java/org/apache/kafka/trogdor/rest/JsonRestServer.java b/tools/src/main/java/org/apache/kafka/trogdor/rest/JsonRestServer.java
index 196ec82..cd5615f 100644
--- a/tools/src/main/java/org/apache/kafka/trogdor/rest/JsonRestServer.java
+++ b/tools/src/main/java/org/apache/kafka/trogdor/rest/JsonRestServer.java
@@ -26,7 +26,6 @@ import org.eclipse.jetty.server.Connector;
import org.eclipse.jetty.server.Handler;
import org.eclipse.jetty.server.Server;
import org.eclipse.jetty.server.ServerConnector;
-import org.eclipse.jetty.server.Slf4jRequestLog;
import org.eclipse.jetty.server.handler.DefaultHandler;
import org.eclipse.jetty.server.handler.HandlerCollection;
import org.eclipse.jetty.server.handler.RequestLogHandler;
@@ -85,6 +84,7 @@ public class JsonRestServer {
*
* @param resources The path handling resources to register.
*/
+ @SuppressWarnings("deprecation")
public void start(Object... resources) {
log.info("Starting REST server");
ResourceConfig resourceConfig = new ResourceConfig();
@@ -101,7 +101,8 @@ public class JsonRestServer {
context.addServlet(servletHolder, "/*");
RequestLogHandler requestLogHandler = new RequestLogHandler();
- Slf4jRequestLog requestLog = new Slf4jRequestLog();
+ // Use fully qualified name to avoid deprecation warning in import statement
+ org.eclipse.jetty.server.Slf4jRequestLog requestLog = new org.eclipse.jetty.server.Slf4jRequestLog();
requestLog.setLoggerName(JsonRestServer.class.getCanonicalName());
requestLog.setLogLatency(true);
requestLogHandler.setRequestLog(requestLog);