You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "chenyulin0719 (via GitHub)" <gi...@apache.org> on 2023/10/24 16:37:25 UTC
[PR] [YUNIKORN-2070] E2e tests for gang_scheduling failed due to containers init were OOM-Killed [yunikorn-k8shim]
chenyulin0719 opened a new pull request, #698:
URL: https://github.com/apache/yunikorn-k8shim/pull/698
### What is this PR for?
To prevent the OOM-Killed error in gang_scheduling e2e test.
This PR changed placeholder's memory limit from 10M to 20M.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
Need several trial run to check the solution is valid.
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2070
### How should this be tested?
Existing E2E test should pass, and no OOM-Killed error happened in gang_scheduling e2e test.
### Screenshots (if appropriate)
### Questions:
NA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2070] E2e tests for gang_scheduling failed due to containers init were OOM-Killed [yunikorn-k8shim]
Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 closed pull request #698: [YUNIKORN-2070] E2e tests for gang_scheduling failed due to containers init were OOM-Killed
URL: https://github.com/apache/yunikorn-k8shim/pull/698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2070] E2e tests for gang_scheduling failed due to containers init were OOM-Killed [yunikorn-k8shim]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #698:
URL: https://github.com/apache/yunikorn-k8shim/pull/698#issuecomment-1778293542
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#698](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (56b0c6c) into [master](https://app.codecov.io/gh/apache/yunikorn-k8shim/commit/d18f7c232df0652d08fa4960b6a6e28d8c0e6aee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d18f7c2) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #698 +/- ##
=======================================
Coverage 71.90% 71.90%
=======================================
Files 51 51
Lines 8098 8098
=======================================
Hits 5823 5823
Misses 2075 2075
Partials 200 200
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org