You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "johnny94 (via GitHub)" <gi...@apache.org> on 2025/05/30 08:42:07 UTC
[PR] KAFKA-19350 Don't propagate the error caused by CreateTopicPolicy to … [kafka]
johnny94 opened a new pull request, #19857:
URL: https://github.com/apache/kafka/pull/19857
…FatalFaultHandler
`CreateTopicPolicy#validate` may throw unexpected exception other than `PolicyViolationException`. We should handle this case as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19350 Don't propagate the error caused by CreateTopicPolicy to FatalFaultHandler [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19857:
URL: https://github.com/apache/kafka/pull/19857#discussion_r2134170355
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -871,6 +871,13 @@ private ApiError maybeCheckCreateTopicPolicy(Supplier<CreateTopicPolicy.RequestM
createTopicPolicy.get().validate(supplier.get());
} catch (PolicyViolationException e) {
return new ApiError(Errors.POLICY_VIOLATION, e.getMessage());
+ } catch (Throwable e) {
Review Comment:
Could you please add test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19350 Don't propagate the error caused by CreateTopicPolicy to FatalFaultHandler [kafka]
Posted by "johnny94 (via GitHub)" <gi...@apache.org>.
johnny94 commented on code in PR #19857:
URL: https://github.com/apache/kafka/pull/19857#discussion_r2152065446
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -871,6 +871,13 @@ private ApiError maybeCheckCreateTopicPolicy(Supplier<CreateTopicPolicy.RequestM
createTopicPolicy.get().validate(supplier.get());
} catch (PolicyViolationException e) {
return new ApiError(Errors.POLICY_VIOLATION, e.getMessage());
+ } catch (Throwable e) {
Review Comment:
Thanks for review. Added test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19350 Don't propagate the error caused by CreateTopicPolicy to FatalFaultHandler [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #19857:
URL: https://github.com/apache/kafka/pull/19857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org