[GitHub] [submarine] ByronHsu commented on a change in pull request #700: SUBMARINE-901. Tensorflow distributed training example with model management API

[GitBox <gi...@apache.org>]

ByronHsu commented on a change in pull request #700:
URL: https://github.com/apache/submarine/pull/700#discussion_r684558359



##########
File path: dev-support/examples/dp-tf/readme.md
##########
@@ -0,0 +1,23 @@
+# TF Distributed Example
+
+## Usage
+
+This is an easy example of how to track the metric and paramater in submarine-sdk. Basically, the sdk will detect which experiment and worker-id are you at, and log your data to the corresponding place.

Review comment:
       This should explain the function of tf code

##########
File path: dev-support/examples/dp-tf/readme.md
##########
@@ -0,0 +1,23 @@
+# TF Distributed Example

Review comment:
       Why the folder name is `dp-tf`?

##########
File path: dev-support/examples/nn-pytorch/model.py
##########
@@ -32,4 +32,4 @@ def forward(self, x):
 if __name__ == "__main__":
     client = ModelsClient()
     net = LinearNNModel()
-    client.log_model("simple-nn-model", net)

Review comment:
       The comments should be removed?

##########
File path: dev-support/examples/dp-tf/distribution.py
##########
@@ -0,0 +1,109 @@
+"""
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+"""
+
+from submarine import ModelsClient

Review comment:
       I think the name of file `distribution.py` is confusing. It could be changed to `dis-tf.py` or somewhat.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org