Re: [PR] [feature](iceberg catalog) support iceberg view query [doris]

["Copilot (via GitHub)" <gi...@apache.org>]

Copilot commented on code in PR #51376:
URL: https://github.com/apache/doris/pull/51376#discussion_r2115112982


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergMetadataOps.java:
##########
@@ -372,6 +389,48 @@ public Table loadTable(String dbName, String tblName) {
         }
     }
 
+    @Override
+    public boolean viewExists(String dbName, String viewName) {

Review Comment:
   The viewExists method always returns false regardless of the actual existence check. Capture and return the result from the preExecutionAuthenticator execute block to properly reflect whether the view exists.



##########
fe/fe-core/src/main/java/org/apache/doris/planner/IcebergTableSink.java:
##########
@@ -83,6 +86,9 @@ public void bindDataSink(Optional<InsertCommandContext> insertCtx)
             throws AnalysisException {
 
         TIcebergTableSink tSink = new TIcebergTableSink();
+        if (targetTable.isView()) {
+            throw new UnsupportedOperationException("IcebergTableSink does not support view");
+        }

Review Comment:
   [nitpick] The view check is performed both in the constructor and again in bindDataSink. Consider centralizing the view validation in the constructor to avoid duplicate checks.
   ```suggestion
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org