You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/19 21:04:44 UTC
[GitHub] [spark] grundprinzip opened a new pull request, #38726: [SPARK-41203] Support Dataframe.tansform in Python client.
grundprinzip opened a new pull request, #38726:
URL: https://github.com/apache/spark/pull/38726
### What changes were proposed in this pull request?
Support client-side transformations of the DataFrame.
### Why are the changes needed?
Compatibility
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38726: [SPARK-41203] [CONNECT] Support Dataframe.tansform in Python client.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38726: [SPARK-41203] [CONNECT] Support Dataframe.tansform in Python client.
URL: https://github.com/apache/spark/pull/38726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38726: [SPARK-41203] [CONNECT] Support Dataframe.tansform in Python client.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38726:
URL: https://github.com/apache/spark/pull/38726#issuecomment-1321296180
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38726: [SPARK-41203] [CONNECT] Support Dataframe.tansform in Python client.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38726:
URL: https://github.com/apache/spark/pull/38726#issuecomment-1322444276
Late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38726: [SPARK-41203] [CONNECT] Support Dataframe.tansform in Python client.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38726:
URL: https://github.com/apache/spark/pull/38726#issuecomment-1321183941
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on pull request #38726: [SPARK-41203] [CONNECT] Support Dataframe.tansform in Python client.
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on PR #38726:
URL: https://github.com/apache/spark/pull/38726#issuecomment-1321065412
> Please always add `[CONNECT]` in PR title so it is easy to filter out all connect commits through `git log`.
Thanks. I missed it. Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #38726: [SPARK-41203] [CONNECT] Support Dataframe.tansform in Python client.
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #38726:
URL: https://github.com/apache/spark/pull/38726#discussion_r1027276398
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -756,6 +757,62 @@ def schema(self) -> StructType:
else:
return self._schema
+ def transform(self, func: Callable[..., "DataFrame"], *args: Any, **kwargs: Any) -> "DataFrame":
+ """Returns a new :class:`DataFrame`. Concise syntax for chaining custom transformations.
+
+ .. versionadded:: 3.0.0
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38726: [SPARK-41203] Support Dataframe.tansform in Python client.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38726:
URL: https://github.com/apache/spark/pull/38726#issuecomment-1321029056
Please always add `[CONNECT]` in PR title so it is easy to filter out all connect commits through `git log`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38726: [SPARK-41203] [CONNECT] Support Dataframe.tansform in Python client.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38726:
URL: https://github.com/apache/spark/pull/38726#discussion_r1027251817
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -756,6 +757,62 @@ def schema(self) -> StructType:
else:
return self._schema
+ def transform(self, func: Callable[..., "DataFrame"], *args: Any, **kwargs: Any) -> "DataFrame":
+ """Returns a new :class:`DataFrame`. Concise syntax for chaining custom transformations.
+
+ .. versionadded:: 3.0.0
+
+ Parameters
+ ----------
+ func : function
+ a function that takes and returns a :class:`DataFrame`.
+ *args
+ Positional arguments to pass to func.
+
+ .. versionadded:: 3.3.0
Review Comment:
```suggestion
```
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -756,6 +757,62 @@ def schema(self) -> StructType:
else:
return self._schema
+ def transform(self, func: Callable[..., "DataFrame"], *args: Any, **kwargs: Any) -> "DataFrame":
+ """Returns a new :class:`DataFrame`. Concise syntax for chaining custom transformations.
+
+ .. versionadded:: 3.0.0
+
+ Parameters
+ ----------
+ func : function
+ a function that takes and returns a :class:`DataFrame`.
+ *args
+ Positional arguments to pass to func.
+
+ .. versionadded:: 3.3.0
+ **kwargs
+ Keyword arguments to pass to func.
+
+ .. versionadded:: 3.3.0
Review Comment:
```suggestion
```
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -756,6 +757,62 @@ def schema(self) -> StructType:
else:
return self._schema
+ def transform(self, func: Callable[..., "DataFrame"], *args: Any, **kwargs: Any) -> "DataFrame":
+ """Returns a new :class:`DataFrame`. Concise syntax for chaining custom transformations.
+
+ .. versionadded:: 3.0.0
Review Comment:
```suggestion
.. versionadded:: 3.3.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org