(juneau) 11/29: Use Shorts.cp() for defensive list copy in MilestoneService

[ja...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jamesbognar pushed a commit to branch juneau-release-manager
in repository https://gitbox.apache.org/repos/asf/juneau.git

commit 0a8d3dd3284ea900c04b4868cb06e131bba1de8b
Author: James Bognar <ja...@apache.org>
AuthorDate: Wed Aug 19 13:08:30 2026 -0400

    Use Shorts.cp() for defensive list copy in MilestoneService
    
    Adopt juneau's Shorts.cp() collection alias instead of ArrayList
    construction when copying the incoming PR list before sorting.
---
 .../java/org/apache/juneau/releng/milestone/MilestoneService.java     | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/juneau/releng/milestone/MilestoneService.java b/src/main/java/org/apache/juneau/releng/milestone/MilestoneService.java
index dbb11a5435..079733602e 100644
--- a/src/main/java/org/apache/juneau/releng/milestone/MilestoneService.java
+++ b/src/main/java/org/apache/juneau/releng/milestone/MilestoneService.java
@@ -17,6 +17,8 @@
 
 package org.apache.juneau.releng.milestone;
 
+import static org.apache.juneau.commons.utils.Shorts.*;
+
 import java.util.ArrayList;
 import java.util.LinkedHashMap;
 import java.util.List;
@@ -39,7 +41,7 @@ public class MilestoneService {
 	/** Groups Dependabot bump PRs into one {@link ChangelogEntry} per dependency, sorted by dependency. */
 	public List<ChangelogEntry> generateChanges(List<PullRequest> prs) {
 		// Preserve encounter order within a group, but iterate PRs by ascending number for stable from/to + refs.
-		var sorted = new ArrayList<>(prs);
+		var sorted = cp(prs);
 		sorted.sort((a, b) -> Integer.compare(a.number, b.number));
 
 		var groups = new LinkedHashMap<String, ChangelogEntry.Builder>();