You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/08 22:35:47 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #3049: Split out arrow-json (#3044)
tustvold opened a new pull request, #3049:
URL: https://github.com/apache/arrow-rs/pull/3049
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of #3044
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3049: Split out arrow-json (#3044)
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3049:
URL: https://github.com/apache/arrow-rs/pull/3049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3049: Split out arrow-json (#3044)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3049:
URL: https://github.com/apache/arrow-rs/pull/3049#issuecomment-1308222252
Benchmark runs are scheduled for baseline = fe3318bba24abfe572fa037a0b8805a15bdf5c45 and contender = 8d75101e3773e5d74c8d5cda356a9eaba34acf90. 8d75101e3773e5d74c8d5cda356a9eaba34acf90 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/026ce490172d497bbd775912256325b6...6ac7e595f8ad4f60b96138347515c548/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/32b72801fb7f4349991690f2db9ae849...5aaa3d6250434a66a1d03362e2065441/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fd6f267e8a2645b1a1a1ac063e0154c6...2f9b93a3bb324a2fa34a2f9180ab539e/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/79a57b222eed43ab99836a276850754c...a73a03335deb45b6a4b4c34b31927533/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3049: Split out arrow-json (#3044)
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3049:
URL: https://github.com/apache/arrow-rs/pull/3049#discussion_r1017192984
##########
arrow-json/src/reader.rs:
##########
@@ -2076,12 +2078,8 @@ mod tests {
#[test]
fn test_invalid_json_infer_schema() {
- let re = infer_json_schema_from_seekable(
- &mut BufReader::new(
- File::open("test/data/uk_cities_with_headers.csv").unwrap(),
- ),
- None,
- );
Review Comment:
We drop this file?
##########
arrow-json/src/reader.rs:
##########
@@ -23,12 +23,11 @@
//!
//! Example:
//!
-//! ```
-//! use arrow::datatypes::{DataType, Field, Schema};
-//! use arrow::json;
-//! use std::fs::File;
-//! use std::io::BufReader;
-//! use std::sync::Arc;
+//! ```no_run
Review Comment:
Wondering why change to `no_run`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3049: Split out arrow-json (#3044)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3049:
URL: https://github.com/apache/arrow-rs/pull/3049#discussion_r1017187866
##########
arrow/Cargo.toml:
##########
@@ -64,9 +63,8 @@ packed_simd = { version = "0.3", default-features = false, optional = true, pack
chrono = { version = "0.4", default-features = false, features = ["clock"] }
comfy-table = { version = "6.0", optional = true, default-features = false }
pyo3 = { version = "0.17", default-features = false, optional = true }
-lexical-core = { version = "^0.8", default-features = false, features = ["write-integers", "write-floats", "parse-integers", "parse-floats"] }
multiversion = { version = "0.6.1", default-features = false }
-bitflags = { version = "1.2.1", default-features = false }
Review Comment:
These are just drive-by-fixes. They are no longer needed by the top-level crate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3049: Split out arrow-json (#3044)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3049:
URL: https://github.com/apache/arrow-rs/pull/3049#discussion_r1017198944
##########
arrow-json/src/reader.rs:
##########
@@ -2076,12 +2078,8 @@ mod tests {
#[test]
fn test_invalid_json_infer_schema() {
- let re = infer_json_schema_from_seekable(
- &mut BufReader::new(
- File::open("test/data/uk_cities_with_headers.csv").unwrap(),
- ),
- None,
- );
Review Comment:
No it just isn't part of the arrow-json test data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3049: Split out arrow-json (#3044)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3049:
URL: https://github.com/apache/arrow-rs/pull/3049#discussion_r1017198653
##########
arrow-json/src/reader.rs:
##########
@@ -23,12 +23,11 @@
//!
//! Example:
//!
-//! ```
-//! use arrow::datatypes::{DataType, Field, Schema};
-//! use arrow::json;
-//! use std::fs::File;
-//! use std::io::BufReader;
-//! use std::sync::Arc;
+//! ```no_run
Review Comment:
Oops need to revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org