You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/07/02 03:10:46 UTC

[GitHub] [hudi] yanghua commented on a change in pull request #1779: [HUDI-1062]Remove unnecessary maxEvent check and add some log in KafkaOffsetGen

yanghua commented on a change in pull request #1779:
URL: https://github.com/apache/hudi/pull/1779#discussion_r448723699



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -202,9 +202,14 @@ public KafkaOffsetGen(TypedProperties props) {
     // Come up with final set of OffsetRanges to read (account for new partitions, limit number of events)
     long maxEventsToReadFromKafka = props.getLong(Config.MAX_EVENTS_FROM_KAFKA_SOURCE_PROP,
         Config.maxEventsFromKafkaSource);
-    maxEventsToReadFromKafka = (maxEventsToReadFromKafka == Long.MAX_VALUE || maxEventsToReadFromKafka == Integer.MAX_VALUE)

Review comment:
       Why do you remove this check statement? If the user sets the value of `Config.MAX_EVENTS_FROM_KAFKA_SOURCE_PROP` to `Long.MAX_VALUE`. How do you reset it to `Config.maxEventsFromKafkaSource`(5000000)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org