[GitHub] [ratis] qian0817 commented on a diff in pull request #865: RATIS-1824. Membership change may fail when a Listener is present in the cluster.

["qian0817 (via GitHub)" <gi...@apache.org>]

qian0817 commented on code in PR #865:
URL: https://github.com/apache/ratis/pull/865#discussion_r1152653341


##########
ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderStateImpl.java:
##########
@@ -364,7 +364,7 @@ private List<FollowerInfo> getFollowerInfos(PeerConfiguration peers) {
 
     final Collection<RaftPeer> listeners = conf.getAllPeers(RaftPeerRole.LISTENER);
     if (!listeners.isEmpty()) {
-      addSenders(listeners, placeHolderIndex, false);
+      addSenders(listeners, placeHolderIndex, true);

Review Comment:
   Do you know why it was named attendVote before? This value looks irrelevant to voting and should indicate whether a newly joined node is in the middle of a membership change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org