You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/15 09:32:11 UTC

[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #4610: [ISSUE #4609] Fix ambiguous exception

RongtongJin commented on code in PR #4610:
URL: https://github.com/apache/rocketmq/pull/4610#discussion_r921991173


##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -1141,7 +1141,7 @@ private SendResult sendSelectImpl(
 
             long costTime = System.currentTimeMillis() - beginStartTime;
             if (timeout < costTime) {
-                throw new RemotingTooMuchRequestException("sendSelectImpl call timeout");
+                throw new RemotingTimeoutException("sendSelectImpl call timeout");

Review Comment:
   I think neither of the two exceptions is appropriate here. But RemotingTimeoutException is more suitable than RemotingTooMuchRequestException, so I agree with this replacement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org