[GitHub] [hadoop] mukul1987 commented on a change in pull request #1870: HDFS-15201 SnapshotCounter hits MaxSnapshotID limit

[GitBox <gi...@apache.org>]

mukul1987 commented on a change in pull request #1870: HDFS-15201 SnapshotCounter hits MaxSnapshotID limit
URL: https://github.com/apache/hadoop/pull/1870#discussion_r386768106
 
 

 ##########
 File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java
 ##########
 @@ -541,8 +541,8 @@ public void clearSnapshottableDirs() {
    *
    * @return maximum allowable snapshot ID.
    */
-   public int getMaxSnapshotID() {
-    return ((1 << SNAPSHOT_ID_BIT_WIDTH) - 1);
+  public int getMaxSnapshotID() {
+    return (1 << SNAPSHOT_ID_BIT_WIDTH);
 
 Review comment:
   I think we can still leave this as max index -1, as we would only have one snapshot id here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org