You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/06/22 10:33:32 UTC
[GitHub] [skywalking] lkxiaolou commented on a change in pull request #2930:
One more time for heigher performance
lkxiaolou commented on a change in pull request #2930: One more time for heigher performance
URL: https://github.com/apache/skywalking/pull/2930#discussion_r296441680
##########
File path: apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/common/AtomicRangeInteger.java
##########
@@ -18,54 +18,106 @@
package org.apache.skywalking.apm.commons.datacarrier.common;
+import sun.misc.Unsafe;
Review comment:
Yes, Unsafe maybe change in the future, I have changed the code, just a small change on the v2.
This implementation also used the L1 cache, so it's very fast.
Disable the false-sharing reference from the Disruptor, Disruptor's Sequence also use placeholders to full a cache line so that the increase value changes doesn't affect others cache.
see [Sequence](https://github.com/LMAX-Exchange/disruptor/blob/master/src/main/java/com/lmax/disruptor/Sequence.java)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services