[GitHub] [sling-org-apache-sling-distribution-journal] jose-correia commented on a diff in pull request #109: Allow to configure the PackageMessageFactory using a configurationPid

[GitBox <gi...@apache.org>]

jose-correia commented on code in PR #109:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/109#discussion_r880959476


##########
src/main/java/org/apache/sling/distribution/journal/impl/publisher/PackageMessageFactory.java:
##########
@@ -51,11 +51,17 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-@Component(service = PackageMessageFactory.class)
-@Designate(ocd = PackageFactoryConfiguration.class)
+@Component(
+        service = PackageMessageFactory.class,
+        immediate = true,
+        configurationPid = PackageMessageFactory.FACTORY_PID
+)
+@Designate(ocd = PackageFactoryConfiguration.class, factory = true)

Review Comment:
   @tmaret At first, I was not sure of the impact of this `factory=True`. After looking deeper, it's true that we don't need this since we will only ever need one instance of the `PackageFactoryConfiguration`
   
   Will remove 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org