[jira] [Commented] (OAK-7340) Remove SecurityProviderImpl usage from tests

["Alex Deparvu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398773#comment-16398773 ] 

Alex Deparvu commented on OAK-7340:
-----------------------------------

Wip branch https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:spb2

- moved the SecurityProviderBuilder from tests to the main bundle
- left a SecurityProviderHelper in the tests for customisation of the SecurityProvider, did not want to expose this code by default (only relevant for tests)
- removed visibility of the constructor 'new SecurityProviderBuilder()' is now 'SecurityProviderBuilder.newBuilder()', had to change a few tests
- the SecurityProviderRegistration is wired through the builder
- tests also use the builder

the only module remaining that still uses the old impl is oak-upgrade and that is tracked via a dedicated issue.

[~anchela] could you take a look?

> Remove SecurityProviderImpl usage from tests
> --------------------------------------------
>
>                 Key: OAK-7340
>                 URL: https://issues.apache.org/jira/browse/OAK-7340
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, security
>            Reporter: Alex Deparvu
>            Assignee: Alex Deparvu
>            Priority: Major
>             Fix For: 1.9.0
>
>
> Remove usage of {{SecurityProviderImpl}} from tests so we can eventually drop it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)