You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "CalvinKirs (via GitHub)" <gi...@apache.org> on 2026/05/28 03:40:27 UTC
[PR] [improvement](fe) Enhance FE meta service request validation [doris]
CalvinKirs opened a new pull request, #63782:
URL: https://github.com/apache/doris/pull/63782
### What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary: FE meta service endpoints are used for FE-to-FE metadata synchronization and coordination. This PR enhances internal request validation by carrying the cluster token on FE meta requests and validating it on the receiver side. It also adds a temporary compatibility switch for rolling upgrades from FE nodes that do not send the token yet.
### Release note
FE meta service internal requests now validate the cluster token by default. During rolling upgrades from older versions, set `enable_meta_service_legacy_node_ident_auth=true` temporarily on upgraded FEs if old FEs still need to call these endpoints without token headers. Disable it after all FEs are upgraded. The `/dump` endpoint now always runs the HTTP user check, and `/put` only accepts the configured FE HTTP port.
### Check List (For Author)
- Test: Unit Test, Manual test
- `./run-fe-ut.sh --run org.apache.doris.httpv2.meta.MetaServiceTest,org.apache.doris.common.util.HttpURLUtilTest`
- `mvn -pl fe-core -am -DskipUT=false -Dcheckstyle.skip=true -DfailIfNoTests=false -Dmaven.build.cache.enabled=false -Dtest=org.apache.doris.httpv2.meta.MetaServiceTest,org.apache.doris.common.util.HttpURLUtilTest test`
- Manual: started FE on HTTP 26030 and query port 27030; verified no-token FE meta request returns business code 401, and token-carrying `/image?version=155292` returns HTTP 200.
- Behavior changed: Yes. FE meta service endpoints require the cluster token by default; legacy header-only node identity fallback is available only when `enable_meta_service_legacy_node_ident_auth=true`. `/dump` now always runs the HTTP user check. `/put` rejects ports other than `Config.http_port`.
- Does this need documentation: Yes. Document rolling-upgrade use of `enable_meta_service_legacy_node_ident_auth` and cluster-token validation for FE meta service requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4829066038
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/102)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63782_a6cd5641810a53acde03e78545954f473b9c5acd_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63782_a6cd5641810a53acde03e78545954f473b9c5acd_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4561167508
<details>
<summary>TPC-DS: <b>Total hot run time: 171487 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a6cd5641810a53acde03e78545954f473b9c5acd, data reload: false
query5 4339 666 515 515
query6 325 229 202 202
query7 4243 589 305 305
query8 324 237 226 226
query9 8808 4066 4013 4013
query10 467 347 302 302
query11 5796 2489 2263 2263
query12 182 130 124 124
query13 1290 623 436 436
query14 6068 5442 5139 5139
query14_1 4498 4466 4475 4466
query15 222 210 186 186
query16 1003 464 360 360
query17 1162 746 608 608
query18 2444 512 374 374
query19 224 207 176 176
query20 138 144 131 131
query21 214 140 118 118
query22 13671 13498 13355 13355
query23 17363 16507 16283 16283
query23_1 16383 16254 16275 16254
query24 7425 1783 1315 1315
query24_1 1346 1312 1335 1312
query25 586 507 441 441
query26 1329 335 177 177
query27 2695 566 348 348
query28 4398 2016 2043 2016
query29 1079 648 514 514
query30 309 236 202 202
query31 1112 1090 963 963
query32 101 81 74 74
query33 573 388 313 313
query34 1181 1189 668 668
query35 757 819 727 727
query36 1411 1420 1256 1256
query37 147 103 90 90
query38 3199 3136 3056 3056
query39 914 926 939 926
query39_1 881 865 877 865
query40 230 146 124 124
query41 66 62 60 60
query42 108 107 115 107
query43 322 329 286 286
query44
query45 211 205 200 200
query46 1125 1176 728 728
query47 2407 2337 2273 2273
query48 405 409 306 306
query49 622 487 402 402
query50 962 340 247 247
query51 4316 4349 4257 4257
query52 100 103 92 92
query53 251 287 202 202
query54 301 276 249 249
query55 93 89 88 88
query56 309 296 295 295
query57 1428 1414 1343 1343
query58 319 259 257 257
query59 1557 1638 1463 1463
query60 320 315 308 308
query61 173 155 152 152
query62 687 645 574 574
query63 242 197 201 197
query64 2481 789 636 636
query65
query66 1734 471 368 368
query67 29717 29659 29512 29512
query68
query69 461 338 306 306
query70 997 1017 996 996
query71 300 266 300 266
query72 3001 2718 2443 2443
query73 806 755 419 419
query74 5107 4945 4805 4805
query75 2692 2596 2278 2278
query76 2312 1136 784 784
query77 406 431 338 338
query78 12342 12470 11887 11887
query79 1515 1092 729 729
query80 1209 569 456 456
query81 501 285 236 236
query82 1355 155 128 128
query83 368 277 245 245
query84 264 140 112 112
query85 927 529 454 454
query86 465 333 333 333
query87 3420 3360 3229 3229
query88 3617 2738 2724 2724
query89 459 384 340 340
query90 1801 185 180 180
query91 181 165 139 139
query92 79 83 76 76
query93 1580 1444 813 813
query94 633 357 286 286
query95 693 370 334 334
query96 1031 793 374 374
query97 2748 2724 2642 2642
query98 243 236 229 229
query99 1174 1164 1027 1027
Total cold run time: 254822 ms
Total hot run time: 171487 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4957569113
Superseded by #65551 — rebased onto latest master and reworked to a cleaner, switch-free design (a dedicated `fe_meta_auth_token` config replaces `enable_meta_service_legacy_node_ident_auth`; token check is additive on top of the node-host check). Closing in favor of #65551.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4862061438
<details>
<summary>TPC-DS: <b>Total hot run time: 173060 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 06f94024cd09609bdccae9d87f40f5dd47a7715d, data reload: false
query5 4336 635 508 508
query6 468 229 200 200
query7 4853 606 340 340
query8 337 193 178 178
query9 8766 4050 4019 4019
query10 467 326 303 303
query11 5936 2342 2119 2119
query12 163 101 104 101
query13 1276 613 408 408
query14 6261 5261 4951 4951
query14_1 4291 4265 4264 4264
query15 204 200 178 178
query16 1015 470 449 449
query17 1102 701 559 559
query18 2422 463 333 333
query19 208 182 159 159
query20 107 106 104 104
query21 226 163 130 130
query22 13560 13649 13387 13387
query23 17409 16480 16178 16178
query23_1 16234 16319 16386 16319
query24 7609 1752 1328 1328
query24_1 1320 1340 1294 1294
query25 581 489 399 399
query26 1347 359 213 213
query27 2585 586 383 383
query28 4530 2021 2019 2019
query29 1109 646 524 524
query30 342 274 228 228
query31 1117 1096 980 980
query32 106 62 64 62
query33 542 331 270 270
query34 1178 1171 631 631
query35 768 782 687 687
query36 1419 1458 1243 1243
query37 155 113 99 99
query38 1861 1712 1652 1652
query39 934 919 899 899
query39_1 876 903 882 882
query40 248 167 146 146
query41 71 69 69 69
query42 97 94 90 90
query43 325 326 282 282
query44 1419 778 769 769
query45 220 189 187 187
query46 1042 1245 779 779
query47 2367 2359 2211 2211
query48 401 425 304 304
query49 580 420 325 325
query50 1058 456 321 321
query51 4498 4427 4355 4355
query52 88 86 81 81
query53 270 269 207 207
query54 289 226 219 219
query55 74 77 82 77
query56 342 317 294 294
query57 1443 1446 1341 1341
query58 292 258 260 258
query59 1584 1690 1419 1419
query60 293 264 254 254
query61 150 149 150 149
query62 690 647 592 592
query63 234 204 213 204
query64 2545 775 626 626
query65 4868 4809 4748 4748
query66 1832 512 386 386
query67 29503 29549 29388 29388
query68 3020 1659 925 925
query69 413 305 259 259
query70 1065 931 955 931
query71 355 328 307 307
query72 2978 2590 2306 2306
query73 893 788 438 438
query74 5136 4981 4800 4800
query75 2631 2588 2212 2212
query76 2329 1162 775 775
query77 351 390 280 280
query78 12456 12481 11844 11844
query79 1357 1145 749 749
query80 668 537 458 458
query81 450 328 283 283
query82 565 160 121 121
query83 396 326 286 286
query84 272 165 130 130
query85 912 612 503 503
query86 373 304 281 281
query87 1825 1832 1763 1763
query88 3698 2766 2799 2766
query89 458 416 358 358
query90 1949 205 183 183
query91 197 196 162 162
query92 63 59 56 56
query93 1534 1623 967 967
query94 544 370 313 313
query95 790 600 467 467
query96 1028 829 335 335
query97 2699 2695 2567 2567
query98 218 205 204 204
query99 1206 1140 1028 1028
Total cold run time: 258143 ms
Total hot run time: 173060 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4862083679
<details>
<summary>ClickBench: <b>Total hot run time: 25.12 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 06f94024cd09609bdccae9d87f40f5dd47a7715d, data reload: false
query1 0.01 0.00 0.01
query2 0.10 0.05 0.04
query3 0.26 0.14 0.14
query4 1.61 0.13 0.14
query5 0.23 0.23 0.22
query6 1.27 1.09 1.12
query7 0.04 0.01 0.00
query8 0.06 0.04 0.04
query9 0.38 0.31 0.30
query10 0.55 0.56 0.54
query11 0.20 0.14 0.15
query12 0.20 0.14 0.14
query13 0.46 0.46 0.46
query14 1.00 1.02 1.00
query15 0.61 0.59 0.59
query16 0.35 0.32 0.33
query17 1.06 1.06 1.15
query18 0.23 0.21 0.21
query19 2.01 1.88 1.91
query20 0.02 0.02 0.01
query21 15.43 0.23 0.13
query22 4.71 0.05 0.06
query23 16.12 0.30 0.12
query24 3.03 0.42 0.33
query25 0.11 0.05 0.06
query26 0.75 0.21 0.14
query27 0.04 0.04 0.04
query28 3.54 0.98 0.51
query29 12.50 4.28 3.45
query30 0.28 0.15 0.15
query31 2.76 0.60 0.31
query32 3.22 0.60 0.48
query33 3.24 3.24 3.19
query34 15.51 4.27 3.53
query35 3.53 3.51 3.59
query36 0.56 0.42 0.42
query37 0.09 0.07 0.06
query38 0.05 0.04 0.04
query39 0.04 0.03 0.03
query40 0.18 0.17 0.17
query41 0.08 0.03 0.03
query42 0.03 0.03 0.03
query43 0.04 0.04 0.04
Total cold run time: 96.49 s
Total hot run time: 25.12 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4561086680
# FE UT Coverage Report
Increment line coverage ` 80.56% (29/36)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63782_a6cd5641810a53acde03e78545954f473b9c5acd/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63782_a6cd5641810a53acde03e78545954f473b9c5acd/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs closed pull request #63782: [improvement](fe) Enhance FE meta service request validation
URL: https://github.com/apache/doris/pull/63782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4861484973
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4561428608
# FE Regression Coverage Report
Increment line coverage ` 27.12% (16/59)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63782_a6cd5641810a53acde03e78545954f473b9c5acd_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63782_a6cd5641810a53acde03e78545954f473b9c5acd_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4560774079
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs closed pull request #63782: [improvement](fe) Enhance FE meta service request validation
URL: https://github.com/apache/doris/pull/63782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4560654355
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4561117837
<details>
<summary>TPC-H: <b>Total hot run time: 31382 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a6cd5641810a53acde03e78545954f473b9c5acd, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17763 4019 3977 3977
q2 q3 10844 1387 800 800
q4 4688 479 342 342
q5 7603 2291 2165 2165
q6 340 174 143 143
q7 926 790 650 650
q8 9370 1728 1578 1578
q9 6907 4931 5037 4931
q10 6430 2237 1888 1888
q11 442 269 236 236
q12 682 426 286 286
q13 18272 3739 2743 2743
q14 269 255 234 234
q15 q16 823 778 716 716
q17 945 930 980 930
q18 6938 5841 5485 5485
q19 1166 1392 1042 1042
q20 552 403 269 269
q21 5904 2692 2659 2659
q22 457 391 308 308
Total cold run time: 101321 ms
Total hot run time: 31382 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4764 4666 4876 4666
q2 q3 4875 5315 4676 4676
q4 2135 2155 1382 1382
q5 4844 4755 4680 4680
q6 230 175 129 129
q7 1820 1687 1613 1613
q8 2433 1999 1918 1918
q9 7423 7403 7352 7352
q10 4757 4670 4247 4247
q11 550 380 346 346
q12 726 742 521 521
q13 3023 3359 2808 2808
q14 262 282 244 244
q15 q16 674 705 613 613
q17 1257 1245 1236 1236
q18 7386 6975 6708 6708
q19 1134 1113 1132 1113
q20 2204 2208 1928 1928
q21 5229 4610 4377 4377
q22 515 458 417 417
Total cold run time: 56241 ms
Total hot run time: 50974 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4828306468
run nonConcurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4862719244
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/99)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63782_06f94024cd09609bdccae9d87f40f5dd47a7715d_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63782_06f94024cd09609bdccae9d87f40f5dd47a7715d_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](fe) Enhance FE meta service request validation [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63782:
URL: https://github.com/apache/doris/pull/63782#issuecomment-4862006047
<details>
<summary>TPC-H: <b>Total hot run time: 29881 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 06f94024cd09609bdccae9d87f40f5dd47a7715d, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17592 3981 4005 3981
q2 2038 316 196 196
q3 10306 1434 815 815
q4 4700 462 343 343
q5 7658 851 582 582
q6 203 164 134 134
q7 781 826 621 621
q8 10332 1617 1583 1583
q9 6207 4489 4446 4446
q10 6766 1824 1535 1535
q11 521 354 327 327
q12 735 575 446 446
q13 18102 3414 2718 2718
q14 262 267 239 239
q15 q16 794 787 716 716
q17 998 1031 1047 1031
q18 6963 5841 5810 5810
q19 1170 1368 1102 1102
q20 737 633 514 514
q21 5780 2679 2443 2443
q22 437 356 299 299
Total cold run time: 103082 ms
Total hot run time: 29881 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4342 4257 4264 4257
q2 294 314 207 207
q3 4643 4906 4394 4394
q4 2086 2175 1381 1381
q5 4502 4345 4355 4345
q6 232 178 127 127
q7 2202 1924 1563 1563
q8 2555 2148 2132 2132
q9 7959 7823 7844 7823
q10 4738 4738 4303 4303
q11 584 523 381 381
q12 735 783 557 557
q13 3197 3602 2896 2896
q14 305 292 263 263
q15 q16 702 743 657 657
q17 1340 1324 1352 1324
q18 8310 7457 6901 6901
q19 1174 1129 1100 1100
q20 2214 2203 1938 1938
q21 5309 4556 4408 4408
q22 524 463 412 412
Total cold run time: 57947 ms
Total hot run time: 51369 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org