You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/07/16 08:09:25 UTC

Review Request 23544: Fixed a bug in port mapping metrics.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23544/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos-git


Description
-------

Made 'Metrics' a nested class in PortMappingIsolatorProcess. Also, made some helper function members of PortMappingIsolatorProcess so that they can access 'metrics' variable.

No other code change, mainly code movement.


Diffs
-----

  src/slave/containerizer/isolators/network/port_mapping.hpp 465d4a2 
  src/slave/containerizer/isolators/network/port_mapping.cpp 03fca2b 

Diff: https://reviews.apache.org/r/23544/diff/


Testing
-------

sudo make check

Also, I've tested it in our testing cluster.


Thanks,

Jie Yu

Re: Review Request 23544: Fixed a bug in port mapping metrics.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23544/#review48072
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On July 16, 2014, 6:09 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23544/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 6:09 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Made 'Metrics' a nested class in PortMappingIsolatorProcess. Also, made some helper function members of PortMappingIsolatorProcess so that they can access 'metrics' variable.
> 
> No other code change, mainly code movement.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 465d4a2 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 03fca2b 
> 
> Diff: https://reviews.apache.org/r/23544/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> Also, I've tested it in our testing cluster.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>