You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ustcweizhou <gi...@git.apache.org> on 2015/08/27 16:33:34 UTC
[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/757
Fix schema-421to430.sql issue after MariaDB upgrade
@remibergsma @wido Can you test it?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ustcweizhou/cloudstack MariaDB-crash
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/757.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #757
----
commit 99786516d7eb25fcf2e971bc3d2e7532a3a39b1f
Author: Wei Zhou <w....@tech.leaseweb.com>
Date: 2015-08-27T14:21:22Z
Fix schema-421to430.sql issue after MariaDB upgrade
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/757#issuecomment-135661617
Tested on Ubuntu 12.04 with mysql 5.5.41-0ubuntu0.12.04.1-log, it works .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/757#issuecomment-135454714
Assuming the tests will pass: LGTM
What I tested:
- the new query has the same result as the old ones
- the build now works again on CentOS 7 using MariaDB 5.5.44 (that failed since I upgraded from 5.5.41)
In general, the query is much better anyway I'd say. Thanks @ustcweizhou !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/757#issuecomment-135519152
Tested CentOS 6 which has MySQL 5.1 and it works fine. The other versions I don't have at hand now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/757#issuecomment-135453825
description of the issue:
http://markmail.org/message/7isvqsur2preppvl
http://markmail.org/message/t47bdpkhg6j4hhlb
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/757#issuecomment-135503642
I guess we simply need to test this for mysql 5.1.x, 5.5.x, 5.6.x; once it runs we can merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/757
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Fix schema-421to430.sql issue after Maria...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/757#issuecomment-135658100
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---