You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Andrew Sherman (Code Review)" <ge...@cloudera.org> on 2023/04/06 17:10:00 UTC
[Impala-ASF-CR] IMPALA-12050: Exclude kryo-shaded from the Java build
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19707
Change subject: IMPALA-12050: Exclude kryo-shaded from the Java build
......................................................................
IMPALA-12050: Exclude kryo-shaded from the Java build
Kryo is a serialization library that is brought in by Apache Hudi. It is
not used by Impala at runtime when running tests that use Hudi
(hudi-parquet.test).
TESTING
- Exhaustive tests ran clean
- Verified kryo-shaded is no longer present in dependencies.
Change-Id: I57436be139d56fb9f028a2cdeab412cc60631a06
---
M fe/pom.xml
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/19707/1
--
To view, visit http://gerrit.cloudera.org:8080/19707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I57436be139d56fb9f028a2cdeab412cc60631a06
Gerrit-Change-Number: 19707
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
[Impala-ASF-CR] IMPALA-12050: Exclude kryo-shaded from the Java build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19707 )
Change subject: IMPALA-12050: Exclude kryo-shaded from the Java build
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12759/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57436be139d56fb9f028a2cdeab412cc60631a06
Gerrit-Change-Number: 19707
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 17:30:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12050: Exclude kryo-shaded from the Java build
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19707 )
Change subject: IMPALA-12050: Exclude kryo-shaded from the Java build
......................................................................
Patch Set 1: Code-Review+2
I took a look at Hudi code to see if this is used. It definitely is used in their code for serialization (SerializationUtils.java), but I can't tell if Impala could ever hit the cases that use that serialization.
The latest Hudi seems to still use the same version of Kryo, so we can't get out of this by upgrading.
I think we can go ahead with this.
--
To view, visit http://gerrit.cloudera.org:8080/19707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57436be139d56fb9f028a2cdeab412cc60631a06
Gerrit-Change-Number: 19707
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 21:48:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12050: Exclude kryo-shaded from the Java build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19707 )
Change subject: IMPALA-12050: Exclude kryo-shaded from the Java build
......................................................................
IMPALA-12050: Exclude kryo-shaded from the Java build
Kryo is a serialization library that is brought in by Apache Hudi. It is
not used by Impala at runtime when running tests that use Hudi
(hudi-parquet.test).
TESTING
- Exhaustive tests ran clean
- Verified kryo-shaded is no longer present in dependencies.
Change-Id: I57436be139d56fb9f028a2cdeab412cc60631a06
Reviewed-on: http://gerrit.cloudera.org:8080/19707
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/pom.xml
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I57436be139d56fb9f028a2cdeab412cc60631a06
Gerrit-Change-Number: 19707
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-12050: Exclude kryo-shaded from the Java build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19707 )
Change subject: IMPALA-12050: Exclude kryo-shaded from the Java build
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57436be139d56fb9f028a2cdeab412cc60631a06
Gerrit-Change-Number: 19707
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Apr 2023 03:12:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12050: Exclude kryo-shaded from the Java build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19707 )
Change subject: IMPALA-12050: Exclude kryo-shaded from the Java build
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9208/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57436be139d56fb9f028a2cdeab412cc60631a06
Gerrit-Change-Number: 19707
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 21:59:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12050: Exclude kryo-shaded from the Java build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19707 )
Change subject: IMPALA-12050: Exclude kryo-shaded from the Java build
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57436be139d56fb9f028a2cdeab412cc60631a06
Gerrit-Change-Number: 19707
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 21:59:52 +0000
Gerrit-HasComments: No