You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhangyongtian (via GitHub)" <gi...@apache.org> on 2023/04/24 13:08:08 UTC
[GitHub] [doris] zhangyongtian opened a new pull request, #19015: [Fix] Fix the extension mysql_to_doris bug #18993
zhangyongtian opened a new pull request, #19015:
URL: https://github.com/apache/doris/pull/19015
extension mysql_to_doris: Expected: ADMIN is keyword, maybe ADMIN
# Proposed changes
Issue Number: close #18993
## Problem summary
1. The table names generated by the original code are as follows. If there is a keyword table like admin above, an error will be reported.
2. The modified effect is as follows.
## Checklist(Required)
* [x] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19015: [Fix] Fix the extension mysql_to_doris bug #18993
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19015:
URL: https://github.com/apache/doris/pull/19015#issuecomment-1521040075
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19015: [Fix] Fix the extension mysql_to_doris bug #18993
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19015:
URL: https://github.com/apache/doris/pull/19015#issuecomment-1521040058
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #19015: [Fix] Fix the extension mysql_to_doris bug #18993
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #19015:
URL: https://github.com/apache/doris/pull/19015#issuecomment-1521039810
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhangyongtian commented on pull request #19015: [Fix] Fix the extension mysql_to_doris bug #18993
Posted by "zhangyongtian (via GitHub)" <gi...@apache.org>.
zhangyongtian commented on PR #19015:
URL: https://github.com/apache/doris/pull/19015#issuecomment-1521279894
> LGTM
Hello, can you help me restart it? There was an error in the title I just submitted. Below is my newly revised PR.
https://github.com/apache/doris/pull/19024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhangyongtian closed pull request #19015: [Fix] Fix the extension mysql_to_doris bug #18993
Posted by "zhangyongtian (via GitHub)" <gi...@apache.org>.
zhangyongtian closed pull request #19015: [Fix] Fix the extension mysql_to_doris bug #18993
URL: https://github.com/apache/doris/pull/19015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org