You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/08 00:35:32 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request, #21372: Refactor jdbcUrl to url in data pipeline

sandynz opened a new pull request, #21372:
URL: https://github.com/apache/shardingsphere/pull/21372

   
   Changes proposed in this pull request:
     - Refactor jdbcUrl to url in data pipeline
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have passed maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #21372: Refactor jdbcUrl to url in data pipeline

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21372:
URL: https://github.com/apache/shardingsphere/pull/21372#issuecomment-1272190284

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21372?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#21372](https://codecov.io/gh/apache/shardingsphere/pull/21372?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d6d9c09) into [master](https://codecov.io/gh/apache/shardingsphere/commit/f4080b1b3ddcaa9eb15e87e50a6fb0d2fe2baa7f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f4080b1) will **decrease** coverage by `0.00%`.
   > The diff coverage is `70.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #21372      +/-   ##
   ============================================
   - Coverage     61.57%   61.57%   -0.01%     
   + Complexity     2507     2506       -1     
   ============================================
     Files          4089     4089              
     Lines         56609    56606       -3     
     Branches       7487     7487              
   ============================================
   - Hits          34858    34855       -3     
     Misses        18832    18832              
     Partials       2919     2919              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21372?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../datasource/config/yaml/YamlJdbcConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/21372/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2FwaS9kYXRhc291cmNlL2NvbmZpZy95YW1sL1lhbWxKZGJjQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...ngauss/ingest/wal/OpenGaussLogicalReplication.java](https://codecov.io/gh/apache/shardingsphere/pull/21372/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvZGlhbGVjdC9vcGVuZ2F1c3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvb3BlbmdhdXNzL2luZ2VzdC93YWwvT3BlbkdhdXNzTG9naWNhbFJlcGxpY2F0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../impl/StandardPipelineDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/21372/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2FwaS9kYXRhc291cmNlL2NvbmZpZy9pbXBsL1N0YW5kYXJkUGlwZWxpbmVEYXRhU291cmNlQ29uZmlndXJhdGlvbi5qYXZh) | `82.35% <80.00%> (-0.51%)` | :arrow_down: |
   | [.../pipeline/mysql/ingest/MySQLIncrementalDumper.java](https://codecov.io/gh/apache/shardingsphere/pull/21372/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvZGlhbGVjdC9teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9teXNxbC9pbmdlc3QvTXlTUUxJbmNyZW1lbnRhbER1bXBlci5qYXZh) | `63.63% <100.00%> (ø)` | |
   | [...line/postgresql/ingest/wal/LogicalReplication.java](https://codecov.io/gh/apache/shardingsphere/pull/21372/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvZGlhbGVjdC9wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3Bvc3RncmVzcWwvaW5nZXN0L3dhbC9Mb2dpY2FsUmVwbGljYXRpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on pull request #21372: Refactor jdbcUrl to url in data pipeline

Posted by GitBox <gi...@apache.org>.
sandynz commented on PR #21372:
URL: https://github.com/apache/shardingsphere/pull/21372#issuecomment-1272192966

   There's a possible problem: `jdbcUrl` and `url` are valid in data source properties, if old version `dataSources` in registry center use `jdbcUrl`, then it might cause issue (`url` will be null).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #21372: Refactor jdbcUrl to url in data pipeline YamlJdbcConfiguration

Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #21372:
URL: https://github.com/apache/shardingsphere/pull/21372


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org