You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/02/04 15:41:55 UTC
[GitHub] [bookkeeper] dmercuriali commented on issue #2254: Issue 2218:
Write customMetadata on ledgers created by DistributedLog
dmercuriali commented on issue #2254: Issue 2218: Write customMetadata on ledgers created by DistributedLog
URL: https://github.com/apache/bookkeeper/pull/2254#issuecomment-581970432
> @dmercuriali the approach is good.
> You have some javac error:
>
> ```
>
> 2020-01-30T17:03:44.4179776Z Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient/4.4.1/httpclient-4.4.1.jar (721 kB at 6.3 MB/s)
> 2020-01-30T17:04:01.7976679Z [ERROR] COMPILATION ERROR :
> 2020-01-30T17:04:01.7986913Z [ERROR] /home/runner/work/bookkeeper/bookkeeper/stream/distributedlog/core/src/main/java/org/apache/distributedlog/api/DistributedLogManager.java:[116,33] cannot find symbol
> 2020-01-30T17:04:01.7991275Z symbol: method failedFuture(java.lang.UnsupportedOperationException)
> 2020-01-30T17:04:01.7994806Z location: class java.util.concurrent.CompletableFuture
> 2020-01-30T17:04:01.8023930Z [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project distributedlog-core: Compilation failure
> 2020-01-30T17:04:01.8033444Z [ERROR] /home/runner/work/bookkeeper/bookkeeper/stream/distributedlog/core/src/main/java/org/apache/distributedlog/api/DistributedLogManager.java:[116,33] cannot find symbol
> 2020-01-30T17:04:01.8039627Z [ERROR] symbol: method failedFuture(java.lang.UnsupportedOperationException)
> 2020-01-30T17:04:01.8044182Z [ERROR] location: class java.util.concurrent.CompletableFuture
> 2020-01-30T17:04:01.8045720Z [ERROR]
> ```
Fixed, my bad for building with jdk-11 locally.
Also added some tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services