You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/10/03 15:06:38 UTC

[native-toolchain-CR] IMPALA-14471: Bump up KUDU VERSION to pick up array column type

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23491


Change subject: IMPALA-14471: Bump up KUDU_VERSION to pick up array column type
......................................................................

IMPALA-14471: Bump up KUDU_VERSION to pick up array column type

This patch update Impala toolchain Kudu up to
d908d6617368c02b36fff4136eb56fd32e5b0e8f to pick up Kudu array column
feature (KUDU-1261).

Testing:
- Run impala prototype code that insert and select Kudu array column
  using this toolchain and confirm that the code works.

Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
---
M buildall.sh
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/91/23491/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
Gerrit-Change-Number: 23491
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[native-toolchain-CR] IMPALA-14471: Bump up KUDU VERSION to pick up array column type

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23491 )

Change subject: IMPALA-14471: Bump up KUDU_VERSION to pick up array column type
......................................................................


Patch Set 2:

We should wait and include this Kudu patch as well: https://gerrit.cloudera.org/c/23490/


-- 
To view, visit http://gerrit.cloudera.org:8080/23491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
Gerrit-Change-Number: 23491
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 17:34:10 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14471: Bump up KUDU VERSION to pick up array column type

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23491 )

Change subject: IMPALA-14471: Bump up KUDU_VERSION to pick up array column type
......................................................................


Patch Set 3: Verified+1

To speed the Impala change up, I'm submitting this to get the build started.


-- 
To view, visit http://gerrit.cloudera.org:8080/23491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
Gerrit-Change-Number: 23491
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 19:50:28 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14471: Bump up KUDU VERSION to pick up array column type

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23491 )

Change subject: IMPALA-14471: Bump up KUDU_VERSION to pick up array column type
......................................................................


Patch Set 3: Code-Review+1

> (1 comment)

Yes, Kudu's upstream master branch is ahead of 1.18.1.  In particular, it contains all the recent development regarding array data type support.

From the other side, Kudu master branch contain all what's in 1.18.1. In Kudu, everything first gets into the master branch, and then it's cherry-picked/merged into other supported branches.


-- 
To view, visit http://gerrit.cloudera.org:8080/23491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
Gerrit-Change-Number: 23491
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 19:36:06 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14471: Bump up KUDU VERSION to pick up array column type

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23491 )

Change subject: IMPALA-14471: Bump up KUDU_VERSION to pick up array column type
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23491/1/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/23491/1/buildall.sh@212
PS1, Line 212:   export KUDU_VERSION=d908d6617
This ref appears to come from master, not branch-1.18.x. Please update the comment, and check that it contains everything from branch-1.18.x.



-- 
To view, visit http://gerrit.cloudera.org:8080/23491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
Gerrit-Change-Number: 23491
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 15:23:35 +0000
Gerrit-HasComments: Yes

[native-toolchain-CR] IMPALA-14471: Bump up KUDU VERSION to pick up array column type

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23491 )

Change subject: IMPALA-14471: Bump up KUDU_VERSION to pick up array column type
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23491/1/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/23491/1/buildall.sh@212
PS1, Line 212:   export KUDU_VERSION=d908d6617
> This ref appears to come from master, not branch-1.18.x. Please update the 
Good point. This is actually commit hash from Kudu master branch. Is it OK?



-- 
To view, visit http://gerrit.cloudera.org:8080/23491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
Gerrit-Change-Number: 23491
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 15:46:24 +0000
Gerrit-HasComments: Yes

[native-toolchain-CR] IMPALA-14471: Bump up KUDU VERSION to pick up array column type

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23491 )

Change subject: IMPALA-14471: Bump up KUDU_VERSION to pick up array column type
......................................................................


Patch Set 3: Code-Review+2

The change looks good to me. Let's kick off an x86_64 and ARM builds with all distros before submitting.


-- 
To view, visit http://gerrit.cloudera.org:8080/23491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
Gerrit-Change-Number: 23491
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 19:22:26 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14471: Bump up KUDU VERSION to pick up array column type

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23491 )

Change subject: IMPALA-14471: Bump up KUDU_VERSION to pick up array column type
......................................................................

IMPALA-14471: Bump up KUDU_VERSION to pick up array column type

This patch update Impala toolchain Kudu up to
16689973a72e03649898c568d7ab423bc4bb8a35 to pick up Kudu array column
feature (KUDU-1261).

Testing:
- Run impala prototype code that insert and select Kudu array column
  using this toolchain and confirm that the code works.

Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
Reviewed-on: http://gerrit.cloudera.org:8080/23491
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M buildall.sh
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved; Verified
  Alexey Serbin: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.cloudera.org:8080/23491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
Gerrit-Change-Number: 23491
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[native-toolchain-CR] IMPALA-14471: Bump up KUDU VERSION to pick up array column type

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23491 )

Change subject: IMPALA-14471: Bump up KUDU_VERSION to pick up array column type
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23491/1/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/23491/1/buildall.sh@212
PS1, Line 212:   export KUDU_VERSION=d908d6617
> Good point. This is actually commit hash from Kudu master branch. Is it OK?
It could be ok, just want to make sure it includes recent fixes for Ubuntu 24 and OpenSSL that we picked up from branch-1.18.x.



-- 
To view, visit http://gerrit.cloudera.org:8080/23491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
Gerrit-Change-Number: 23491
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 15:59:15 +0000
Gerrit-HasComments: Yes

[native-toolchain-CR] IMPALA-14471: Bump up KUDU VERSION to pick up array column type

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Laszlo Gaal, Joe McDonnell, Michael Smith, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23491

to look at the new patch set (#2).

Change subject: IMPALA-14471: Bump up KUDU_VERSION to pick up array column type
......................................................................

IMPALA-14471: Bump up KUDU_VERSION to pick up array column type

This patch update Impala toolchain Kudu up to
d908d6617368c02b36fff4136eb56fd32e5b0e8f to pick up Kudu array column
feature (KUDU-1261).

Testing:
- Run impala prototype code that insert and select Kudu array column
  using this toolchain and confirm that the code works.

Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
---
M buildall.sh
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/91/23491/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
Gerrit-Change-Number: 23491
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[native-toolchain-CR] IMPALA-14471: Bump up KUDU VERSION to pick up array column type

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Laszlo Gaal, Joe McDonnell, Michael Smith, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23491

to look at the new patch set (#3).

Change subject: IMPALA-14471: Bump up KUDU_VERSION to pick up array column type
......................................................................

IMPALA-14471: Bump up KUDU_VERSION to pick up array column type

This patch update Impala toolchain Kudu up to
16689973a72e03649898c568d7ab423bc4bb8a35 to pick up Kudu array column
feature (KUDU-1261).

Testing:
- Run impala prototype code that insert and select Kudu array column
  using this toolchain and confirm that the code works.

Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
---
M buildall.sh
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/91/23491/3
-- 
To view, visit http://gerrit.cloudera.org:8080/23491
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I63fce7f4c6e8d8a8486bedaa74030281be823406
Gerrit-Change-Number: 23491
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>