You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by hn...@apache.org on 2022/04/29 09:57:41 UTC
[myfaces-tobago] 02/03: refactor(sheet): explicit bootstrap sort icons
This is an automated email from the ASF dual-hosted git repository.
hnoeth pushed a commit to branch tobago-5.x
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git
commit 7c8dc9a44de1f05aac8dc77a12a787a96c93df67
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Fri Apr 29 11:47:57 2022 +0200
refactor(sheet): explicit bootstrap sort icons
* use bootstrap sort icons
* improve positioning
Issue: TOBAGO-2129
---
tobago-theme/src/main/scss/_tobago.scss | 45 ++++++++++++++++++---------------
1 file changed, 25 insertions(+), 20 deletions(-)
diff --git a/tobago-theme/src/main/scss/_tobago.scss b/tobago-theme/src/main/scss/_tobago.scss
index 73894d10b0..24b443075b 100644
--- a/tobago-theme/src/main/scss/_tobago.scss
+++ b/tobago-theme/src/main/scss/_tobago.scss
@@ -27,9 +27,9 @@ $icon-star-fill: "\f586";
$icon-star-sep: " ";
$icon-stars: $icon-star-fill + $icon-star-sep + $icon-star-fill + $icon-star-sep + $icon-star-fill + $icon-star-sep + $icon-star-fill + $icon-star-sep + $icon-star-fill;
$icon-trash: "\f5de";
-$icon-sort: "\f2f1";
-$icon-sort-ascending: "\f238";
-$icon-sort-descending: "\f22c";
+$icon-sort: "\F127";
+$icon-sort-ascending: "\F57B";
+$icon-sort-descending: "\F575";
/* non-bootstrap variables --------------------------------------- */
@@ -1326,6 +1326,28 @@ tobago-sheet {
cursor: col-resize;
}
+ .tobago-sortable {
+ &:after {
+ font-family: bootstrap-icons;
+ content: $icon-sort;
+ font-weight: normal;
+ -webkit-font-smoothing: antialiased;
+ vertical-align: -0.125em;
+ margin-left: 0.5rem;
+ opacity: 0.5;
+ }
+
+ &.tobago-ascending::after {
+ content: $icon-sort-ascending;
+ opacity: 1;
+ }
+
+ &.tobago-descending::after {
+ content: $icon-sort-descending;
+ opacity: 1;
+ }
+ }
+
.tobago-body {
overflow-y: auto;
flex: 1 1 auto;
@@ -1377,23 +1399,6 @@ tobago-sheet {
}
}
-.tobago-sortable::after {
- content: $icon-sort;
- font-family: bootstrap-icons;
- color: $gray-300;
- margin-left: $spacer;
-}
-
-.tobago-ascending::after {
- content: $icon-sort-ascending;
- color: inherit;
-}
-
-.tobago-descending::after {
- content: $icon-sort-descending;
- color: inherit;
-}
-
.tobago-tableLayout-fixed {
table-layout: fixed;
}