You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/11/06 20:36:33 UTC

Review Request 63594: Improve fetcher exit status log message.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63594/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-8173
    https://issues.apache.org/jira/browse/MESOS-8173


Repository: mesos


Description
-------

When the fetcher fails, we emit a message with its exit status,
but the `status` is the return value from wait(2) so we should
be using WSTRINGIFY.


Diffs
-----

  src/slave/containerizer/fetcher.cpp ba5b0979aa427c5b3dbacf39661d6027da13e0d6 


Diff: https://reviews.apache.org/r/63594/diff/1/


Testing
-------

make check (Fedora 26)


Thanks,

James Peach


Re: Review Request 63594: Improved the fetcher exit status log message.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63594/#review190220
-----------------------------------------------------------


Ship it!




Ship It!

- Jiang Yan Xu


On Nov. 6, 2017, 12:36 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63594/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2017, 12:36 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8173
>     https://issues.apache.org/jira/browse/MESOS-8173
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the fetcher fails, we emit a message with its exit status,
> but the `status` is the return value from wait(2) so we should
> be using WSTRINGIFY.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/fetcher.cpp ba5b0979aa427c5b3dbacf39661d6027da13e0d6 
> 
> 
> Diff: https://reviews.apache.org/r/63594/diff/3/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>